mei: check whether hw start has succeeded
Subsystems (2)
hw start may fail therefore the reset flow has
to check for the return value
Signed-off-by Tomas Winkler <[email protected]>
--- drivers/misc/mei/init.c | 7 ++++++- drivers/misc/mei/mei_dev.h | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-)
drivers/misc/mei/init.c +6 -1
@@ -181,7 +181,12 @@ void mei_reset(struct mei_device *dev, int interrupts_enabled)return ; } -mei_hw_start (dev); + ret =mei_hw_start (dev); +if (ret) { +dev_err (&dev->pdev->dev,"hw_start failed disabling the device\n" ); + dev->dev_state =MEI_DEV_DISABLED ; +return ; + }dev_dbg (&dev->pdev->dev,"link is established start sending messages.\n" );/* link is established * start sending messages. */
drivers/misc/mei/mei_dev.h +2 -2
@@ -544,9 +544,9 @@ static inline int mei_hw_reset(struct mei_device *dev, bool enable)return dev->ops->hw_reset (dev, enable); } -static inline void mei_hw_start (struct mei_device *dev) +static inline int mei_hw_start (struct mei_device *dev) { - dev->ops->hw_start (dev); +return dev->ops->hw_start (dev); }static inline void mei_clear_interrupts (struct mei_device *dev)
Signature · 1 line
1.8.1.2