Skip to contentSkip to conversation

Makefile: fix mixed implicit and normal rules

PATCH In review Alexander Aring 2 participants 4 messages Jul 2, 2013 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: fix mixed implicit and normal rules

Getting "Makefile:484: *** mixed implicit and normal rules. Stop." with make version "GNU Make 3.82".

This patch will fix this issue.

---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index d82e795..4b250dd 100644
@@ -481,7 +481,7 @@ export KBUILD_BINARY ?= barebox.bin
 barebox-flash-image: $(KBUILD_IMAGE) FORCE
 	$(call if_changed,ln)
 
-images images/%.s: barebox.bin FORCE
+images/%.s: barebox.bin FORCE
 	$(Q)$(MAKE) $(build)=images $@
 
 ifdef CONFIG_PBL_MULTI_IMAGES
Signature · 7 lines
1.8.3.2


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw

Hi,

i am not a make expert but this is a common error with newer make versions.

But I think this solution isn't correct. It's better to split in two rules like:

images/%.s: barebox.bin FORCE

        $(Q)$(MAKE) $(build)=images $@

images: barebox.bin FORCE

        $(Q)$(MAKE) $(build)=images $@

Getting this information from:
http://www.linuxquestions.org/questions/linux-software-2/error-mixed-implicit-and-normal-rules-while-trying-to-build-busybox-826795/

Regards
Alex

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#2 lore raw

Am Dienstag, den 02.07.2013, 14:24 +0200 schrieb Alexander Aring:

Quoted 11 lines

Hi,

i am not a make expert but this is a common error with newer make versions.

But I think this solution isn't correct. It's better to split in two rules like:

images/%.s: barebox.bin FORCE

        $(Q)$(MAKE) $(build)=images $@
Quoted 10 lines

images: barebox.bin FORCE

        $(Q)$(MAKE) $(build)=images $@

Getting this information from:
http://www.linuxquestions.org/questions/linux-software-2/error-mixed-implicit-and-normal-rules-while-trying-to-build-busybox-826795/

Regards
Alex

This is already fixed. See message [email protected]
"[PATCH] Split Multimage Makefile rule in explicit and implicit parts"

Regards,
Lucas

Signature · 10 lines
Pengutronix e.K.                           | Lucas Stach                 |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#3 lore raw

Hi,

Quoted 18 lines · Lucas Stach

Am Dienstag, den 02.07.2013, 14:24 +0200 schrieb Alexander Aring:

Quoted 17 lines

Hi,

i am not a make expert but this is a common error with newer make versions.

But I think this solution isn't correct. It's better to split in two rules like:

images/%.s: barebox.bin FORCE

        $(Q)$(MAKE) $(build)=images $@

images: barebox.bin FORCE

        $(Q)$(MAKE) $(build)=images $@

Getting this information from:
http://www.linuxquestions.org/questions/linux-software-2/error-mixed-implicit-and-normal-rules-while-trying-to-build-busybox-826795/

Quoted 8 lines
Quoted 4 lines

Regards
Alex

This is already fixed. See message [email protected]
"[PATCH] Split Multimage Makefile rule in explicit and implicit parts"

ah good to know. Thanks and sry for the noise. :-)

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox