gpio: palmas: add dt support
Subsystems (2)
PATCH v3 1/1 gpio: palmas: add dt support
Add of_device_id table for Palma GPIO to be enable the driver from DT file.
The driver can be registered from DT file as:
palmas: tps65913@58 {
:::::::::::
palmas_gpio: palmas_gpio {
compatible = "ti,palmas-gpio";
gpio-controller;
#gpio-cells = <2>;
};
};---
Long back, I sent the similar patch but it was paused due to the DT binding.
http://lkml.indiana.edu/hypermail/linux/kernel/1304.2/00261.html
Now, PMIC DT binding is already finalised and as per mfd binding, we can go ahead with similar approach for gpios. pmic and other palams sub devices are already following the same approach.
Sending 3rd version of the change which is same as per code is related but adding devicetree binding document for gpio also at this time.
.../devicetree/bindings/gpio/gpio-palmas.txt | 25 ++++++++++++++++++++ drivers/gpio/gpio-palmas.c | 12 ++++++++- 2 files changed, 36 insertions(+), 1 deletions(-) create mode 100644 Documentation/devicetree/bindings/gpio/gpio-palmas.txt
Documentation/devicetree/bindings/gpio/gpio-palmas.txt new file +25 -0
@@ -0,0 +1,25 @@ +Palmas GPIO controller bindings + +Required properties: +- compatible: + - "ti,palams-gpio" for palma series of the GPIO controller + - "ti,tps80036-gpio" for Palma series device TPS80036. + - "ti,tps65913-gpio" for palma series device TPS65913. + - "ti,tps65914-gpio" for palma series device TPS65914. +- #gpio-cells : Should be two. + - first cell is the gpio pin number + - second cell is used to specify optional parameters (unused) +- gpio-controller : Marks the device node as a GPIO controller. + +Note: This gpio node will be sub node of palmas node. + +Example: + palmas: tps65913@58 { + ::::::::::: + palmas_gpio: palmas_gpio { + compatible = "ti,palmas-gpio"; + gpio-controller; + #gpio-cells = <2>; + }; + ::::::::::: + };
drivers/gpio/gpio-palmas.c +11 -1
@@ -134,7 +134,7 @@ static int palmas_gpio_probe(struct platform_device *pdev) palmas_gpio->gpio_chip.get = palmas_gpio_get; palmas_gpio->gpio_chip.dev = &pdev->dev;#ifdef CONFIG_OF_GPIO - palmas_gpio->gpio_chip.of_node = palmas->dev->of_node; + palmas_gpio->gpio_chip.of_node = pdev->dev.of_node;#endif palmas_pdata =dev_get_platdata (palmas->dev);if (palmas_pdata && palmas_pdata->gpio_base)
@@ -159,9 +159,19 @@ static int palmas_gpio_remove(struct platform_device *pdev)return gpiochip_remove (&palmas_gpio->gpio_chip); } +static struct of_device_id of_palmas_gpio_match[] = { + { .compatible ="ti,palmas-gpio" }, + { .compatible ="ti,tps65913-gpio" }, + { .compatible ="ti,tps65914-gpio" }, + { .compatible ="ti,tps80036-gpio" }, + { }, +}; +MODULE_DEVICE_TABLE (of, of_palmas_gpio_match); +static struct platform_driver palmas_gpio_driver = { .driver.name ="palmas-gpio" , .driver.owner =THIS_MODULE , + .driver.of_match_table = of_palmas_gpio_match, .probe = palmas_gpio_probe, .remove = palmas_gpio_remove, };
Signature · 1 line
1.7.1.1
Quoted 13 lines · Laxman Dewangan
Add
of_device_idtable for Palma GPIO to be enable the driver from DT file.The driver can be registered from DT file as:
palmas: tps65913@58 { ::::::::::: palmas_gpio: palmas_gpio { compatible = "ti,palmas-gpio"; gpio-controller; #gpio-cells = <2>; }; };
Quoted 1 line
Signed-off-by Laxman Dewangan <[email protected]>
Looks alright to me, but please resend this and include [email protected] on the repost, this is where DT bindings gets reviewed nowadays.
Yours,
Linus Walleij