Skip to contentSkip to conversation

aic7xxx/aic7770: replaced string duplication code with kstrdup

PATCH New Dragos Foianu 1 participant 1 message Jul 13, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 aic7xxx/aic7770: replaced string duplication code with kstrdup

Now using kstrdup instead of its implementation.

Found using coccinelle.

---
 drivers/scsi/aic7xxx/aic7770_osm.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/aic7xxx/aic7770_osm.c +1 -2
index 0cb8ef6..3d401d0 100644
@@ -85,10 +85,9 @@ aic7770_probe(struct device *dev)
 	int	error;
 
 	sprintf(buf, "ahc_eisa:%d", eisaBase >> 12);
-	name = kmalloc(strlen(buf) + 1, GFP_ATOMIC);
+	name = kstrdup(buf, GFP_ATOMIC);
 	if (name == NULL)
 		return (ENOMEM);
-	strcpy(name, buf);
 	ahc = ahc_alloc(&aic7xxx_driver_template, name);
 	if (ahc == NULL)
 		return (ENOMEM);
Signature · 1 line
1.7.10.4