perf, tools, bench: Fix memcpy benchmark for large sizes v2
PATCH 1/1 perf, tools, bench: Fix memcpy benchmark for large sizes v2
From: Andi Kleen <[email protected]>
glibc calloc() has an optimization to not explicitely memset() very large calloc allocations that just came from mmap(), because they are known to be zero.
This could result in the perf memcpy benchmark reading only from the zero page, which gives unrealistic results.
Always call memset explicitly on the source area to avoid this problem.
Cc: [email protected]
Cc: [email protected]
v2: Actually memset the right area and also fix the NULL check before.
--- tools/perf/bench/mem-memcpy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/bench/mem-memcpy.c +3 -1
@@ -115,8 +115,10 @@ static void alloc_mem(void **dst, void **src, size_t length)die ("memory allocation failed - maybe length is too large?\n" ); *src =zalloc (length); -if (!src) +if (!*src)die ("memory allocation failed - maybe length is too large?\n" ); +/* Make sure to always replace the zero pages even if MMAP_THRESH is crossed */ +memset (*src,0 , length); }static u64 do_memcpy_cycle (memcpy_t fn,size_t len,bool prefault)
Signature · 1 line
1.8.1.4
At Thu, 18 Jul 2013 15:43:18 -0700,
Quoted 25 lines · Andi Kleen
From: Andi Kleen <[email protected]>
glibc
calloc()has an optimization to not explicitelymemset()very large calloc allocations that just came frommmap(), because they are known to be zero.This could result in the perf memcpy benchmark reading only from the zero page, which gives unrealistic results.
Always call memset explicitly on the source area to avoid this problem.
Cc: [email protected]
Cc: [email protected]
v2: Actually memset the right area and also fix the NULL check before.Signed-off-by Andi Kleen <[email protected]>--- tools/perf/bench/mem-memcpy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)tools/perf/bench/mem-memcpy.c +0
-0
tools/perf/bench/mem-memcpy.c static void alloc_mem(void **dst, void **src, size_t length) · line 118
Quoted 5 lines
tools/perf/bench/mem-memcpy.c +1
-1@@ -115,8 +115,10 @@ static void alloc_mem(void **dst, void **src, size_t length)die ("memory allocation failed - maybe length is too large?\n" ); *src =zalloc (length); -if (!src) +if (!*src)
In the latest mem-memcpy.c, this if (!src) is already fixed as if (!*src). This modification makes applying fail.
Thanks,
Hitoshi
Quoted 7 lines
Quoted 7 lines
tools/perf/bench/mem-memcpy.c +0
-0@@ -115,8 +115,10 @@ static void alloc_mem(void **dst, void **src, size_t length)die ("memory allocation failed - maybe length is too large?\n" );
Quoted 6 lines
tools/perf/bench/mem-memcpy.c static void alloc_mem(void **dst, void **src, size_t length) · line 118
Quoted 3 lines
tools/perf/bench/mem-memcpy.c +1
-1*src =zalloc (length); -if (!src) +if (!*src)In the latest
mem-memcpy.c, this if (!src) is already fixed as if (!*src). This modification makes applying fail.
I can undo it, and repost, but the patch would still conflict.
Just whoever applies it has to resolve the trivial conflcit.
-Andi
Signature · 1 line
[email protected] -- Speaking for myself only.
Em Sat, Jul 20, 2013 at 12:57:27AM +0900, Hitoshi Mitake escreveu:
Quoted 10 lines
Quoted 8 lines · Andi Kleen
glibc
calloc()has an optimization to not explicitelymemset()very large calloc allocations that just came frommmap(), because they are known to be zero.This could result in the perf memcpy benchmark reading only from the zero page, which gives unrealistic results.
Always call memset explicitly on the source area to avoid this problem.
Quoted 8 lines
tools/perf/bench/mem-memcpy.c static void alloc_mem(void **dst, void **src, size_t length) · line 116
Quoted 5 lines
+++
b/tools/perf/bench/mem-memcpy.ctools/perf/bench/mem-memcpy.c +1
-1@@ -115,8 +115,10 @@ static void alloc_mem(void **dst, void **src, size_t length) *src =zalloc (length); -if (!src) +if (!*src)In the latest
mem-memcpy.c, this if (!src) is already fixed as if (!*src). This modification makes applying fail.
I fixed this up, please take a look at:
https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/log/?h=perf/core
- Arnaldo
Quoted 20 lines · Arnaldo Carvalho de Melo
Em Sat, Jul 20, 2013 at 12:57:27AM +0900, Hitoshi Mitake escreveu:
Quoted 10 lines
Quoted 8 lines · Andi Kleen
glibc
calloc()has an optimization to not explicitelymemset()very large calloc allocations that just came frommmap(), because they are known to be zero.This could result in the perf memcpy benchmark reading only from the zero page, which gives unrealistic results.
Always call memset explicitly on the source area to avoid this problem.
Quoted 8 lines
tools/perf/bench/mem-memcpy.c static void alloc_mem(void **dst, void **src, size_t length) · line 116
Quoted 5 lines
+++
b/tools/perf/bench/mem-memcpy.ctools/perf/bench/mem-memcpy.c +1
-1@@ -115,8 +115,10 @@ static void alloc_mem(void **dst, void **src, size_t length) *src =zalloc (length); -if (!src) +if (!*src)In the latest
mem-memcpy.c, this if (!src) is already fixed as if (!*src). This modification makes applying fail.
Quoted 5 lines
I fixed this up, please take a look at:
https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/log/?h=perf/core
Looks good. Thanks.
-Andi
Signature · 1 line
[email protected] -- Speaking for myself only.