Seeking for upstreaming patches which floating in Gentoo
Subsystems (2)
Hi Ian:
I'm trying to push a few patches which floating in gentoo linux to
upstream.
My initial motivation is trying to work closely with upstream, and
aim to keep downstream package much more clean at next release.
I'm seeing tree possible results/feedbacks, a) accept patches, which
is perfect! b) need improvement, I can work on and polish. c) impossible to accept, in this case, I'd like to hear your idea to decide whether to drop or still carry on.
thanks
Dennis lan (dlan)
PATCH 1/6 fix compile error with heimdal support enabled
From: "Lan Yixun (dlan)" <[email protected]>
this patch instroduce a compatible layer between Heimdal and MTT Krb5. And I slightly rework the original patch to make it more readable.
---
Upstream Discussion:
http://thread.gmane.org/gmane.linux.kernel.autofs/4203
Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=210762
--- aclocal.m4 | 7 +++++++ modules/cyrus-sasl.c | 35 ++++++++++++++++++++++++++++++----- 2 files changed, 37 insertions(+), 5 deletions(-)
aclocal.m4 +7 -0
@@ -299,6 +299,13 @@ else HAVE_KRB5=1 KRB5_LIBS=`$KRB5_CONFIG --libs` KRB5_FLAGS=`$KRB5_CONFIG --cflags` + + SAVE_CFLAGS=$CFLAGS + SAVE_LIBS=$LIBS + CFLAGS="$CFLAGS $KRB5_FLAGS" + LIBS="$LIBS $KRB5_LIBS" + + AC_CHECK_FUNCS([krb5_principal_get_realm]) fi]) dnl --------------------------------------------------------------------------
modules/cyrus-sasl.c +30 -5
@@ -64,6 +64,31 @@#endif #endif +#ifdef HAVE_KRB5_PRINCIPAL_GET_REALM +void _krb5_princ_realm (krb5_context context,krb5_const_principal princ, +const char **realm,int *len) +{ + *realm =krb5_principal_get_realm (context, princ); + *len =strlen (*realm); +} +#else +void _krb5_princ_realm (krb5_context context,krb5_const_principal princ, +const char **realm,int *len) +{ +const krb5_data *data; + + data =krb5_princ_realm (context, princ); +if (data) { + *realm = data->data; + *len = data->length; + }else { + *realm =NULL ; + *len =0 ; + } +} +#endif + +/* * Once a krb5 credentials cache is setup, we need to set the KRB5CCNAME * environment variable so that the library knows where to find it.
@@ -379,7 +404,8 @@ sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt)krb5_principal tgs_princ, krb5_client_princ;krb5_creds my_creds;char *tgs_name; -int status; +const char *realm_name; +int status, realm_length;if (ctxt->kinit_done)return 0 ;
@@ -450,12 +476,11 @@ sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt) }/* setup a principal for the ticket granting service */ +_krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ, &realm_name, &realm_length); ret =krb5_build_principal_ext (ctxt->krb5ctxt, &tgs_princ, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->length, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->data, + realm_length, realm_name,strlen (KRB5_TGS_NAME ),KRB5_TGS_NAME , -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->length, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->data, + realm_length, realm_name,0 );if (ret) { error(logopt,
Signature · 1 line
1.8.2.1
Ian Kent
maintainerRe: [PATCH 1/6] fix compile error with heimdal support enabled
Quoted 41 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
this patch instroduce a compatible layer between Heimdal and MTT Krb5. And I slightly rework the original patch to make it more readable.
---
Upstream Discussion:
http://thread.gmane.org/gmane.linux.kernel.autofs/4203Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=210762Signed-off-by Lan Yixun (dlan) <[email protected]>--- aclocal.m4 | 7 +++++++ modules/cyrus-sasl.c | 35 ++++++++++++++++++++++++++++++----- 2 files changed, 37 insertions(+), 5 deletions(-)aclocal.m4 +7
-0@@ -299,6 +299,13 @@ else HAVE_KRB5=1 KRB5_LIBS=`$KRB5_CONFIG --libs` KRB5_FLAGS=`$KRB5_CONFIG --cflags` + + SAVE_CFLAGS=$CFLAGS + SAVE_LIBS=$LIBS + CFLAGS="$CFLAGS $KRB5_FLAGS" + LIBS="$LIBS $KRB5_LIBS" + + AC_CHECK_FUNCS([krb5_principal_get_realm]) fi]) dnl --------------------------------------------------------------------------modules/cyrus-sasl.c +0
-0
modules/cyrus-sasl.c line 72
Quoted 9 lines
modules/cyrus-sasl.c +6
-0@@ -64,6 +64,31 @@#endif #endif +#ifdef HAVE_KRB5_PRINCIPAL_GET_REALM +void _krb5_princ_realm (krb5_context context,krb5_const_principal princ, +const char **realm,int *len) +{ + *realm =krb5_principal_get_realm (context, princ); + *len =strlen (*realm);
So krb5_principal_get_realm() never fails, or does it return NULL, what about strlen(NULL) .... SEGV.
Quoted 48 lines
modules/cyrus-sasl.c +24
-5+} +#else +void _krb5_princ_realm (krb5_context context,krb5_const_principal princ, +const char **realm,int *len) +{ +const krb5_data *data; + + data =krb5_princ_realm (context, princ); +if (data) { + *realm = data->data; + *len = data->length; + }else { + *realm =NULL ; + *len =0 ; + } +} +#endif + +/* * Once a krb5 credentials cache is setup, we need to set the KRB5CCNAME * environment variable so that the library knows where to find it. @@ -379,7 +404,8 @@ sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt)krb5_principal tgs_princ, krb5_client_princ;krb5_creds my_creds;char *tgs_name; -int status; +const char *realm_name; +int status, realm_length;if (ctxt->kinit_done)return 0 ;@@ -450,12 +476,11 @@ sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt) }/* setup a principal for the ticket granting service */ +_krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ, &realm_name, &realm_length); ret =krb5_build_principal_ext (ctxt->krb5ctxt, &tgs_princ, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->length, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->data, + realm_length, realm_name,strlen (KRB5_TGS_NAME ),KRB5_TGS_NAME , -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->length, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->data, + realm_length, realm_name,0 );if (ret) { error(logopt,
Re: [PATCH 1/6] fix compile error with heimdal support enabled
Quoted 90 lines · Ian Kent
Quoted 41 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
this patch instroduce a compatible layer between Heimdal and MTT Krb5. And I slightly rework the original patch to make it more readable.
---
Upstream Discussion:
http://thread.gmane.org/gmane.linux.kernel.autofs/4203Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=210762Signed-off-by Lan Yixun (dlan) <[email protected]>--- aclocal.m4 | 7 +++++++ modules/cyrus-sasl.c | 35 ++++++++++++++++++++++++++++++----- 2 files changed, 37 insertions(+), 5 deletions(-)aclocal.m4 +7
-0@@ -299,6 +299,13 @@ else HAVE_KRB5=1 KRB5_LIBS=`$KRB5_CONFIG --libs` KRB5_FLAGS=`$KRB5_CONFIG --cflags` + + SAVE_CFLAGS=$CFLAGS + SAVE_LIBS=$LIBS + CFLAGS="$CFLAGS $KRB5_FLAGS" + LIBS="$LIBS $KRB5_LIBS" + + AC_CHECK_FUNCS([krb5_principal_get_realm]) fi]) dnl --------------------------------------------------------------------------modules/cyrus-sasl.c +0
-0modules/cyrus-sasl.c line 72
Quoted 9 lines
modules/cyrus-sasl.c +6
-0@@ -64,6 +64,31 @@#endif #endif +#ifdef HAVE_KRB5_PRINCIPAL_GET_REALM +void _krb5_princ_realm (krb5_context context,krb5_const_principal princ, +const char **realm,int *len) +{ + *realm =krb5_principal_get_realm (context, princ); + *len =strlen (*realm);So
krb5_principal_get_realm()never fails, or does it return NULL, what about strlen(NULL) .... SEGV.Quoted 35 lines
modules/cyrus-sasl.c +21
-1+} +#else +void _krb5_princ_realm (krb5_context context,krb5_const_principal princ, +const char **realm,int *len) +{ +const krb5_data *data; + + data =krb5_princ_realm (context, princ); +if (data) { + *realm = data->data; + *len = data->length; + }else { + *realm =NULL ; + *len =0 ; + } +} +#endif + +/* * Once a krb5 credentials cache is setup, we need to set the KRB5CCNAME * environment variable so that the library knows where to find it. @@ -379,7 +404,8 @@ sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt)krb5_principal tgs_princ, krb5_client_princ;krb5_creds my_creds;char *tgs_name; -int status; +const char *realm_name; +int status, realm_length;if (ctxt->kinit_done)return 0 ;@@ -450,12 +476,11 @@ sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt) }
Quoted 15 lines
modules/cyrus-sasl.c sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt) · line 486
Quoted 13 lines
modules/cyrus-sasl.c +3
-4/* setup a principal for the ticket granting service */ +_krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ, &realm_name, &realm_length); ret =krb5_build_principal_ext (ctxt->krb5ctxt, &tgs_princ, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->length, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->data, + realm_length, realm_name,strlen (KRB5_TGS_NAME ),KRB5_TGS_NAME , -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->length, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->data, + realm_length, realm_name,0 );if (ret) { error(logopt,
HI Ian:
As I looking into the code (krb5_principal_get_realm) which provided
by heimdal, there is no grantee that *realm will always be valid (does't do internal check, and does't return "" empty string if fail). But, as my knowledge here, I guess we should already grantee that *realm is valid before calling this function,
It won't hurt if we add add a check here, so how about this?
*len = (*realm == NULL) ? 0 : strlen(*realm);
Dennis
Ian Kent
maintainerRe: [PATCH 1/6] fix compile error with heimdal support enabled
Quoted 114 lines · Dennis Lan (dlan)
Quoted 90 lines · Ian Kent
Quoted 41 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
this patch instroduce a compatible layer between Heimdal and MTT Krb5. And I slightly rework the original patch to make it more readable.
---
Upstream Discussion:
http://thread.gmane.org/gmane.linux.kernel.autofs/4203Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=210762Signed-off-by Lan Yixun (dlan) <[email protected]>--- aclocal.m4 | 7 +++++++ modules/cyrus-sasl.c | 35 ++++++++++++++++++++++++++++++----- 2 files changed, 37 insertions(+), 5 deletions(-)aclocal.m4 +7
-0@@ -299,6 +299,13 @@ else HAVE_KRB5=1 KRB5_LIBS=`$KRB5_CONFIG --libs` KRB5_FLAGS=`$KRB5_CONFIG --cflags` + + SAVE_CFLAGS=$CFLAGS + SAVE_LIBS=$LIBS + CFLAGS="$CFLAGS $KRB5_FLAGS" + LIBS="$LIBS $KRB5_LIBS" + + AC_CHECK_FUNCS([krb5_principal_get_realm]) fi]) dnl --------------------------------------------------------------------------modules/cyrus-sasl.c +0
-0modules/cyrus-sasl.c line 72
Quoted 9 lines
modules/cyrus-sasl.c +6
-0@@ -64,6 +64,31 @@#endif #endif +#ifdef HAVE_KRB5_PRINCIPAL_GET_REALM +void _krb5_princ_realm (krb5_context context,krb5_const_principal princ, +const char **realm,int *len) +{ + *realm =krb5_principal_get_realm (context, princ); + *len =strlen (*realm);So
krb5_principal_get_realm()never fails, or does it return NULL, what about strlen(NULL) .... SEGV.Quoted 35 lines
modules/cyrus-sasl.c +21
-1+} +#else +void _krb5_princ_realm (krb5_context context,krb5_const_principal princ, +const char **realm,int *len) +{ +const krb5_data *data; + + data =krb5_princ_realm (context, princ); +if (data) { + *realm = data->data; + *len = data->length; + }else { + *realm =NULL ; + *len =0 ; + } +} +#endif + +/* * Once a krb5 credentials cache is setup, we need to set the KRB5CCNAME * environment variable so that the library knows where to find it. @@ -379,7 +404,8 @@ sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt)krb5_principal tgs_princ, krb5_client_princ;krb5_creds my_creds;char *tgs_name; -int status; +const char *realm_name; +int status, realm_length;if (ctxt->kinit_done)return 0 ;@@ -450,12 +476,11 @@ sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt) }Quoted 15 lines
modules/cyrus-sasl.c sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt) · line 486
Quoted 13 lines
modules/cyrus-sasl.c +3
-4/* setup a principal for the ticket granting service */ +_krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ, &realm_name, &realm_length); ret =krb5_build_principal_ext (ctxt->krb5ctxt, &tgs_princ, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->length, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->data, + realm_length, realm_name,strlen (KRB5_TGS_NAME ),KRB5_TGS_NAME , -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->length, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->data, + realm_length, realm_name,0 );if (ret) { error(logopt,HI Ian:
As I looking into the code (krb5_principal_get_realm) which provided
by heimdal, there is no grantee that *realm will always be valid (does't do internal check, and does't return "" empty string if fail). But, as my knowledge here, I guess we should already grantee that *realm is valid before calling this function,
It won't hurt if we add add a check here, so how about this?
Quoted 1 line
*len = (*realm == NULL) ? 0 :
strlen(*realm);
Yeah, so we should be able to be sure it will always never return "".
That's probably a fair assumption ... although maybe *realm should be initialized to NULL on entry to avoid odd arch specific initialization issues.
Quoted 2 lines
Dennis
Re: [PATCH 1/6] fix compile error with heimdal support enabled
Quoted 115 lines · Ian Kent
Quoted 114 lines · Dennis Lan (dlan)
Quoted 90 lines · Ian Kent
Quoted 41 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
this patch instroduce a compatible layer between Heimdal and MTT Krb5. And I slightly rework the original patch to make it more readable.
---
Upstream Discussion:
http://thread.gmane.org/gmane.linux.kernel.autofs/4203Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=210762Signed-off-by Lan Yixun (dlan) <[email protected]>--- aclocal.m4 | 7 +++++++ modules/cyrus-sasl.c | 35 ++++++++++++++++++++++++++++++----- 2 files changed, 37 insertions(+), 5 deletions(-)aclocal.m4 +7
-0@@ -299,6 +299,13 @@ else HAVE_KRB5=1 KRB5_LIBS=`$KRB5_CONFIG --libs` KRB5_FLAGS=`$KRB5_CONFIG --cflags` + + SAVE_CFLAGS=$CFLAGS + SAVE_LIBS=$LIBS + CFLAGS="$CFLAGS $KRB5_FLAGS" + LIBS="$LIBS $KRB5_LIBS" + + AC_CHECK_FUNCS([krb5_principal_get_realm]) fi]) dnl --------------------------------------------------------------------------modules/cyrus-sasl.c +0
-0modules/cyrus-sasl.c line 72
Quoted 9 lines
modules/cyrus-sasl.c +6
-0@@ -64,6 +64,31 @@#endif #endif +#ifdef HAVE_KRB5_PRINCIPAL_GET_REALM +void _krb5_princ_realm (krb5_context context,krb5_const_principal princ, +const char **realm,int *len) +{ + *realm =krb5_principal_get_realm (context, princ); + *len =strlen (*realm);So
krb5_principal_get_realm()never fails, or does it return NULL, what about strlen(NULL) .... SEGV.Quoted 35 lines
modules/cyrus-sasl.c +21
-1+} +#else +void _krb5_princ_realm (krb5_context context,krb5_const_principal princ, +const char **realm,int *len) +{ +const krb5_data *data; + + data =krb5_princ_realm (context, princ); +if (data) { + *realm = data->data; + *len = data->length; + }else { + *realm =NULL ; + *len =0 ; + } +} +#endif + +/* * Once a krb5 credentials cache is setup, we need to set the KRB5CCNAME * environment variable so that the library knows where to find it. @@ -379,7 +404,8 @@ sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt)krb5_principal tgs_princ, krb5_client_princ;krb5_creds my_creds;char *tgs_name; -int status; +const char *realm_name; +int status, realm_length;if (ctxt->kinit_done)return 0 ;@@ -450,12 +476,11 @@ sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt) }Quoted 15 lines
modules/cyrus-sasl.c sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt) · line 486
Quoted 13 lines
modules/cyrus-sasl.c +3
-4/* setup a principal for the ticket granting service */ +_krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ, &realm_name, &realm_length); ret =krb5_build_principal_ext (ctxt->krb5ctxt, &tgs_princ, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->length, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->data, + realm_length, realm_name,strlen (KRB5_TGS_NAME ),KRB5_TGS_NAME , -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->length, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->data, + realm_length, realm_name,0 );if (ret) { error(logopt,HI Ian:
As I looking into the code (krb5_principal_get_realm) which provided
by heimdal, there is no grantee that *realm will always be valid (does't do internal check, and does't return "" empty string if fail). But, as my knowledge here, I guess we should already grantee that *realm is valid before calling this function,
It won't hurt if we add add a check here, so how about this?
Quoted 12 lines
Quoted 1 line
*len = (*realm == NULL) ? 0 :
strlen(*realm);Yeah, so we should be able to be sure it will always never return "".
That's probably a fair assumption ... although maybe *realm should be initialized to NULL on entry to avoid odd arch specific initialization issues.
Quoted 2 lines
Dennis
HI Ian:
How about this one? for the three types of patches ;-)
which should this one belong to?
Thanks
Dennis Lan (dlan)
Ian Kent
maintainerRe: [PATCH 1/6] fix compile error with heimdal support enabled
Quoted 125 lines · Dennis Lan (dlan)
Quoted 124 lines · Ian Kent
Quoted 114 lines · Dennis Lan (dlan)
Quoted 90 lines · Ian Kent
Quoted 41 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
this patch instroduce a compatible layer between Heimdal and MTT Krb5. And I slightly rework the original patch to make it more readable.
---
Upstream Discussion:
http://thread.gmane.org/gmane.linux.kernel.autofs/4203Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=210762Signed-off-by Lan Yixun (dlan) <[email protected]>--- aclocal.m4 | 7 +++++++ modules/cyrus-sasl.c | 35 ++++++++++++++++++++++++++++++----- 2 files changed, 37 insertions(+), 5 deletions(-)aclocal.m4 +7
-0@@ -299,6 +299,13 @@ else HAVE_KRB5=1 KRB5_LIBS=`$KRB5_CONFIG --libs` KRB5_FLAGS=`$KRB5_CONFIG --cflags` + + SAVE_CFLAGS=$CFLAGS + SAVE_LIBS=$LIBS + CFLAGS="$CFLAGS $KRB5_FLAGS" + LIBS="$LIBS $KRB5_LIBS" + + AC_CHECK_FUNCS([krb5_principal_get_realm]) fi]) dnl --------------------------------------------------------------------------modules/cyrus-sasl.c +0
-0modules/cyrus-sasl.c line 72
Quoted 9 lines
modules/cyrus-sasl.c +6
-0@@ -64,6 +64,31 @@#endif #endif +#ifdef HAVE_KRB5_PRINCIPAL_GET_REALM +void _krb5_princ_realm (krb5_context context,krb5_const_principal princ, +const char **realm,int *len) +{ + *realm =krb5_principal_get_realm (context, princ); + *len =strlen (*realm);So
krb5_principal_get_realm()never fails, or does it return NULL, what about strlen(NULL) .... SEGV.Quoted 35 lines
modules/cyrus-sasl.c +21
-1+} +#else +void _krb5_princ_realm (krb5_context context,krb5_const_principal princ, +const char **realm,int *len) +{ +const krb5_data *data; + + data =krb5_princ_realm (context, princ); +if (data) { + *realm = data->data; + *len = data->length; + }else { + *realm =NULL ; + *len =0 ; + } +} +#endif + +/* * Once a krb5 credentials cache is setup, we need to set the KRB5CCNAME * environment variable so that the library knows where to find it. @@ -379,7 +404,8 @@ sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt)krb5_principal tgs_princ, krb5_client_princ;krb5_creds my_creds;char *tgs_name; -int status; +const char *realm_name; +int status, realm_length;if (ctxt->kinit_done)return 0 ;@@ -450,12 +476,11 @@ sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt) }Quoted 15 lines
modules/cyrus-sasl.c sasl_do_kinit(unsigned logopt, struct lookup_context *ctxt) · line 486
Quoted 13 lines
modules/cyrus-sasl.c +3
-4/* setup a principal for the ticket granting service */ +_krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ, &realm_name, &realm_length); ret =krb5_build_principal_ext (ctxt->krb5ctxt, &tgs_princ, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->length, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->data, + realm_length, realm_name,strlen (KRB5_TGS_NAME ),KRB5_TGS_NAME , -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->length, -krb5_princ_realm (ctxt->krb5ctxt, krb5_client_princ)->data, + realm_length, realm_name,0 );if (ret) { error(logopt,HI Ian:
As I looking into the code (krb5_principal_get_realm) which provided
by heimdal, there is no grantee that *realm will always be valid (does't do internal check, and does't return "" empty string if fail). But, as my knowledge here, I guess we should already grantee that *realm is valid before calling this function,
It won't hurt if we add add a check here, so how about this?Quoted 1 line
*len = (*realm == NULL) ? 0 :
strlen(*realm);Yeah, so we should be able to be sure it will always never return "".
That's probably a fair assumption ... although maybe *realm should be initialized to NULL on entry to avoid odd arch specific initialization issues.
Quoted 1 line
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Dennis
HI Ian:
How about this one? for the three types of patches ;-)
which should this one belong to?
All the patches in the series we are discussing, except for patch 9 since it's not finished yet, I want to commit next time I do one. I want to finish patch 9 as well so I can commit it.
The patches are mostly straight forward so I'd like to include them in the 5.0.8 release, which I want to do some time soon. It's overdue ...
Quoted 3 lines
Thanks
Dennis Lan (dlan)
PATCH 2/6 fix dead LDAP symbol link with LDAP support disabled
In reply to Lan Yixun (dlan)From: "Lan Yixun (dlan)" <[email protected]>
autofs will create symbol link mandatory no matter ldap support is enabled or not. so, without this patch, lookup_ldaps.so will become a dead link.
---
Upstream Discussion:
http://thread.gmane.org/gmane.linux.kernel.autofs/5371
--- modules/Makefile | 2 ++ 1 file changed, 2 insertions(+)
modules/Makefile +2 -0
@@ -74,7 +74,9 @@ install: all -rm -f $(INSTALLROOT)$(autofslibdir)/mount_smbfs.so ln -fs lookup_file.so $(INSTALLROOT)$(autofslibdir)/lookup_files.so ln -fs lookup_yp.so $(INSTALLROOT)$(autofslibdir)/lookup_nis.so +ifeq ($(SASL), 1) ln -fs lookup_ldap.so $(INSTALLROOT)$(autofslibdir)/lookup_ldaps.so +endif ln -fs mount_nfs.so $(INSTALLROOT)$(autofslibdir)/mount_nfs4.so ifeq ($(EXT2FS), 1) ifeq ($(EXT3FS), 1)
Signature · 1 line
1.8.2.1
Ian Kent
maintainerRe: [PATCH 2/6] fix dead LDAP symbol link with LDAP support disabled
Quoted 5 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
autofs will create symbol link mandatory no matter ldap support is enabled or not. so, without this patch, lookup_ldaps.so will become a dead link.
I have added this to my patch queue.
It will be committed next time I push patches to the repo. Thanks
Quoted 24 lines
---
Upstream Discussion:
http://thread.gmane.org/gmane.linux.kernel.autofs/5371Signed-off-by Lan Yixun (dlan) <[email protected]>--- modules/Makefile | 2 ++ 1 file changed, 2 insertions(+)modules/Makefile +2
-0@@ -74,7 +74,9 @@ install: all -rm -f $(INSTALLROOT)$(autofslibdir)/mount_smbfs.so ln -fs lookup_file.so $(INSTALLROOT)$(autofslibdir)/lookup_files.so ln -fs lookup_yp.so $(INSTALLROOT)$(autofslibdir)/lookup_nis.so +ifeq ($(SASL), 1) ln -fs lookup_ldap.so $(INSTALLROOT)$(autofslibdir)/lookup_ldaps.so +endif ln -fs mount_nfs.so $(INSTALLROOT)$(autofslibdir)/mount_nfs4.so ifeq ($(EXT2FS), 1) ifeq ($(EXT3FS), 1)
Ian Kent
maintainerRe: [PATCH 2/6] fix dead LDAP symbol link with LDAP support disabled
Quoted 9 lines · Ian Kent
Quoted 5 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
autofs will create symbol link mandatory no matter ldap support is enabled or not. so, without this patch, lookup_ldaps.so will become a dead link.
I have added this to my patch queue.
It will be committed next time I push patches to the repo.
On second thoughts, what if WITH_LDAP is defined and WITH_SASL is not?
Quoted 32 lines
Thanks
Quoted 15 lines
---
Upstream Discussion:
http://thread.gmane.org/gmane.linux.kernel.autofs/5371Signed-off-by Lan Yixun (dlan) <[email protected]>--- modules/Makefile | 2 ++ 1 file changed, 2 insertions(+)modules/Makefile +0
-0modules/Makefile install: all · line 82
Quoted 9 lines
modules/Makefile +2
-0@@ -74,7 +74,9 @@ install: all -rm -f $(INSTALLROOT)$(autofslibdir)/mount_smbfs.so ln -fs lookup_file.so $(INSTALLROOT)$(autofslibdir)/lookup_files.so ln -fs lookup_yp.so $(INSTALLROOT)$(autofslibdir)/lookup_nis.so +ifeq ($(SASL), 1) ln -fs lookup_ldap.so $(INSTALLROOT)$(autofslibdir)/lookup_ldaps.so +endif ln -fs mount_nfs.so $(INSTALLROOT)$(autofslibdir)/mount_nfs4.so ifeq ($(EXT2FS), 1) ifeq ($(EXT3FS), 1)--
To unsubscribe from this list: send the line "unsubscribe autofs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/6] fix dead LDAP symbol link with LDAP support disabled
Quoted 4 lines · Ian Kent
Quoted 3 lines · Ian Kent
Quoted 2 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
autofs will create symbol link mandatory no matter ldap support is enabled or not. so, without this patch, lookup_ldaps.so will become a dead link.
I have added this to my patch queue.
It will be committed next time I push patches to the repo.On second thoughts, what if
WITH_LDAPis defined andWITH_SASLis not?
HI Ian:
current logic is: if SASL is not enabled, then the symbol
lookup_ldaps.so (which link to lookup_ldap.so) will not be created.
what are you suggesting here? should symbol of lookup_ldaps.so be
controlled by LDAP ?
Thanks
Dennis
Quoted 34 lines
Quoted 32 lines
Thanks
Quoted 15 lines
---
Upstream Discussion:
http://thread.gmane.org/gmane.linux.kernel.autofs/5371Signed-off-by Lan Yixun (dlan) <[email protected]>--- modules/Makefile | 2 ++ 1 file changed, 2 insertions(+)modules/Makefile +0
-0modules/Makefile install: all · line 82
Quoted 9 lines
modules/Makefile +2
-0@@ -74,7 +74,9 @@ install: all -rm -f $(INSTALLROOT)$(autofslibdir)/mount_smbfs.so ln -fs lookup_file.so $(INSTALLROOT)$(autofslibdir)/lookup_files.so ln -fs lookup_yp.so $(INSTALLROOT)$(autofslibdir)/lookup_nis.so +ifeq ($(SASL), 1) ln -fs lookup_ldap.so $(INSTALLROOT)$(autofslibdir)/lookup_ldaps.so +endif ln -fs mount_nfs.so $(INSTALLROOT)$(autofslibdir)/mount_nfs4.so ifeq ($(EXT2FS), 1) ifeq ($(EXT3FS), 1)--
To unsubscribe from this list: send the line "unsubscribe autofs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Ian Kent
maintainerRe: [PATCH 2/6] fix dead LDAP symbol link with LDAP support disabled
Quoted 12 lines · Dennis Lan (dlan)
Quoted 11 lines · Ian Kent
Quoted 9 lines · Ian Kent
Quoted 5 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
autofs will create symbol link mandatory no matter ldap support is enabled or not. so, without this patch, lookup_ldaps.so will become a dead link.
I have added this to my patch queue.
It will be committed next time I push patches to the repo.
Quoted 8 lines
Quoted 2 lines
On second thoughts, what if
WITH_LDAPis defined andWITH_SASLis not?HI Ian:
current logic is: if SASL is not enabled, then the symbol
lookup_ldaps.so (which link to lookup_ldap.so) will not be created.
what are you suggesting here? should symbol of lookup_ldaps.so be
controlled by LDAP ?
Ha, yes, I was thinking ldap not ldaps, I'll check again.
Quoted 38 lines
Thanks
Dennis
Quoted 34 lines
Quoted 32 lines
Thanks
Quoted 15 lines
---
Upstream Discussion:
http://thread.gmane.org/gmane.linux.kernel.autofs/5371Signed-off-by Lan Yixun (dlan) <[email protected]>--- modules/Makefile | 2 ++ 1 file changed, 2 insertions(+)modules/Makefile +0
-0modules/Makefile install: all · line 82
Quoted 9 lines
modules/Makefile +2
-0@@ -74,7 +74,9 @@ install: all -rm -f $(INSTALLROOT)$(autofslibdir)/mount_smbfs.so ln -fs lookup_file.so $(INSTALLROOT)$(autofslibdir)/lookup_files.so ln -fs lookup_yp.so $(INSTALLROOT)$(autofslibdir)/lookup_nis.so +ifeq ($(SASL), 1) ln -fs lookup_ldap.so $(INSTALLROOT)$(autofslibdir)/lookup_ldaps.so +endif ln -fs mount_nfs.so $(INSTALLROOT)$(autofslibdir)/mount_nfs4.so ifeq ($(EXT2FS), 1) ifeq ($(EXT3FS), 1)--
To unsubscribe from this list: send the line "unsubscribe autofs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Ian Kent
maintainerRe: [PATCH 2/6] fix dead LDAP symbol link with LDAP support disabled
In reply to Dennis Lan (dlan)Quoted 12 lines · Dennis Lan (dlan)
Quoted 11 lines · Ian Kent
Quoted 9 lines · Ian Kent
Quoted 5 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
autofs will create symbol link mandatory no matter ldap support is enabled or not. so, without this patch, lookup_ldaps.so will become a dead link.
I have added this to my patch queue.
It will be committed next time I push patches to the repo.
Quoted 8 lines
Quoted 2 lines
On second thoughts, what if
WITH_LDAPis defined andWITH_SASLis not?HI Ian:
current logic is: if SASL is not enabled, then the symbol
lookup_ldaps.so (which link to lookup_ldap.so) will not be created.
what are you suggesting here? should symbol of lookup_ldaps.so be
controlled by LDAP ?
Yes, I think so.
If lookup_ldap.so has been included in the build then ldaps:// uris should be able to be used regardless of SASL, as long as the ldap client library is configured for it, of course.
This is what I believe it should be:
autofs-5.0.7 - fix dead LDAP symbolic link when LDAP support is disabled
From: Lan Yixun (dlan) <[email protected]>
autofs will create symbol link mandatory no matter ldap support is enabled or not. so, without this patch, lookup_ldaps.so will become a dead link.
Edited by: Ian Kent <[email protected]>
- change check from SASL to LDAP since the ldaps lookup module may still be used ldaps:// as long as LDAP support is built.
--- CHANGELOG | 1 + modules/Makefile | 2 ++ 2 files changed, 3 insertions(+)
CHANGELOG +1 -0
@@ -59,6 +59,7 @@ - dont start readmap unless ready. - fix typo forced-shutdown should be force-shutdown. - fix hesiod check error and use correct $(LIBS) setting. +- fix dead LDAP symbolic link when LDAP support is disabled. 25/07/2012 autofs-5.0.7 =======================
modules/Makefile +2 -0
@@ -74,7 +74,9 @@ install: all -rm -f $(INSTALLROOT)$(autofslibdir)/mount_smbfs.so ln -fs lookup_file.so $(INSTALLROOT)$(autofslibdir)/lookup_files.so ln -fs lookup_yp.so $(INSTALLROOT)$(autofslibdir)/lookup_nis.so +ifeq ($(LDAP), 1) ln -fs lookup_ldap.so $(INSTALLROOT)$(autofslibdir)/lookup_ldaps.so +endif ln -fs mount_nfs.so $(INSTALLROOT)$(autofslibdir)/mount_nfs4.so ifeq ($(EXT2FS), 1) ifeq ($(EXT3FS), 1)
Re: [PATCH 2/6] fix dead LDAP symbol link with LDAP support disabled
Quoted 65 lines · Ian Kent
Quoted 12 lines · Dennis Lan (dlan)
Quoted 11 lines · Ian Kent
Quoted 9 lines · Ian Kent
Quoted 5 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
autofs will create symbol link mandatory no matter ldap support is enabled or not. so, without this patch, lookup_ldaps.so will become a dead link.
I have added this to my patch queue.
It will be committed next time I push patches to the repo.Quoted 8 lines
Quoted 2 lines
On second thoughts, what if
WITH_LDAPis defined andWITH_SASLis not?HI Ian:
current logic is: if SASL is not enabled, then the symbol
lookup_ldaps.so (which link to lookup_ldap.so) will not be created.
what are you suggesting here? should symbol of lookup_ldaps.so be
controlled by LDAP ?Yes, I think so.
If lookup_ldap.so has been included in the build then ldaps:// uris should be able to be used regardless of SASL, as long as the ldap client library is configured for it, of course.
This is what I believe it should be:
autofs-5.0.7 - fix dead LDAP symbolic link when LDAP support is disabled
From: Lan Yixun (dlan) <[email protected]>
autofs will create symbol link mandatory no matter ldap support is enabled or not. so, without this patch, lookup_ldaps.so will become a dead link.
Edited by: Ian Kent <[email protected]>
- change check from SASL to LDAP since the ldaps lookup module may still be used ldaps:// as long as LDAP support is built.--- CHANGELOG | 1 + modules/Makefile | 2 ++ 2 files changed, 3 insertions(+)CHANGELOG +1
-0@@ -59,6 +59,7 @@ - dont start readmap unless ready. - fix typo forced-shutdown should be force-shutdown. - fix hesiod check error and use correct $(LIBS) setting. +- fix dead LDAP symbolic link when LDAP support is disabled. 25/07/2012 autofs-5.0.7 =======================modules/Makefile +0
-0
modules/Makefile install: all · line 82
Quoted 9 lines
modules/Makefile +2
-0@@ -74,7 +74,9 @@ install: all -rm -f $(INSTALLROOT)$(autofslibdir)/mount_smbfs.so ln -fs lookup_file.so $(INSTALLROOT)$(autofslibdir)/lookup_files.so ln -fs lookup_yp.so $(INSTALLROOT)$(autofslibdir)/lookup_nis.so +ifeq ($(LDAP), 1) ln -fs lookup_ldap.so $(INSTALLROOT)$(autofslibdir)/lookup_ldaps.so +endif ln -fs mount_nfs.so $(INSTALLROOT)$(autofslibdir)/mount_nfs4.so ifeq ($(EXT2FS), 1) ifeq ($(EXT3FS), 1)
Hi Ian:
I'm fine with this, thanks!!
Dennis Lan (dlan)
PATCH 3/6 fix compile error with LDAP enabled but SASL disabled
In reply to Lan Yixun (dlan)From: "Lan Yixun (dlan)" <[email protected]>
automount[10812]: open_lookup:90: cannot open lookup module ldap (/usr/lib64/autofs/lookup_ldap.so: undefined symbol: parse_ldap_config)
---
Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=381315
--- modules/lookup_ldap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
modules/lookup_ldap.c +1 -1
@@ -1484,6 +1484,7 @@ int lookup_init(const char *mapfmt, int argc, const char *const *argv, void **co } } +#ifdef WITH_SASL /* * First, check to see if a preferred authentication method was * specified by the user. parse_ldap_config will return error
@@ -1496,7 +1497,6 @@ int lookup_init(const char *mapfmt, int argc, const char *const *argv, void **coreturn 1 ; } -#ifdef WITH_SASL /* Init the sasl callbacks */ if (!autofs_sasl_client_init (LOGOPT_NONE )) {error (LOGOPT_ANY ,"failed to init sasl client" );
Signature · 1 line
1.8.2.1
PATCH 4/6 fix no "libxml/tree.h" error in modules lookup_ldap.c
In reply to Lan Yixun (dlan)From: "Lan Yixun (dlan)" <[email protected]>
make "libxml/tree.h" controlled by WITH_SASL, also move it beind line of #include "automount.h", since WITH_SASL is defined in config.h which is included by automout.h
---
Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=468606
gcc -shared -O2 -pipe -march=core2 -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_REENTRANT -D_FILE_OFFSET_BITS=
64 -I../include -I../lib -fPIC -D_GNU_SOURCE -DAUTOFS_LIB_DIR=\"/usr/lib64/autofs\" -DAUTOFS_MAP_DIR=\"/e
tc/autofs\" -DLDAP_DEPRECATED=1 -o lookup_ldap.so \
lookup_ldap.c dclist.o base64.o \
../lib/autofs.a -lldap -llber -lresolv
: lookup_yp.so
lookup_ldap.c:31:25: fatal error: libxml/tree.h: No such file or directory
#include <libxml/tree.h>
^compilation terminated.
--- modules/lookup_ldap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
modules/lookup_ldap.c +4 -1
@@ -28,7 +28,6 @@#include <arpa/nameser.h> #include <resolv.h> #include <lber.h> -#include <libxml/tree.h> #define MODULE_LOOKUP #include "automount.h"
@@ -36,6 +35,10 @@#include "lookup_ldap.h" #include "base64.h" +#ifdef WITH_SASL +#include <libxml/tree.h> +#endif +#define MAPFMT_DEFAULT "sun"#define MODPREFIX "lookup(ldap): "
Signature · 1 line
1.8.2.1
Ian Kent
maintainerRe: [PATCH 4/6] fix no "libxml/tree.h" error in modules lookup_ldap.c
Quoted 5 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
make "
libxml/tree.h" controlled byWITH_SASL, also move it beind line of #include "automount.h", sinceWITH_SASLis defined inconfig.hwhich is included byautomout.h
Same again, WITH_LDAP defined and WITH_SASL not.
I agree there appears to be a problem but not sure what to do about it.
Quoted 46 lines
---
Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=468606gcc -shared -O2 -pipe -march=core2 -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_REENTRANT -D_FILE_OFFSET_BITS=
64 -I../include -I../lib -fPIC -D_GNU_SOURCE -DAUTOFS_LIB_DIR=\"/usr/lib64/autofs\" -DAUTOFS_MAP_DIR=\"/e
tc/autofs\" -DLDAP_DEPRECATED=1 -o lookup_ldap.so \
lookup_ldap.cdclist.o base64.o \
../lib/autofs.a -lldap -llber -lresolv
: lookup_yp.so
lookup_ldap.c:31:25: fatal error:libxml/tree.h: No such file or directory#include <libxml/tree.h> ^compilation terminated.
Signed-off-by Lan Yixun (dlan) <[email protected]>--- modules/lookup_ldap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)modules/lookup_ldap.c +4
-1@@ -28,7 +28,6 @@#include <arpa/nameser.h> #include <resolv.h> #include <lber.h> -#include <libxml/tree.h> #define MODULE_LOOKUP #include "automount.h" @@ -36,6 +35,10 @@#include "lookup_ldap.h" #include "base64.h" +#ifdef WITH_SASL +#include <libxml/tree.h> +#endif +#define MAPFMT_DEFAULT "sun"#define MODPREFIX "lookup(ldap): "
Re: [PATCH 4/6] fix no "libxml/tree.h" error in modules lookup_ldap.c
Quoted 49 lines · Ian Kent
Quoted 5 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
make "
libxml/tree.h" controlled byWITH_SASL, also move it beind line of #include "automount.h", sinceWITH_SASLis defined inconfig.hwhich is included byautomout.hSame again,
WITH_LDAPdefined andWITH_SASLnot.
I agree there appears to be a problem but not sure what to do about it.Quoted 39 lines
---
Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=468606gcc -shared -O2 -pipe -march=core2 -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_REENTRANT -D_FILE_OFFSET_BITS=
64 -I../include -I../lib -fPIC -D_GNU_SOURCE -DAUTOFS_LIB_DIR=\"/usr/lib64/autofs\" -DAUTOFS_MAP_DIR=\"/e
tc/autofs\" -DLDAP_DEPRECATED=1 -o lookup_ldap.so \
lookup_ldap.cdclist.o base64.o \
../lib/autofs.a -lldap -llber -lresolv
: lookup_yp.so
lookup_ldap.c:31:25: fatal error:libxml/tree.h: No such file or directory#include <libxml/tree.h> ^compilation terminated.
Signed-off-by Lan Yixun (dlan) <[email protected]>--- modules/lookup_ldap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)modules/lookup_ldap.c +0
-1@@ -28,7 +28,6 @@#include <arpa/nameser.h> #include <resolv.h> #include <lber.h> -#include <libxml/tree.h> #define MODULE_LOOKUP #include "automount.h" @@ -36,6 +35,10 @@#include "lookup_ldap.h" #include "base64.h"
Quoted 9 lines
modules/lookup_ldap.c line 44
Quoted 7 lines
modules/lookup_ldap.c +4
-0+#ifdef WITH_SASL +#include <libxml/tree.h> +#endif +#define MAPFMT_DEFAULT "sun"#define MODPREFIX "lookup(ldap): "
HI Ian:
I haven't dig too much into the code.
As far as I know (could be wrong).. LDAP SASL auth needs libxml?
quote from configure.in (line 170)
# LDAP SASL auth needs libxml and Kerberos
AF_CHECK_LIBXML()
AF_CHECK_KRB5()
so libxml could be controlled by SASL, but not LDAP, right? (Btw, SASL require LDAP enabled)
Dennis
Ian Kent
maintainerRe: [PATCH 4/6] fix no "libxml/tree.h" error in modules lookup_ldap.c
Quoted 63 lines · Dennis Lan (dlan)
Quoted 49 lines · Ian Kent
Quoted 5 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
make "
libxml/tree.h" controlled byWITH_SASL, also move it beind line of #include "automount.h", sinceWITH_SASLis defined inconfig.hwhich is included byautomout.hSame again,
WITH_LDAPdefined andWITH_SASLnot.
I agree there appears to be a problem but not sure what to do about it.Quoted 39 lines
---
Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=468606gcc -shared -O2 -pipe -march=core2 -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_REENTRANT -D_FILE_OFFSET_BITS=
64 -I../include -I../lib -fPIC -D_GNU_SOURCE -DAUTOFS_LIB_DIR=\"/usr/lib64/autofs\" -DAUTOFS_MAP_DIR=\"/e
tc/autofs\" -DLDAP_DEPRECATED=1 -o lookup_ldap.so \
lookup_ldap.cdclist.o base64.o \
../lib/autofs.a -lldap -llber -lresolv
: lookup_yp.so
lookup_ldap.c:31:25: fatal error:libxml/tree.h: No such file or directory#include <libxml/tree.h> ^compilation terminated.
Signed-off-by Lan Yixun (dlan) <[email protected]>--- modules/lookup_ldap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)modules/lookup_ldap.c +0
-1@@ -28,7 +28,6 @@#include <arpa/nameser.h> #include <resolv.h> #include <lber.h> -#include <libxml/tree.h> #define MODULE_LOOKUP #include "automount.h" @@ -36,6 +35,10 @@#include "lookup_ldap.h" #include "base64.h" Quoted 9 lines
modules/lookup_ldap.c line 44
Quoted 7 lines
modules/lookup_ldap.c +4
-0+#ifdef WITH_SASL +#include <libxml/tree.h> +#endif +#define MAPFMT_DEFAULT "sun"#define MODPREFIX "lookup(ldap): "HI Ian:
I haven't dig too much into the code.
As far as I know (could be wrong).. LDAP SASL auth needs libxml?
Quoted 8 lines
quote from configure.in (line 170)
# LDAP SASL auth needs libxml and Kerberos
AF_CHECK_LIBXML()
AF_CHECK_KRB5()so libxml could be controlled by SASL, but not LDAP, right? (Btw, SASL require LDAP enabled)
That's what occurred to me but, after a quick look, I'm thinking the xml config still needs to be read. That's why I agree there's a problem that needs fixing.
I'll have to look at it along with that old Gentoo ldap patch I want to commit.
Quoted 6 lines
Dennis
--
To unsubscribe from this list: send the line "unsubscribe autofs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/6] fix no "libxml/tree.h" error in modules lookup_ldap.c
Quoted 73 lines · Ian Kent
Quoted 63 lines · Dennis Lan (dlan)
Quoted 49 lines · Ian Kent
Quoted 5 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
make "
libxml/tree.h" controlled byWITH_SASL, also move it beind line of #include "automount.h", sinceWITH_SASLis defined inconfig.hwhich is included byautomout.hSame again,
WITH_LDAPdefined andWITH_SASLnot.
I agree there appears to be a problem but not sure what to do about it.Quoted 39 lines
---
Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=468606gcc -shared -O2 -pipe -march=core2 -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_REENTRANT -D_FILE_OFFSET_BITS=
64 -I../include -I../lib -fPIC -D_GNU_SOURCE -DAUTOFS_LIB_DIR=\"/usr/lib64/autofs\" -DAUTOFS_MAP_DIR=\"/e
tc/autofs\" -DLDAP_DEPRECATED=1 -o lookup_ldap.so \
lookup_ldap.cdclist.o base64.o \
../lib/autofs.a -lldap -llber -lresolv
: lookup_yp.so
lookup_ldap.c:31:25: fatal error:libxml/tree.h: No such file or directory#include <libxml/tree.h> ^compilation terminated.
Signed-off-by Lan Yixun (dlan) <[email protected]>--- modules/lookup_ldap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)modules/lookup_ldap.c +0
-1@@ -28,7 +28,6 @@#include <arpa/nameser.h> #include <resolv.h> #include <lber.h> -#include <libxml/tree.h> #define MODULE_LOOKUP #include "automount.h" @@ -36,6 +35,10 @@#include "lookup_ldap.h" #include "base64.h" Quoted 9 lines
modules/lookup_ldap.c line 44
Quoted 7 lines
modules/lookup_ldap.c +4
-0+#ifdef WITH_SASL +#include <libxml/tree.h> +#endif +#define MAPFMT_DEFAULT "sun"#define MODPREFIX "lookup(ldap): "HI Ian:
I haven't dig too much into the code.
As far as I know (could be wrong).. LDAP SASL auth needs libxml?Quoted 8 lines
quote from configure.in (line 170)
# LDAP SASL auth needs libxml and Kerberos
AF_CHECK_LIBXML()
AF_CHECK_KRB5()so libxml could be controlled by SASL, but not LDAP, right? (Btw, SASL require LDAP enabled)
Quoted 8 lines
That's what occurred to me but, after a quick look, I'm thinking the xml config still needs to be read. That's why I agree there's a problem that needs fixing.
I'll have to look at it along with that old Gentoo ldap patch I want to commit.
Quoted 1 line
Hi Ian:
Good, if you have any progress, let me know ;_) Thanks
Quoted 7 lines
Quoted 5 lines
Dennis
--
To unsubscribe from this list: send the line "unsubscribe autofs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 5/6 add missing WITH_SASL in modules lookup_ldap.c
In reply to Lan Yixun (dlan)From: "Lan Yixun (dlan)" <[email protected]>
---
Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=361899
x86_64-pc-linux-gnu-gcc -Wl,-O1 -Wl,--as-needed -Wl,-O1 -Wl,--hash-style=gnu -Wl,--sort-common -shared -O2 -pipe -march=core2 -mcx16 -msahf -mpopcnt -msse4.2 --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=8192 -frecord-gcc-switches -g -Wimplicit-function-declaration -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_REENTRANT -D_FILE_OFFSET_BITS=64 -I../include -I../lib -fPIC -D_GNU_SOURCE -DAUTOFS_LIB_DIR=\"/usr/lib64/autofs\" -DAUTOFS_MAP_DIR=\"/etc/autofs\" -DLDAP_DEPRECATED=1 -o
lookup_ldap.so \ lookup_ldap.c dclist.o \ ../lib/autofs.a -lldap -llber -lresolv
lookup_ldap.c: In function ‘do_connect’:
lookup_ldap.c:598:10: error: ‘struct lookup_context’ has no member named ‘extern_cert’ lookup_ldap.c:598:31: error: ‘struct lookup_context’ has no member named ‘extern_key’ lookup_ldap.c:599:41: error: ‘struct lookup_context’ has no member named ‘extern_cert’ lookup_ldap.c:600:40: error: ‘struct lookup_context’ has no member named ‘extern_key’ lookup_ldap.c: In function ‘free_context’:
lookup_ldap.c:1379:10: error: ‘struct lookup_context’ has no member named ‘extern_cert’ lookup_ldap.c:1380:12: error: ‘struct lookup_context’ has no member named ‘extern_cert’ lookup_ldap.c:1381:10: error: ‘struct lookup_context’ has no member named ‘extern_key’ lookup_ldap.c:1382:12: error: ‘struct lookup_context’ has no member named ‘extern_key’ make[1]: *** [lookup_ldap.so] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/portage/net-fs/autofs-5.0.5-r2/work/autofs-5.0.5/modules'
make: *** [daemon] Error 2
--- modules/lookup_ldap.c | 4 ++++ 1 file changed, 4 insertions(+)
modules/lookup_ldap.c +4 -0
@@ -588,10 +588,12 @@ static LDAP *do_connect(unsigned logopt, const char *uri, struct lookup_context {LDAP *ldap; +#ifdef WITH_SASL if (ctxt->extern_cert && ctxt->extern_key) {set_env (logopt,ENV_LDAPTLS_CERT , ctxt->extern_cert);set_env (logopt,ENV_LDAPTLS_KEY , ctxt->extern_key); } +#endif ldap =init_ldap_connection (logopt, uri, ctxt);if (ldap) {
@@ -1393,10 +1395,12 @@ static void free_context(struct lookup_context *ctxt)defaults_free_searchdns (ctxt->sdns);if (ctxt->dclist)free_dclist (ctxt->dclist); +#ifdef WITH_SASL if (ctxt->extern_cert)free (ctxt->extern_cert);if (ctxt->extern_key)free (ctxt->extern_key); +#endif free (ctxt);return ;
Signature · 1 line
1.8.2.1
Ian Kent
maintainerRe: [PATCH 5/6] add missing WITH_SASL in modules lookup_ldap.c
Quoted 5 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
---
Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=361899
Not sure about this one either.
I have a patch in the queue that's been sitting for some time that does this and some more. I'd like to include it in 5.0.8 but I'm not sure it actually works properly. I need to go over it somewhat before I commit it.
Here it is fyi:
autofs-5.0.7 - fix compilation of lookup_ldap.c without sasl
From: Dustin Polke <[email protected]>
See https://bugs.gentoo.org/show_bug.cgi?id=361899 for more info.
Edited by: Ian Kent <[email protected]>
- fix parse_ldap_config() is needed by ldap but previously excluded.
- exclude other references to ctxt->extern_cert and ctxt->extern_key.
- prevent memory leak if present in config but not used.
- remove now unused set_env().
--- CHANGELOG | 1 + include/lookup_ldap.h | 4 ++-- lib/Makefile | 4 ++++ modules/Makefile | 6 ++++-- modules/lookup_ldap.c | 14 ++++++++++++-- 5 files changed, 23 insertions(+), 6 deletions(-)
CHANGELOG +1 -0
@@ -57,6 +57,7 @@ - fix a couple of compiler warnings. - add after sssd dependency to unit file. - dont start readmap unless ready. +- fix compilation of lookup_ldap.c without sasl. 25/07/2012 autofs-5.0.7 =======================
include/lookup_ldap.h +2 -2
@@ -11,6 +11,8 @@#include <krb5.h> #endif +#include <libxml/tree.h> +#include "list.h" #include "dclist.h"
@@ -92,7 +94,6 @@ struct lookup_context { }; -#ifdef WITH_SASL #define LDAP_AUTH_CONF_FILE "test"#define LDAP_TLS_DONT_USE 0
@@ -104,7 +105,6 @@ struct lookup_context {#define LDAP_AUTH_REQUIRED 0x0002#define LDAP_AUTH_AUTODETECT 0x0004#define LDAP_NEED_AUTH (LDAP_AUTH_REQUIRED|LDAP_AUTH_AUTODETECT) -#endif #define LDAP_AUTH_USESIMPLE 0x0008
lib/Makefile +4 -0
@@ -24,6 +24,10 @@ CFLAGS += -I../include -fPIC -D_GNU_SOURCE CFLAGS += -DAUTOFS_MAP_DIR=\"$(autofsmapdir)\" CFLAGS += -DAUTOFS_CONF_DIR=\"$(autofsconfdir)\" +ifeq ($(LDAP), 1) + CFLAGS += $(XML_FLAGS) $(XML_LIBS) +endif + .PHONY: all install clean all: autofs.a
modules/Makefile +4 -3
@@ -45,10 +45,12 @@ endif ifeq ($(LDAP), 1) SRCS += lookup_ldap.c MODS += lookup_ldap.so + LDAP_FLAGS += $(XML_FLAGS) -DLDAP_THREAD_SAFE + LIBLDAP += $(XML_LIBS) ifeq ($(SASL), 1) SASL_OBJ = cyrus-sasl.o cyrus-sasl-extern.o - LDAP_FLAGS += $(SASL_FLAGS) $(XML_FLAGS) $(KRB5_FLAGS) -DLDAP_THREAD_SAFE - LIBLDAP += $(LIBSASL) $(XML_LIBS) $(KRB5_LIBS) + LDAP_FLAGS += $(SASL_FLAGS) $(KRB5_FLAGS) + LIBLDAP += $(LIBSASL) $(KRB5_LIBS) endif endif
modules/lookup_ldap.c +1 -0
@@ -66,6 +66,7 @@ struct ldap_search_params {static int decode_percent_hack (const char *,char **); +#ifdef HAVE_SASL static int set_env (unsigned logopt,const char *name,const char *val) {int ret =setenv (name, val,1 );
@@ -75,6 +76,7 @@ static int set_env(unsigned logopt, const char *name,
const char *val)
}
return 1;
}
+#endif
#ifndef HAVE_LDAP_CREATE_PAGE_CONTROL
int ldap_create_page_control(LDAP *ldap, ber_int_t pagesize,
@@ -585,10 +587,12 @@ static LDAP *do_connect(unsigned logopt, const char *uri, struct lookup_context
{
LDAP *ldap;
+#ifdef HAVE_SASL
if (ctxt->extern_cert && ctxt->extern_key) {
set_env(logopt, ENV_LDAPTLS_CERT, ctxt->extern_cert); set_env(logopt, ENV_LDAPTLS_KEY, ctxt->extern_key);
}
+#endif
ldap = init_ldap_connection(logopt, uri, ctxt); if (ldap) {
@@ -791,7 +795,6 @@ find_server:
return ldap;
}
-#ifdef WITH_SASL
int get_property(unsigned logopt, xmlNodePtr node, const char *prop,
char **value)
{
xmlChar *ret;
@@ -812,6 +815,7 @@ int get_property(unsigned logopt, xmlNodePtr node, const char *prop, char **valu
return 0;
}
+#ifdef WITH_SASL
/*
* For plain text, login and digest-md5 authentication types, we need
* user and password credentials.
@@ -824,6 +828,7 @@ int authtype_requires_creds(const char *authtype)
return 1;
return 0;
}
+#endif
/*
* Returns:
@@ -1056,6 +1061,7 @@ auth_fail:
}
} else if (auth_required == LDAP_AUTH_REQUIRED &&
(authtype && !strncmp(authtype, "EXTERNAL", 8))) {
+#ifdef WITH_SASL
ret = get_property(logopt, root, "external_cert", &extern_cert); ret |= get_property(logopt, root, "external_key", &extern_key); /*
@@ -1074,6 +1080,7 @@ auth_fail:
if (extern_key)
free(extern_key);
}
+#endif
}
/*
@@ -1094,8 +1101,10 @@ auth_fail:
ctxt->secret = secret;
ctxt->client_princ = client_princ;
ctxt->client_cc = client_cc;
+#ifdef WITH_SASL
ctxt->extern_cert = extern_cert;
ctxt->extern_key = extern_key;
+#endif
debug(logopt, MODPREFIX
"ldap authentication configured with the following options:");
@@ -1127,7 +1136,6 @@ out:
return ret;
}
-#endif
/*
* Take an input string as specified in the master map, and break it
@@ -1390,10 +1398,12 @@ static void free_context(struct lookup_context *ctxt)
defaults_free_searchdns(ctxt->sdns);
if (ctxt->dclist)
free_dclist(ctxt->dclist);
+#ifdef HAVE_SASL
if (ctxt->extern_cert)
free(ctxt->extern_cert);
if (ctxt->extern_key)
free(ctxt->extern_key);
+#endif
free(ctxt);
return;
Re: [PATCH 5/6] add missing WITH_SASL in modules lookup_ldap.c
Quoted 219 lines · Ian Kent
Quoted 5 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
---
Gentoo Bugs:
https://bugs.gentoo.org/show_bug.cgi?id=361899Not sure about this one either.
I have a patch in the queue that's been sitting for some time that does this and some more. I'd like to include it in 5.0.8 but I'm not sure it actually works properly. I need to go over it somewhat before I commit it.Here it is fyi:
autofs-5.0.7 - fix compilation of
lookup_ldap.cwithout saslFrom: Dustin Polke <[email protected]>
See https://bugs.gentoo.org/show_bug.cgi?id=361899 for more info.
Edited by: Ian Kent <[email protected]>
- fixparse_ldap_config()is needed by ldap but previously excluded.
- exclude other references toctxt->extern_certandctxt->extern_key.
- prevent memory leak if present in config but not used.
- remove now unusedset_env().--- CHANGELOG | 1 + include/lookup_ldap.h | 4 ++-- lib/Makefile | 4 ++++ modules/Makefile | 6 ++++-- modules/lookup_ldap.c | 14 ++++++++++++-- 5 files changed, 23 insertions(+), 6 deletions(-)CHANGELOG +1
-0@@ -57,6 +57,7 @@ - fix a couple of compiler warnings. - add after sssd dependency to unit file. - dont start readmap unless ready. +- fix compilation of lookup_ldap.c without sasl. 25/07/2012 autofs-5.0.7 =======================include/lookup_ldap.h +2
-2@@ -11,6 +11,8 @@#include <krb5.h> #endif +#include <libxml/tree.h> +#include "list.h" #include "dclist.h" @@ -92,7 +94,6 @@ struct lookup_context { }; -#ifdef WITH_SASL #define LDAP_AUTH_CONF_FILE "test"#define LDAP_TLS_DONT_USE 0@@ -104,7 +105,6 @@ struct lookup_context {#define LDAP_AUTH_REQUIRED 0x0002#define LDAP_AUTH_AUTODETECT 0x0004#define LDAP_NEED_AUTH (LDAP_AUTH_REQUIRED|LDAP_AUTH_AUTODETECT) -#endif #define LDAP_AUTH_USESIMPLE 0x0008lib/Makefile +4
-0@@ -24,6 +24,10 @@ CFLAGS += -I../include -fPIC -D_GNU_SOURCE CFLAGS += -DAUTOFS_MAP_DIR=\"$(autofsmapdir)\" CFLAGS += -DAUTOFS_CONF_DIR=\"$(autofsconfdir)\" +ifeq ($(LDAP), 1) + CFLAGS += $(XML_FLAGS) $(XML_LIBS) +endif + .PHONY: all install clean all: autofs.amodules/Makefile +4
-3@@ -45,10 +45,12 @@ endif ifeq ($(LDAP), 1) SRCS += lookup_ldap.c MODS += lookup_ldap.so + LDAP_FLAGS += $(XML_FLAGS) -DLDAP_THREAD_SAFE + LIBLDAP += $(XML_LIBS) ifeq ($(SASL), 1) SASL_OBJ = cyrus-sasl.o cyrus-sasl-extern.o - LDAP_FLAGS += $(SASL_FLAGS) $(XML_FLAGS) $(KRB5_FLAGS) -DLDAP_THREAD_SAFE - LIBLDAP += $(LIBSASL) $(XML_LIBS) $(KRB5_LIBS) + LDAP_FLAGS += $(SASL_FLAGS) $(KRB5_FLAGS) + LIBLDAP += $(LIBSASL) $(KRB5_LIBS) endif endifmodules/lookup_ldap.c +2
-0@@ -66,6 +66,7 @@ struct ldap_search_params {static int decode_percent_hack (const char *,char **); +#ifdef HAVE_SASL static int set_env (unsigned logopt,const char *name,const char *val) {int ret =setenv (name, val,1 );@@ -75,6 +76,7 @@ static int set_env(unsigned logopt, const char *name, const char *val) } return 1; } +#endif #ifndef HAVE_LDAP_CREATE_PAGE_CONTROL int ldap_create_page_control(LDAP *ldap,
ber_int_tpagesize,modules/lookup_ldap.c +0
-0@@ -585,10 +587,12 @@ static LDAP *do_connect(unsigned logopt, constchar *uri, struct
lookup_context{ LDAP *ldap;modules/lookup_ldap.c +2
-1+#ifdef HAVE_SASL if (ctxt->extern_cert && ctxt->extern_key) {set_env (logopt,ENV_LDAPTLS_CERT , ctxt->extern_cert);set_env (logopt,ENV_LDAPTLS_KEY , ctxt->extern_key); } +#endif ldap =init_ldap_connection (logopt, uri, ctxt);if (ldap) {@@ -791,7 +795,6 @@ find_server:return ldap; } -#ifdef WITH_SASL int get_property (unsigned logopt,xmlNodePtr node,const char *prop,char **value) {xmlChar *ret;modules/lookup_ldap.c +0
-0@@ -812,6 +815,7 @@ int get_property(unsigned logopt, xmlNodePtr node,const char *prop, char **valu
return 0;}
modules/lookup_ldap.c +8
-1+#ifdef WITH_SASL /* * For plain text, login and digest-md5 authentication types, we need * user and password credentials. @@ -824,6 +828,7 @@ int authtype_requires_creds(const char *authtype)return 1 ; return 0; } +#endif /* * Returns: @@ -1056,6 +1061,7 @@ auth_fail: } }else if (auth_required ==LDAP_AUTH_REQUIRED && (authtype && !strncmp (authtype,"EXTERNAL" ,8 ))) { +#ifdef WITH_SASL ret =get_property (logopt, root,"external_cert" , &extern_cert); ret |=get_property (logopt, root,"external_key" , &extern_key);/* @@ -1074,6 +1080,7 @@ auth_fail:if (extern_key) free(extern_key); } +#endif }/* @@ -1094,8 +1101,10 @@ auth_fail: ctxt->secret = secret; ctxt->client_princ = client_princ; ctxt->client_cc = client_cc; +#ifdef WITH_SASL ctxt->extern_cert = extern_cert; ctxt->extern_key = extern_key; +#endif debug (logopt,MODPREFIX "ldap authentication configured with the following options:" );@@ -1127,7 +1136,6 @@ out:return ret; } -#endif /* * Take an input string as specified in the master map, and break it @@ -1390,10 +1398,12 @@ static void free_context(struct lookup_context *ctxt)defaults_free_searchdns (ctxt->sdns);if (ctxt->dclist)free_dclist (ctxt->dclist); +#ifdef HAVE_SASL if (ctxt->extern_cert)free (ctxt->extern_cert);if (ctxt->extern_key)free (ctxt->extern_key); +#endif free (ctxt);
Quoted 3 lines
return;
Hi Ian
Dustin is the previous autofs maintainer for gentoo linux, I also CC
him, But not sure whether he will response (he may not active).
Haven't looked into your patch in detail. Basically what I've done
here is refactoring his patches. Breaking into small pieces for better review..
Dennis
PATCH 6/6 fix typo, forced-shutdown should be force-shutdown
In reply to Lan Yixun (dlan)From: "Lan Yixun (dlan)" <[email protected]>
it will confuse user when they found what shows with "./configure --help" differ from what it should be.
--- configure.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
configure.in +1 -1
@@ -363,7 +363,7 @@ fi # # Enable forced shutdown on USR1 signal (unlink umounts all mounts). # -AC_ARG_ENABLE(forced-shutdown, +AC_ARG_ENABLE(force-shutdown, [ --enable-force-shutdown enable USR1 signal to force unlink umount of any busy mounts during shutdown],, enableval=no)
Signature · 1 line
1.8.2.1
Ian Kent
maintainerRe: [PATCH 6/6] fix typo, forced-shutdown should be force-shutdown
Quoted 4 lines · Lan Yixun (dlan)
From: "Lan Yixun (dlan)" <[email protected]>
it will confuse user when they found what shows with "./configure --help" differ from what it should be.
This one looks sensible, ;)
Quoted 19 lines
Signed-off-by Lan Yixun (dlan) <[email protected]>--- configure.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configure.in +1
-1@@ -363,7 +363,7 @@ fi # # Enable forced shutdown on USR1 signal (unlink umounts all mounts). # -AC_ARG_ENABLE(forced-shutdown, +AC_ARG_ENABLE(force-shutdown, [ --enable-force-shutdown enable USR1 signal to force unlink umount of any busy mounts during shutdown],, enableval=no)