S2255: Removal of unnecessary videobuf_queue_is_busy

PATCH New Dean Anderson 1 participant 1 message Jul 23, 2013 Media (V4L/DVB)

lore

Share & tools

lore

Dean Anderson

author

2013-07-23 22:32 UTC #0 lore raw

PATCH 1/1 S2255: Removal of unnecessary videobuf_queue_is_busy

Removes unnecessary query of buffer state. The code already checks if stream is active or not.

Signed-off-by Dean Anderson <[email protected]>

---
 drivers/media/usb/s2255/s2255drv.c |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

drivers/media/usb/s2255/s2255drv.c +2 -7

index ab97e7d..6bc9b8e 100644
@@ -1,7 +1,7 @@
 /*
  *  s2255drv.c - a driver for the Sensoray 2255 USB video capture device
  *
- *   Copyright (C) 2007-2010 by Sensoray Company Inc.
+ *   Copyright (C) 2007-2013 by Sensoray Company Inc.
  *                              Dean Anderson
  *
  * Some video buffer code based on vivi driver:

@@ -52,7 +52,7 @@
 #include <media/v4l2-ctrls.h>
 #include <media/v4l2-event.h>
 
-#define S2255_VERSION		"1.22.1"
+#define S2255_VERSION		"1.23.1"
 #define FIRMWARE_FILE_NAME "f2255usb.bin"
 
 /* default JPEG quality */

@@ -1303,11 +1303,6 @@ static int vidioc_s_std(struct file *file, void *priv, v4l2_std_id i)
 	int ret = 0;
 
 	mutex_lock(&q->vb_lock);
-	if (videobuf_queue_is_busy(q)) {
-		dprintk(1, "queue busy\n");
-		ret = -EBUSY;
-		goto out_s_std;
-	}
 	if (res_locked(fh)) {
 		dprintk(1, "can't change standard after started\n");
 		ret = -EBUSY;

Signature · 1 line

1.7.9.5