regulator: palmas: Store pdata pointer in palmas struct
PATCH v2 1/1 regulator: palmas: Store pdata pointer in palmas struct
Store a pointer to the pdata so that if it needs to be used after probe it can be. In the case of booting from DeviceTree, the dev.platform_data may be null, so we need to store this pointer explicitly.
Based on work by Joseph Lo.
---
v2:
- Renamed patch from "regulator: palmas: fix pdata ptr not be updated after it has been allocated" to be appropriate to the current change.
- Instead of updating dev.platform_data, store the pdata pointer in the pmic struct which we already have access to via drvdata.
drivers/regulator/palmas-regulator.c | 2 +- include/linux/mfd/palmas.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/regulator/palmas-regulator.c +1 -1
@@ -761,7 +761,6 @@ static void palmas_dt_to_pdata(struct device *dev, pdata->ldo6_vibrator =of_property_read_bool (node,"ti,ldo6-vibrator" ); } -static int palmas_regulators_probe (struct platform_device *pdev) {struct palmas *palmas =dev_get_drvdata (pdev->dev.parent);
@@ -789,6 +788,7 @@ static int palmas_regulators_probe(struct platform_device *pdev) pmic->dev = &pdev->dev; pmic->palmas = palmas; + pmic->pdata = pdata; palmas->pmic = pmic;platform_set_drvdata (pdev, pmic);
include/linux/mfd/palmas.h +2 -0
@@ -352,6 +352,8 @@ struct palmas_pmic {struct regulator_dev *rdev[PALMAS_NUM_REGS ];struct mutex mutex; +struct palmas_pmic_platform_data *pdata; +int smps123;int smps457;
Signature · 1 line
1.7.9.5
Mark Brown
maintainerQuoted 4 lines · Rhyland Klein
Store a pointer to the pdata so that if it needs to be used after probe it can be. In the case of booting from DeviceTree, the dev.platform_data may be null, so we need to store this pointer explicitly.
This doesn't seem to adjust any places where pdata is used to refer to the new pointer so does it actually have any effect?
Quoted 10 lines · Mark Brown
* PGP Signed by an unknown key
Quoted 4 lines · Rhyland Klein
Store a pointer to the pdata so that if it needs to be used after probe it can be. In the case of booting from DeviceTree, the dev.platform_data may be null, so we need to store this pointer explicitly.
This doesn't seem to adjust any places where pdata is used to refer to the new pointer so does it actually have any effect?
I was thinking the same thing after I sent this. Right now, no this has no effect. The expectation is that when ldo8-tracking support is posted, it needs to have access to the pdata. I suppose it could make sense then to either make this part of that series, or to flatten this directly into it.
I think it can be fine to merge on its own, but it might make sense then to include the ldo8 tracking support. Let me see how ready that is to be posted, and if it is close, this can join it in a patchset.
-rhyland
Quoted 4 lines
* Unknown Key
*0x7EA229BD
Signature · 1 line
nvpublic