Skip to contentSkip to conversation

staging: lustre: Fix non-ANSI sparse warnings

PATCH Superseded Emil Goode 2 participants 4 messages Jul 27, 2013

Subsystems (2)
Staging Kernel janitors

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Emil Goode

author
#0 lore raw

PATCH 1/2 staging: lustre: Fix non-ANSI sparse warnings

This patch fixes a lot of non-ANSI sparse warnings.

Signed-off-by Emil Goode <[email protected]>
---
 .../lustre/lnet/klnds/socklnd/socklnd_lib-linux.c        |    6 +++---
 drivers/staging/lustre/lnet/lnet/api-ni.c                |    2 +-
 drivers/staging/lustre/lnet/selftest/console.c           |    2 +-
 .../staging/lustre/lustre/libcfs/linux/linux-tracefile.c |   14 +++++++-------
 drivers/staging/lustre/lustre/ptlrpc/pack_generic.c      |    2 +-
 drivers/staging/lustre/lustre/ptlrpc/pinger.c            |    4 ++--
 6 files changed, 15 insertions(+), 15 deletions(-)
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c +3 -3
index 3e08fe2..76e442b 100644
@@ -325,20 +325,20 @@ ksocknal_lib_tunables_init ()
 }
 
 void
-ksocknal_lib_tunables_fini ()
+ksocknal_lib_tunables_fini(void)
 {
 	if (ksocknal_tunables.ksnd_sysctl != NULL)
 		unregister_sysctl_table(ksocknal_tunables.ksnd_sysctl);
 }
 #else
 int
-ksocknal_lib_tunables_init ()
+ksocknal_lib_tunables_init(void)
 {
 	return 0;
 }
 
 void
-ksocknal_lib_tunables_fini ()
+ksocknal_lib_tunables_fini(void)
 {
 }
 #endif /* # if CONFIG_SYSCTL && !CFS_SYSFS_MODULE_PARM */
drivers/staging/lustre/lnet/lnet/api-ni.c +1 -1
index 250c618..160a429 100644
@@ -1371,7 +1371,7 @@ EXPORT_SYMBOL(LNetNIInit);
  * \return always 0 for current implementation.
  */
 int
-LNetNIFini()
+LNetNIFini(void)
 {
 	LNET_MUTEX_LOCK(&the_lnet.ln_api_mutex);
drivers/staging/lustre/lnet/selftest/console.c +1 -1
index 78e8d04..09e4700 100644
@@ -1773,7 +1773,7 @@ lstcon_session_info(lst_sid_t *sid_up, int *key_up, unsigned *featp,
 }
 
 int
-lstcon_session_end()
+lstcon_session_end(void)
 {
 	lstcon_rpc_trans_t *trans;
 	lstcon_group_t     *grp;
drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c +7 -7
index a500a0b..162beee 100644
@@ -51,7 +51,7 @@ char *cfs_trace_console_buffers[NR_CPUS][CFS_TCD_TYPE_MAX];
 
 struct rw_semaphore cfs_tracefile_sem;
 
-int cfs_tracefile_init_arch()
+int cfs_tracefile_init_arch(void)
 {
 	int    i;
 	int    j;

@@ -96,7 +96,7 @@ out:
 	return -ENOMEM;
 }
 
-void cfs_tracefile_fini_arch()
+void cfs_tracefile_fini_arch(void)
 {
 	int    i;
 	int    j;

@@ -116,27 +116,27 @@ void cfs_tracefile_fini_arch()
 	fini_rwsem(&cfs_tracefile_sem);
 }
 
-void cfs_tracefile_read_lock()
+void cfs_tracefile_read_lock(void)
 {
 	down_read(&cfs_tracefile_sem);
 }
 
-void cfs_tracefile_read_unlock()
+void cfs_tracefile_read_unlock(void)
 {
 	up_read(&cfs_tracefile_sem);
 }
 
-void cfs_tracefile_write_lock()
+void cfs_tracefile_write_lock(void)
 {
 	down_write(&cfs_tracefile_sem);
 }
 
-void cfs_tracefile_write_unlock()
+void cfs_tracefile_write_unlock(void)
 {
 	up_write(&cfs_tracefile_sem);
 }
 
-cfs_trace_buf_type_t cfs_trace_buf_idx_get()
+cfs_trace_buf_type_t cfs_trace_buf_idx_get(void)
 {
 	if (in_irq())
 		return CFS_TCD_TYPE_IRQ;
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c +1 -1
index ffff648..9c20d0c 100644
@@ -115,7 +115,7 @@ int lustre_msg_check_version(struct lustre_msg *msg, __u32 version)
 EXPORT_SYMBOL(lustre_msg_check_version);
 
 /* early reply size */
-int lustre_msg_early_size()
+int lustre_msg_early_size(void)
 {
 	static int size = 0;
 	if (!size) {
drivers/staging/lustre/lustre/ptlrpc/pinger.c +2 -2
index f521251..79e7d08 100644
@@ -51,7 +51,7 @@ struct mutex pinger_mutex;
 static LIST_HEAD(pinger_imports);
 static struct list_head timeout_list = LIST_HEAD_INIT(timeout_list);
 
-int ptlrpc_pinger_suppress_pings()
+int ptlrpc_pinger_suppress_pings(void)
 {
 	return suppress_pings;
 }

@@ -608,7 +608,7 @@ int ptlrpc_pinger_remove_timeouts(void)
 	return 0;
 }
 
-void ptlrpc_pinger_wake_up()
+void ptlrpc_pinger_wake_up(void)
 {
 	thread_add_flags(&pinger_thread, SVC_EVENT);
 	wake_up(&pinger_thread.t_ctl_waitq);
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 1 line

This patch fixes a lot of non-ANSI sparse warnings.

would be better if you sepcify which non-ANSI sparse warnings.

In this patch you are doing only one type of change that is to add a void parameter to functions which don't get one.

Andi

Quoted 1 line
Signed-off-by Emil Goode <[email protected]>
author
#2 lore raw
In reply to Emil Goode

Hi Andi,

I ususally put the warnings in the change log but when it's a long list I prefer leaving them out. If you would like the full list I can resend. Perhaps I should change the commit message to:
This patch fixes a lot of non-ANSI sparse warnings by adding void to parameterless functions.

Best regards,

Emil

Quoted 10 lines · Andi Shyti
Quoted 1 line

This patch fixes a lot of non-ANSI sparse warnings.

would be better if you sepcify which non-ANSI sparse warnings.

In this patch you are doing only one type of change that is to add a void parameter to functions which don't get one.

Andi

Quoted 1 line
Signed-off-by Emil Goode <[email protected]>
#3 lore raw
In reply to Emil Goode
Quoted 5 lines

I ususally put the warnings in the change log but when it's a long list I prefer leaving them out. If you would like the full list I can resend. Perhaps I should change the commit message to:
This patch fixes a lot of non-ANSI sparse warnings by adding void to parameterless functions.

that's better

Andi