Staging: olpc_dcon: more big endian conformity
PATCH 1/1 Staging: olpc_dcon: more big endian conformity
Using an int which is casted to unsigned char as inbuf is messy. The code won't work on big endian systems. The patch should fix this.
drivers/staging/olpc_dcon/olpc_dcon.c +7 -6
@@ -122,12 +122,13 @@ err:static int dcon_bus_stabilize (struct dcon_priv *dcon,int is_powered_down) {unsigned long timeout; +u8 pm;int x; power_up:if (is_powered_down) { - x =1 ; - x =olpc_ec_cmd (EC_DCON_POWER_MODE , (u8 *)&x,1 ,NULL ,0 ); + pm =1 ; + x =olpc_ec_cmd (EC_DCON_POWER_MODE , &pm,1 ,NULL ,0 );if (x) {pr_warn ("unable to force dcon to power up: %d!\n" , x);return x;
@@ -144,8 +145,8 @@ power_up:if (x <0 ) {pr_err ("unable to stabilize dcon's smbus, reasserting power and praying.\n" );BUG_ON (olpc_board_at_least (olpc_board (0xc2 ))); - x =0 ; -olpc_ec_cmd (EC_DCON_POWER_MODE , (u8 *)&x,1 ,NULL ,0 ); + pm =0 ; +olpc_ec_cmd (EC_DCON_POWER_MODE , &pm,1 ,NULL ,0 );msleep (100 ); is_powered_down =1 ; goto power_up;/* argh, stupid hardware.. */
@@ -208,8 +209,8 @@ static void dcon_sleep(struct dcon_priv *dcon, bool sleep)return ;if (sleep) { - x =0 ; - x =olpc_ec_cmd (EC_DCON_POWER_MODE , (u8 *)&x,1 ,NULL ,0 ); +u8 pm =0 ; + x =olpc_ec_cmd (EC_DCON_POWER_MODE , &pm,1 ,NULL ,0 );if (x)pr_warn ("unable to force dcon to power down: %d!\n" , x);else
Signature · 1 line
1.7.9.5
Greg KH
maintainerQuoted 5 lines · Jens Frederich
Using an int which is casted to unsigned char as inbuf is messy. The code won't work on big endian systems. The patch should fix this.
Signed-off-by Jens Frederich <[email protected]>
This patch doesn't apply at all, can you refresh it against my staging-next branch and resend it so that I can apply it?
thanks,
greg k-h
Quoted 10 lines · Greg KH
Quoted 5 lines · Jens Frederich
Using an int which is casted to unsigned char as inbuf is messy. The code won't work on big endian systems. The patch should fix this.
Signed-off-by Jens Frederich <[email protected]>This patch doesn't apply at all, can you refresh it against my staging-next branch and resend it so that I can apply it?
There has been three outstanding patches. I'll resend it again.
thanks,
jens
Quoted 10 lines · Greg KH
Quoted 5 lines · Jens Frederich
Using an int which is casted to unsigned char as inbuf is messy. The code won't work on big endian systems. The patch should fix this.
Signed-off-by Jens Frederich <[email protected]>This patch doesn't apply at all, can you refresh it against my staging-next branch and resend it so that I can apply it?
Sorry for the duplicated patch 3. The subject:
[PATCH] Staging: olpc_dcon: more big endian conformity and [PATCH 3/3] Staging: olpc_dcon: more big endian conformity is equal for the Google mail client and lands in the same thread. I'd use Mutt.
thanks,
jens
Greg KH
maintainerQuoted 12 lines · Jens Frederich
Quoted 10 lines · Greg KH
Quoted 5 lines · Jens Frederich
Using an int which is casted to unsigned char as inbuf is messy. The code won't work on big endian systems. The patch should fix this.
Signed-off-by Jens Frederich <[email protected]>This patch doesn't apply at all, can you refresh it against my staging-next branch and resend it so that I can apply it?
Quoted 5 lines
Sorry for the duplicated patch 3. The subject:
[PATCH] Staging:olpc_dcon: more big endian conformity and [PATCH 3/3] Staging:olpc_dcon: more big endian conformity is equal for the Google mail client and lands in the same thread. I'd use Mutt.
I do use mutt, and see two copies of this patch sent.
What happened to patch 1/3, I never got that.
thanks,
greg k-h
Quoted 3 lines
What happened to patch 1/3, I never got that.
You never got it, okay I'll resend it to you.