Test: enable kernel events after start
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 2/2 Test: enable kernel events after start
This test detects if we actually append new metadata when enabling a kernel event after a start.
--- tests/regression/kernel/test_event_basic | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-)
tests/regression/kernel/test_event_basic +23 -1
@@ -19,7 +19,7 @@ TEST_DESC="Kernel tracer - Basic event" CURDIR=$(dirname $0)/ TESTDIR=$CURDIR/../.. -NUM_TESTS=12 +NUM_TESTS=20 source $TESTDIR/utils/utils.sh
@@ -46,6 +46,27 @@ function test_event_basic() rm -rf $TRACE_PATH } +function test_enable_after_start() +{ + TRACE_PATH=$(mktemp -d) + SESSION_NAME="kernel_enable_after_start" + + create_lttng_session $SESSION_NAME $TRACE_PATH + + lttng_enable_kernel_event $SESSION_NAME "sched_switch" + + start_lttng_tracing + lttng_enable_kernel_event $SESSION_NAME "sched_process_exit" + stop_lttng_tracing + + validate_trace "sched_switch" $TRACE_PATH + validate_trace "sched_process_exit" $TRACE_PATH + + destroy_lttng_session $SESSION_NAME + + rm -rf $TRACE_PATH +} + # MUST set TESTDIR before calling those functions plan_tests $NUM_TESTS
@@ -62,6 +83,7 @@ skip $isroot "Root access is needed. Skipping all tests." $NUM_TESTS || start_lttng_sessiond test_event_basic + test_enable_after_start stop_lttng_sessiond }
Signature · 1 line
1.7.10.4
Re: [LTTNG-TOOLS 2.3 PATCH 1/2] Fix: return code of get_subbuff on metadata stream
In reply to a message not in the archiveQuoted 4 lines · * Julien Desfossez ([email protected]) wrote:
On error, the ioctl
kernctl_get_next_subbufreturns -1 and sets errno to a meaningful value but we were ignoring it. It was causinglttng_kconsumer_read_subbufferto return -1 (error) instead of-EAGAIN(normal).
Merging an updated patch instead:
commit 56591bac20c0f3b728c95d92702d243de838bdc4
Author: Mathieu Desnoyers <[email protected]> Date: Mon Aug 5 13:46:58 2013 -0400
Fix: kernel ctl error codes are based on errno
ioctl returns -1, and error codes are based on -errno.
Thanks,
Mathieu
Quoted 22 lines
Signed-off-by Julien Desfossez <[email protected]>--- src/common/kernel-consumer/kernel-consumer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)src/common/kernel-consumer/kernel-consumer.c +1
-1@@ -851,7 +851,7 @@ ssize_t lttng_kconsumer_read_subbuffer(struct lttng_consumer_stream *stream,/* Get the next subbuffer */ err =kernctl_get_next_subbuf (infd);if (err !=0 ) { - ret = err; + ret = -errno;/* * This is a debug message even for single-threaded consumer, * because poll() have more relaxed criterions than get subbuf, Signature · 1 line
1.7.10.4
Signature · 3 lines
Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
Mathieu Desnoyers
AppliedQuoted 2 lines · * Julien Desfossez ([email protected]) wrote:
This test detects if we actually append new metadata when enabling a kernel event after a start.
merged, thanks!
Mathieu
Quoted 58 lines
Signed-off-by Julien Desfossez <[email protected]>--- tests/regression/kernel/test_event_basic | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-)tests/regression/kernel/test_event_basic +23
-1@@ -19,7 +19,7 @@ TEST_DESC="Kernel tracer - Basic event" CURDIR=$(dirname $0)/ TESTDIR=$CURDIR/../.. -NUM_TESTS=12 +NUM_TESTS=20 source $TESTDIR/utils/utils.sh@@ -46,6 +46,27 @@ function test_event_basic() rm -rf $TRACE_PATH } +function test_enable_after_start() +{ + TRACE_PATH=$(mktemp -d) + SESSION_NAME="kernel_enable_after_start" + + create_lttng_session $SESSION_NAME $TRACE_PATH + + lttng_enable_kernel_event $SESSION_NAME "sched_switch" + + start_lttng_tracing + lttng_enable_kernel_event $SESSION_NAME "sched_process_exit" + stop_lttng_tracing + + validate_trace "sched_switch" $TRACE_PATH + validate_trace "sched_process_exit" $TRACE_PATH + + destroy_lttng_session $SESSION_NAME + + rm -rf $TRACE_PATH +} + # MUST set TESTDIR before calling those functions plan_tests $NUM_TESTS@@ -62,6 +83,7 @@ skip $isroot "Root access is needed. Skipping all tests." $NUM_TESTS || start_lttng_sessiond test_event_basic + test_enable_after_start stop_lttng_sessiond }Signature · 1 line
1.7.10.4
Signature · 3 lines
Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com