Skip to contentSkip to conversation

omap: emif: Set initial DDR PHY config first

PATCH In review Taras Kondratiuk 2 participants 2 messages Aug 6, 2013 – Aug 16, 2013 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omap: emif: Set initial DDR PHY config first

Commit "OMAP5: emif/ddr: Change emif settings as required for ES1.0 silicon" (f40107345cbcd6e0d1747eda45e76c4e2a6df0db)
changed sequence to set final DDR PHY config register value at the beginning. Looks like it was made by mistake and should be reverted.

---
Based on v2013.07+ commit f53932a "dts/Makefile: pass -undef -D__DTS__ to cpp"

 arch/arm/cpu/armv7/omap-common/emif-common.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/cpu/armv7/omap-common/emif-common.c +1 -1
index ece3655..b0e1caa 100644
@@ -153,7 +153,7 @@ static void lpddr2_init(u32 base, const struct emif_regs *regs)
 	 * un-locked frequency & default RL
 	 */
 	writel(regs->sdram_config_init, &emif->emif_sdram_config);
-	writel(regs->emif_ddr_phy_ctlr_1, &emif->emif_ddr_phy_ctrl_1);
+	writel(regs->emif_ddr_phy_ctlr_1_init, &emif->emif_ddr_phy_ctrl_1);
 
 	do_ext_phy_settings(base, regs);
 
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 6 lines · Taras Kondratiuk

Commit "OMAP5: emif/ddr: Change emif settings as required for ES1.0 silicon" (f40107345cbcd6e0d1747eda45e76c4e2a6df0db)
changed sequence to set final DDR PHY config register value at the beginning. Looks like it was made by mistake and should be reverted.

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130816/f07d8535/attachment.pgp>