ioatdma: Fix compiler warning
PATCH 1/1 ioatdma: Fix compiler warning
GCC v4.6.3 complains:drivers/dma/ioat/dma_v3.c: In function ‘__ioat3_prep_pq16_lock’:drivers/dma/ioat/dma_v3.c:264:11: warning: array subscript is below array bounds [-Warray-bounds] drivers/dma/ioat/dma_v3.c:264:11: warning: array subscript is below array bounds [-Warray-bounds]
This is due to the possibility of idx being negative, thus being outside the boulds of the array. Correct this by making idx an unsigned int.
--- drivers/dma/ioat/dma_v3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/dma/ioat/dma_v3.c +2 -2
@@ -251,7 +251,7 @@ static bool is_bwd_noraid(struct pci_dev *pdev) }static void pq16_set_src (struct ioat_raw_descriptor *desc[3 ], -dma_addr_t addr,u32 offset,u8 coef,int idx) +dma_addr_t addr,u32 offset,u8 coef,unsigned int idx) {struct ioat_pq_descriptor *pq = (struct ioat_pq_descriptor *)desc[0 ]; struct ioat_pq16a_descriptor *pq16 =
@@ -1180,7 +1180,7 @@ __ioat3_prep_pq16_lock(struct dma_chan *c, enum sum_check_flags *result,struct ioat_pq_descriptor *pq;u32 offset =0 ;u8 op; -int i, s, idx, num_descs; +unsigned int i, s, idx, num_descs;/* this function only handles src_cnt 9 - 16 */ BUG_ON (src_cnt <9 );
Signature · 1 line
1.7.9.5
Quoted 9 lines · Jon Mason
GCC v4.6.3 complains:
drivers/dma/ioat/dma_v3.c: In function ‘__ioat3_prep_pq16_lock’:drivers/dma/ioat/dma_v3.c:264:11: warning: array subscript is below array bounds [-Warray-bounds]drivers/dma/ioat/dma_v3.c:264:11: warning: array subscript is below array bounds [-Warray-bounds]This is due to the possibility of idx being negative, thus being outside the boulds of the array. Correct this by making idx an unsigned int.
Signed-off-by Jon Mason <[email protected]>
I tried to silence these warnings in
https://lkml.org/lkml/2013/6/17/233 . And again, after some feedback, in
https://lkml.org/lkml/2013/7/20/137 . Perhaps that second patch is queued somewhere. I don't know.
Paul Bolle
Quoted 9 lines · Paul Bolle
Quoted 8 lines · Jon Mason
GCC v4.6.3 complains:
drivers/dma/ioat/dma_v3.c: In function ‘__ioat3_prep_pq16_lock’:drivers/dma/ioat/dma_v3.c:264:11: warning: array subscript is below array bounds [-Warray-bounds]drivers/dma/ioat/dma_v3.c:264:11: warning: array subscript is below array bounds [-Warray-bounds]This is due to the possibility of idx being negative, thus being outside the boulds of the array. Correct this by making idx an unsigned int.
Quoted 6 lines
Quoted 1 line
Signed-off-by Jon Mason <[email protected]>I tried to silence these warnings in
https://lkml.org/lkml/2013/6/17/233 . And again, after some feedback, in
https://lkml.org/lkml/2013/7/20/137 . Perhaps that second patch is queued somewhere. I don't know.
I stupidly didn't check for an existing patch before I sent it out. Hopefully Dan/Vinod has your last one queued.
Thanks,
Jon
Quoted 4 lines
Paul Bolle