perf tools: add symbol filter to struct machine
Adrian Hunter
reviewercover perf tools: add symbol filter to struct machine
Hi
Here are some patches that add symbol filter to struct machine as we briefly discussed on irc.
The first patch puts the symbol filter on both struct machine and struct machines so that guest machines added later inherit the same symbol filter.
The next 4 patches change the tools to set the machines symbol filter.
The final 3 patches remove symbol filter as a parameter in some cases where it is redundant.
Adrian Hunter (8):
perf tools: add symbol filter to struct machine
perf top: set the machines symbol filter
perf report: set the machines symbol filter
perf mem: remove unused symbol filter member
perf annotate: set the machines symbol filter
perf tools: remove filter parameter of perf_event__preprocess_sample() perf tools: remove filter parameter of thread__find_addr_location() perf tools: remove filter parameter of thread__find_addr_map()
tools/perf/builtin-annotate.c | 5 +++-- tools/perf/builtin-diff.c | 2 +- tools/perf/builtin-inject.c | 2 +- tools/perf/builtin-mem.c | 4 +--- tools/perf/builtin-report.c | 7 +++---- tools/perf/builtin-script.c | 6 +++--- tools/perf/builtin-top.c | 5 +++-- tools/perf/tests/code-reading.c | 2 +- tools/perf/tests/hists_link.c | 4 ++-- tools/perf/util/build-id.c | 2 +- tools/perf/util/event.c | 20 ++++++++++---------- tools/perf/util/event.h | 3 +-- tools/perf/util/machine.c | 28 ++++++++++++++++++++++++---- tools/perf/util/machine.h | 5 +++++ tools/perf/util/session.c | 3 +-- tools/perf/util/thread.h | 5 ++--- tools/perf/util/unwind.c | 6 +++--- 17 files changed, 65 insertions(+), 44 deletions(-)
Regards
Adrian
Adrian Hunter
reviewerPATCH 1/8 perf tools: add symbol filter to struct machine
The symbol filter needs to be applied machine-wide, so add it to struct machine.
Currently tools pass the symbol filter as a parameter to various map-related functions. However a need to load a map can occur anywhere in the code, at which point the filter is needed.
--- tools/perf/util/machine.c | 20 ++++++++++++++++++++ tools/perf/util/machine.h | 5 +++++ 2 files changed, 25 insertions(+)
tools/perf/util/machine.c +20 -0
@@ -25,6 +25,8 @@ int machine__init(struct machine *machine, const char *root_dir, pid_t pid) machine->kmaps.machine = machine; machine->pid = pid; + machine->symbol_filter =NULL ; + machine->root_dir =strdup (root_dir);if (machine->root_dir ==NULL )return -ENOMEM ;
@@ -95,6 +97,7 @@ void machines__init(struct machines *machines) {machine__init (&machines->host,"" ,HOST_KERNEL_ID ); machines->guests =RB_ROOT ; + machines->symbol_filter =NULL ; }void machines__exit (struct machines *machines)
@@ -118,6 +121,8 @@ struct machine *machines__add(struct machines *machines, pid_t pid,return NULL ; } + machine->symbol_filter = machines->symbol_filter; +while (*p !=NULL ) { parent = *p; pos = rb_entry(parent, struct machine, rb_node);
@@ -133,6 +138,21 @@ struct machine *machines__add(struct machines *machines, pid_t pid,return machine; } +void machines__set_symbol_filter (struct machines *machines, +symbol_filter_t symbol_filter) +{ +struct rb_node *nd; + + machines->symbol_filter = symbol_filter; + machines->host.symbol_filter = symbol_filter; + +for (nd =rb_first (&machines->guests); nd; nd =rb_next (nd)) { + struct machine *machine = rb_entry(nd, struct machine, rb_node); + + machine->symbol_filter = symbol_filter; + } +} +struct machine *machines__find (struct machines *machines,pid_t pid) {struct rb_node **p = &machines->guests.rb_node;
tools/perf/util/machine.h +5 -0
@@ -29,6 +29,7 @@ struct machine {struct list_head kernel_dsos;struct map_groups kmaps;struct map *vmlinux_maps[MAP__NR_TYPES ]; +symbol_filter_t symbol_filter; }; static inline
@@ -51,6 +52,7 @@ typedef void (*machine__process_t)(struct machine *machine, void *data);struct machines {struct machine host;struct rb_root guests; +symbol_filter_t symbol_filter; };void machines__init (struct machines *machines);
@@ -68,6 +70,9 @@ struct machine *machines__findnew(struct machines *machines, pid_t pid);void machines__set_id_hdr_size (struct machines *machines,u16 id_hdr_size);char *machine__mmap_name (struct machine *machine,char *bf,size_t size); +void machines__set_symbol_filter (struct machines *machines, +symbol_filter_t symbol_filter); +int machine__init (struct machine *machine,const char *root_dir,pid_t pid);void machine__exit (struct machine *machine);void machine__delete_dead_threads (struct machine *machine);
Signature · 1 line
1.7.11.7
tip-bot for Adrian Hunter
merge bot[tip:perf/core] perf machine: Add symbol filter to struct machine
perf machine: Add symbol filter to struct machine
Commit-ID: 611a5ce8aa4cdb2daefbd9bed77ec3b3e9bd00ea Gitweb: http://git.kernel.org/tip/611a5ce8aa4cdb2daefbd9bed77ec3b3e9bd00ea Author: Adrian Hunter <[email protected]> AuthorDate: Thu, 8 Aug 2013 14:32:20 +0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 12 Aug 2013 10:31:09 -0300
perf machine: Add symbol filter to struct machine
The symbol filter needs to be applied machine-wide, so add it to struct machine.
Currently tools pass the symbol filter as a parameter to various map-related functions. However a need to load a map can occur anywhere in the code, at which point the filter is needed.
--- tools/perf/util/machine.c | 20 ++++++++++++++++++++ tools/perf/util/machine.h | 5 +++++ 2 files changed, 25 insertions(+)
tools/perf/util/machine.c +20 -0
@@ -25,6 +25,8 @@ int machine__init(struct machine *machine, const char *root_dir, pid_t pid) machine->kmaps.machine = machine; machine->pid = pid; + machine->symbol_filter =NULL ; + machine->root_dir =strdup (root_dir);if (machine->root_dir ==NULL )return -ENOMEM ;
@@ -95,6 +97,7 @@ void machines__init(struct machines *machines) {machine__init (&machines->host,"" ,HOST_KERNEL_ID ); machines->guests =RB_ROOT ; + machines->symbol_filter =NULL ; }void machines__exit (struct machines *machines)
@@ -118,6 +121,8 @@ struct machine *machines__add(struct machines *machines, pid_t pid,return NULL ; } + machine->symbol_filter = machines->symbol_filter; +while (*p !=NULL ) { parent = *p; pos = rb_entry(parent, struct machine, rb_node);
@@ -133,6 +138,21 @@ struct machine *machines__add(struct machines *machines, pid_t pid,return machine; } +void machines__set_symbol_filter (struct machines *machines, +symbol_filter_t symbol_filter) +{ +struct rb_node *nd; + + machines->symbol_filter = symbol_filter; + machines->host.symbol_filter = symbol_filter; + +for (nd =rb_first (&machines->guests); nd; nd =rb_next (nd)) { + struct machine *machine = rb_entry(nd, struct machine, rb_node); + + machine->symbol_filter = symbol_filter; + } +} +struct machine *machines__find (struct machines *machines,pid_t pid) {struct rb_node **p = &machines->guests.rb_node;
tools/perf/util/machine.h +5 -0
@@ -29,6 +29,7 @@ struct machine {struct list_head kernel_dsos;struct map_groups kmaps;struct map *vmlinux_maps[MAP__NR_TYPES ]; +symbol_filter_t symbol_filter; }; static inline
@@ -51,6 +52,7 @@ typedef void (*machine__process_t)(struct machine *machine, void *data);struct machines {struct machine host;struct rb_root guests; +symbol_filter_t symbol_filter; };void machines__init (struct machines *machines);
@@ -68,6 +70,9 @@ struct machine *machines__findnew(struct machines *machines, pid_t pid);void machines__set_id_hdr_size (struct machines *machines,u16 id_hdr_size);char *machine__mmap_name (struct machine *machine,char *bf,size_t size); +void machines__set_symbol_filter (struct machines *machines, +symbol_filter_t symbol_filter); +int machine__init (struct machine *machine,const char *root_dir,pid_t pid);void machine__exit (struct machine *machine);void machine__delete_dead_threads (struct machine *machine);
Adrian Hunter
reviewerPATCH 2/8 perf top: set the machines symbol filter
In reply to Adrian HunterTake into use the machines symbol filter member.
--- tools/perf/builtin-top.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/builtin-top.c +3 -1
@@ -717,7 +717,7 @@ static void perf_event__process_sample(struct perf_tool *tool, top->exact_samples++;if (perf_event__preprocess_sample (event, machine, &al, sample, - symbol_filter) <0 || + machine->symbol_filter) <0 || al.filtered)return ;
@@ -938,6 +938,8 @@ static int __cmd_top(struct perf_top *top)if (top->session ==NULL )return -ENOMEM ; +machines__set_symbol_filter (&top->session->machines, symbol_filter); +if (!objdump_path) { ret =perf_session_env__lookup_objdump (&top->session->header.env);if (ret)
Signature · 1 line
1.7.11.7
tip-bot for Adrian Hunter
merge bot[tip:perf/core] perf top: Set the machines symbol filter
perf top: Set the machines symbol filter
Commit-ID: 36035f78ae1714a0762a2b38b64942d6dcb6471d Gitweb: http://git.kernel.org/tip/36035f78ae1714a0762a2b38b64942d6dcb6471d Author: Adrian Hunter <[email protected]> AuthorDate: Thu, 8 Aug 2013 14:32:21 +0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 12 Aug 2013 10:31:09 -0300
perf top: Set the machines symbol filter
Take into use the machines symbol filter member.
--- tools/perf/builtin-top.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/builtin-top.c +3 -1
@@ -717,7 +717,7 @@ static void perf_event__process_sample(struct perf_tool *tool, top->exact_samples++;if (perf_event__preprocess_sample (event, machine, &al, sample, - symbol_filter) <0 || + machine->symbol_filter) <0 || al.filtered)return ;
@@ -938,6 +938,8 @@ static int __cmd_top(struct perf_top *top)if (top->session ==NULL )return -ENOMEM ; +machines__set_symbol_filter (&top->session->machines, symbol_filter); +if (!objdump_path) { ret =perf_session_env__lookup_objdump (&top->session->header.env);if (ret)
Adrian Hunter
reviewerPATCH 3/8 perf report: set the machines symbol filter
In reply to Adrian HunterTake into use the machines' symbol filter member.
--- tools/perf/builtin-report.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/builtin-report.c +3 -3
@@ -49,7 +49,6 @@ struct perf_report {bool mem_mode;struct perf_read_values show_threads_values;const char *pretty_printing_style; -symbol_filter_t annotate_init;const char *cpu_list;const char *symbol_filter_str;float min_percent;
@@ -306,7 +305,7 @@ static int process_sample_event(struct perf_tool *tool,int ret;if (perf_event__preprocess_sample (event, machine, &al, sample, - rep->annotate_init) <0 ) { + machine->symbol_filter) <0 ) {fprintf (stderr,"problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
@@ -924,7 +923,8 @@ repeat:*/ if (use_browser ==1 && sort__has_sym) { symbol_conf.priv_size =sizeof (struct annotation ); - report.annotate_init = symbol__annotate_init; +machines__set_symbol_filter (&session->machines, + symbol__annotate_init);/* * For searching by name on the "Browse map details". * providing it only in verbose mode not to bloat too
Signature · 1 line
1.7.11.7
tip-bot for Adrian Hunter
merge bot[tip:perf/core] perf report: Set the machines symbol filter
perf report: Set the machines symbol filter
Commit-ID: b8681711271a0124d9495dae2e1ac0616b0ed47a Gitweb: http://git.kernel.org/tip/b8681711271a0124d9495dae2e1ac0616b0ed47a Author: Adrian Hunter <[email protected]> AuthorDate: Thu, 8 Aug 2013 14:32:22 +0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 12 Aug 2013 10:31:10 -0300
perf report: Set the machines symbol filter
Take into use the machines' symbol filter member.
--- tools/perf/builtin-report.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/builtin-report.c +3 -3
@@ -49,7 +49,6 @@ struct perf_report {bool mem_mode;struct perf_read_values show_threads_values;const char *pretty_printing_style; -symbol_filter_t annotate_init;const char *cpu_list;const char *symbol_filter_str;float min_percent;
@@ -306,7 +305,7 @@ static int process_sample_event(struct perf_tool *tool,int ret;if (perf_event__preprocess_sample (event, machine, &al, sample, - rep->annotate_init) <0 ) { + machine->symbol_filter) <0 ) {fprintf (stderr,"problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
@@ -924,7 +923,8 @@ repeat:*/ if (use_browser ==1 && sort__has_sym) { symbol_conf.priv_size =sizeof (struct annotation ); - report.annotate_init = symbol__annotate_init; +machines__set_symbol_filter (&session->machines, + symbol__annotate_init);/* * For searching by name on the "Browse map details". * providing it only in verbose mode not to bloat too
Adrian Hunter
reviewerPATCH 4/8 perf mem: remove unused symbol filter member
In reply to Adrian HunterMember 'annotate_init' of struct perf_mem is unused. Remove it.
--- tools/perf/builtin-mem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
tools/perf/builtin-mem.c +1 -2
@@ -14,7 +14,6 @@ static const char *mem_operation = MEM_OPERATION_LOAD;struct perf_mem {struct perf_tool tool;char const *input_name; -symbol_filter_t annotate_init;bool hide_unresolved;bool dump_raw;const char *cpu_list;
@@ -70,7 +69,7 @@ dump_raw_samples(struct perf_tool *tool,const char *fmt;if (perf_event__preprocess_sample (event, machine, &al, sample, - mem->annotate_init) <0 ) { +NULL ) <0 ) {fprintf (stderr,"problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
Signature · 1 line
1.7.11.7
tip-bot for Adrian Hunter
merge bot[tip:perf/core] perf mem: Remove unused symbol filter member
perf mem: Remove unused symbol filter member
Commit-ID: 2d8cc6851c7b92857e1171ba5fe587d38d886161 Gitweb: http://git.kernel.org/tip/2d8cc6851c7b92857e1171ba5fe587d38d886161 Author: Adrian Hunter <[email protected]> AuthorDate: Thu, 8 Aug 2013 14:32:23 +0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 12 Aug 2013 10:31:10 -0300
perf mem: Remove unused symbol filter member
Member 'annotate_init' of struct perf_mem is unused. Remove it.
--- tools/perf/builtin-mem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
tools/perf/builtin-mem.c +1 -2
@@ -14,7 +14,6 @@ static const char *mem_operation = MEM_OPERATION_LOAD;struct perf_mem {struct perf_tool tool;char const *input_name; -symbol_filter_t annotate_init;bool hide_unresolved;bool dump_raw;const char *cpu_list;
@@ -70,7 +69,7 @@ dump_raw_samples(struct perf_tool *tool,const char *fmt;if (perf_event__preprocess_sample (event, machine, &al, sample, - mem->annotate_init) <0 ) { +NULL ) <0 ) {fprintf (stderr,"problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
Adrian Hunter
reviewerPATCH 5/8 perf annotate: set the machines symbol filter
In reply to Adrian HunterTake into use the machines symbol filter member.
--- tools/perf/builtin-annotate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/builtin-annotate.c +3 -1
@@ -91,7 +91,7 @@ static int process_sample_event(struct perf_tool *tool,struct addr_location al;if (perf_event__preprocess_sample (event, machine, &al, sample, - symbol__annotate_init) <0 ) { + machine->symbol_filter) <0 ) {pr_warning ("problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
@@ -195,6 +195,8 @@ static int __cmd_annotate(struct perf_annotate *ann)if (session ==NULL )return -ENOMEM ; +machines__set_symbol_filter (&session->machines, symbol__annotate_init); +if (ann->cpu_list) { ret =perf_session__cpu_bitmap (session, ann->cpu_list, ann->cpu_bitmap);
Signature · 1 line
1.7.11.7
tip-bot for Adrian Hunter
merge bot[tip:perf/core] perf annotate: Set the machines symbol filter
perf annotate: Set the machines symbol filter
Commit-ID: 476d35c2f3a48f81691daad06bc9668c516428d9 Gitweb: http://git.kernel.org/tip/476d35c2f3a48f81691daad06bc9668c516428d9 Author: Adrian Hunter <[email protected]> AuthorDate: Thu, 8 Aug 2013 14:32:24 +0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 12 Aug 2013 10:31:11 -0300
perf annotate: Set the machines symbol filter
Take into use the machines symbol filter member.
--- tools/perf/builtin-annotate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/builtin-annotate.c +3 -1
@@ -91,7 +91,7 @@ static int process_sample_event(struct perf_tool *tool,struct addr_location al;if (perf_event__preprocess_sample (event, machine, &al, sample, - symbol__annotate_init) <0 ) { + machine->symbol_filter) <0 ) {pr_warning ("problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
@@ -195,6 +195,8 @@ static int __cmd_annotate(struct perf_annotate *ann)if (session ==NULL )return -ENOMEM ; +machines__set_symbol_filter (&session->machines, symbol__annotate_init); +if (ann->cpu_list) { ret =perf_session__cpu_bitmap (session, ann->cpu_list, ann->cpu_bitmap);
Adrian Hunter
reviewerPATCH 6/8 perf tools: remove filter parameter of perf_event__preprocess_sample()
In reply to Adrian HunterNow that the symbol filter is recorded on the machine there is no need to pass it to perf_event__preprocess_sample(). So remove it.
--- tools/perf/builtin-annotate.c | 3 +-- tools/perf/builtin-diff.c | 2 +- tools/perf/builtin-mem.c | 3 +-- tools/perf/builtin-report.c | 3 +-- tools/perf/builtin-script.c | 2 +- tools/perf/builtin-top.c | 3 +-- tools/perf/tests/hists_link.c | 4 ++-- tools/perf/util/event.c | 8 ++++---- tools/perf/util/event.h | 3 +-- tools/perf/util/session.c | 3 +-- 10 files changed, 14 insertions(+), 20 deletions(-)
tools/perf/builtin-annotate.c +1 -2
@@ -90,8 +90,7 @@ static int process_sample_event(struct perf_tool *tool, struct perf_annotate *ann = container_of(tool, struct perf_annotate, tool);struct addr_location al; -if (perf_event__preprocess_sample (event, machine, &al, sample, - machine->symbol_filter) <0 ) { +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 ) {pr_warning ("problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
tools/perf/builtin-diff.c +1 -1
@@ -319,7 +319,7 @@ static int diff__process_sample_event(struct perf_tool *tool __maybe_unused, {struct addr_location al; -if (perf_event__preprocess_sample (event, machine, &al, sample,NULL ) <0 ) { +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 ) {pr_warning ("problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
tools/perf/builtin-mem.c +1 -2
@@ -68,8 +68,7 @@ dump_raw_samples(struct perf_tool *tool,struct addr_location al;const char *fmt; -if (perf_event__preprocess_sample (event, machine, &al, sample, -NULL ) <0 ) { +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 ) {fprintf (stderr,"problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
tools/perf/builtin-report.c +1 -2
@@ -304,8 +304,7 @@ static int process_sample_event(struct perf_tool *tool,struct addr_location al;int ret; -if (perf_event__preprocess_sample (event, machine, &al, sample, - machine->symbol_filter) <0 ) { +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 ) {fprintf (stderr,"problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
tools/perf/builtin-script.c +1 -1
@@ -499,7 +499,7 @@ static int process_sample_event(struct perf_tool *tool __maybe_unused,return 0 ; } -if (perf_event__preprocess_sample (event, machine, &al, sample,0 ) <0 ) { +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 ) {pr_err ("problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
tools/perf/builtin-top.c +1 -2
@@ -716,8 +716,7 @@ static void perf_event__process_sample(struct perf_tool *tool,if (event->header.misc &PERF_RECORD_MISC_EXACT_IP ) top->exact_samples++; -if (perf_event__preprocess_sample (event, machine, &al, sample, - machine->symbol_filter) <0 || +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 || al.filtered)return ;
tools/perf/tests/hists_link.c +2 -2
@@ -220,7 +220,7 @@ static int add_hist_entries(struct perf_evlist *evlist, struct machine *machine) };if (perf_event__preprocess_sample (&event, machine, &al, - &sample,0 ) <0 ) + &sample) <0 ) goto out; he =__hists__add_entry (&evsel->hists, &al,NULL ,1 ,1 );
@@ -244,7 +244,7 @@ static int add_hist_entries(struct perf_evlist *evlist, struct machine *machine) };if (perf_event__preprocess_sample (&event, machine, &al, - &sample,0 ) <0 ) + &sample) <0 ) goto out; he =__hists__add_entry (&evsel->hists, &al,NULL ,1 ,1 );
tools/perf/util/event.c +4 -4
@@ -683,8 +683,7 @@ void thread__find_addr_location(struct thread *thread, struct machine *machine,int perf_event__preprocess_sample (const union perf_event *event,struct machine *machine,struct addr_location *al, -struct perf_sample *sample, -symbol_filter_t filter) +struct perf_sample *sample) {u8 cpumode = event->header.misc &PERF_RECORD_MISC_CPUMODE_MASK ;struct thread *thread =machine__findnew_thread (machine, event->ip.pid);
@@ -709,7 +708,7 @@ int perf_event__preprocess_sample(const union perf_event *event,machine__create_kernel_maps (machine);thread__find_addr_map (thread, machine, cpumode,MAP__FUNCTION , - event->ip.ip, al, filter); + event->ip.ip, al, machine->symbol_filter);dump_printf (" ...... dso: %s\n" , al->map ? al->map->dso->long_name : al->level =='H' ?"[hypervisor]" :"<not found>" );
@@ -727,7 +726,8 @@ int perf_event__preprocess_sample(const union perf_event *event, dso->long_name))))) goto out_filtered; - al->sym =map__find_symbol (al->map, al->addr, filter); + al->sym =map__find_symbol (al->map, al->addr, + machine->symbol_filter); } if (symbol_conf.sym_list &&
tools/perf/util/event.h +1 -2
@@ -234,8 +234,7 @@ struct addr_location;int perf_event__preprocess_sample (const union perf_event *self,struct machine *machine,struct addr_location *al, -struct perf_sample *sample, -symbol_filter_t filter); +struct perf_sample *sample);const char *perf_event__name (unsigned int id);
tools/perf/util/session.c +1 -2
@@ -1494,8 +1494,7 @@ void perf_evsel__print_ip(struct perf_evsel *evsel, union perf_event *event,struct addr_location al;struct callchain_cursor_node *node; -if (perf_event__preprocess_sample (event, machine, &al, sample, -NULL ) <0 ) { +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 ) {error ("problem processing %d event, skipping it.\n" , event->header.type);return ;
Signature · 1 line
1.7.11.7
tip-bot for Adrian Hunter
merge bot[tip:perf/core] perf tools: Remove filter parameter of perf_event__preprocess_sample()
perf tools: Remove filter parameter of perf_event__preprocess_sample()
Commit-ID: e44baa3ea1eaa09d7d247a9b245fcff06561bf96 Gitweb: http://git.kernel.org/tip/e44baa3ea1eaa09d7d247a9b245fcff06561bf96 Author: Adrian Hunter <[email protected]> AuthorDate: Thu, 8 Aug 2013 14:32:25 +0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 12 Aug 2013 10:31:11 -0300
perf tools: Remove filter parameter of perf_event__preprocess_sample()
Now that the symbol filter is recorded on the machine there is no need to pass it to perf_event__preprocess_sample(). So remove it.
--- tools/perf/builtin-annotate.c | 3 +-- tools/perf/builtin-diff.c | 2 +- tools/perf/builtin-mem.c | 3 +-- tools/perf/builtin-report.c | 3 +-- tools/perf/builtin-script.c | 2 +- tools/perf/builtin-top.c | 3 +-- tools/perf/tests/hists_link.c | 4 ++-- tools/perf/util/event.c | 8 ++++---- tools/perf/util/event.h | 3 +-- tools/perf/util/session.c | 3 +-- 10 files changed, 14 insertions(+), 20 deletions(-)
tools/perf/builtin-annotate.c +1 -2
@@ -90,8 +90,7 @@ static int process_sample_event(struct perf_tool *tool, struct perf_annotate *ann = container_of(tool, struct perf_annotate, tool);struct addr_location al; -if (perf_event__preprocess_sample (event, machine, &al, sample, - machine->symbol_filter) <0 ) { +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 ) {pr_warning ("problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
tools/perf/builtin-diff.c +1 -1
@@ -319,7 +319,7 @@ static int diff__process_sample_event(struct perf_tool *tool __maybe_unused, {struct addr_location al; -if (perf_event__preprocess_sample (event, machine, &al, sample,NULL ) <0 ) { +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 ) {pr_warning ("problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
tools/perf/builtin-mem.c +1 -2
@@ -68,8 +68,7 @@ dump_raw_samples(struct perf_tool *tool,struct addr_location al;const char *fmt; -if (perf_event__preprocess_sample (event, machine, &al, sample, -NULL ) <0 ) { +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 ) {fprintf (stderr,"problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
tools/perf/builtin-report.c +1 -2
@@ -304,8 +304,7 @@ static int process_sample_event(struct perf_tool *tool,struct addr_location al;int ret; -if (perf_event__preprocess_sample (event, machine, &al, sample, - machine->symbol_filter) <0 ) { +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 ) {fprintf (stderr,"problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
tools/perf/builtin-script.c +1 -1
@@ -520,7 +520,7 @@ static int process_sample_event(struct perf_tool *tool __maybe_unused,return 0 ; } -if (perf_event__preprocess_sample (event, machine, &al, sample,0 ) <0 ) { +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 ) {pr_err ("problem processing %d event, skipping it.\n" , event->header.type);return -1 ;
tools/perf/builtin-top.c +1 -2
@@ -716,8 +716,7 @@ static void perf_event__process_sample(struct perf_tool *tool,if (event->header.misc &PERF_RECORD_MISC_EXACT_IP ) top->exact_samples++; -if (perf_event__preprocess_sample (event, machine, &al, sample, - machine->symbol_filter) <0 || +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 || al.filtered)return ;
tools/perf/tests/hists_link.c +2 -2
@@ -220,7 +220,7 @@ static int add_hist_entries(struct perf_evlist *evlist, struct machine *machine) };if (perf_event__preprocess_sample (&event, machine, &al, - &sample,0 ) <0 ) + &sample) <0 ) goto out; he =__hists__add_entry (&evsel->hists, &al,NULL ,1 ,1 );
@@ -244,7 +244,7 @@ static int add_hist_entries(struct perf_evlist *evlist, struct machine *machine) };if (perf_event__preprocess_sample (&event, machine, &al, - &sample,0 ) <0 ) + &sample) <0 ) goto out; he =__hists__add_entry (&evsel->hists, &al,NULL ,1 ,1 );
tools/perf/util/event.c +4 -4
@@ -683,8 +683,7 @@ void thread__find_addr_location(struct thread *thread, struct machine *machine,int perf_event__preprocess_sample (const union perf_event *event,struct machine *machine,struct addr_location *al, -struct perf_sample *sample, -symbol_filter_t filter) +struct perf_sample *sample) {u8 cpumode = event->header.misc &PERF_RECORD_MISC_CPUMODE_MASK ;struct thread *thread =machine__findnew_thread (machine, event->ip.pid);
@@ -709,7 +708,7 @@ int perf_event__preprocess_sample(const union perf_event *event,machine__create_kernel_maps (machine);thread__find_addr_map (thread, machine, cpumode,MAP__FUNCTION , - event->ip.ip, al, filter); + event->ip.ip, al, machine->symbol_filter);dump_printf (" ...... dso: %s\n" , al->map ? al->map->dso->long_name : al->level =='H' ?"[hypervisor]" :"<not found>" );
@@ -727,7 +726,8 @@ int perf_event__preprocess_sample(const union perf_event *event, dso->long_name))))) goto out_filtered; - al->sym =map__find_symbol (al->map, al->addr, filter); + al->sym =map__find_symbol (al->map, al->addr, + machine->symbol_filter); } if (symbol_conf.sym_list &&
tools/perf/util/event.h +1 -2
@@ -234,8 +234,7 @@ struct addr_location;int perf_event__preprocess_sample (const union perf_event *self,struct machine *machine,struct addr_location *al, -struct perf_sample *sample, -symbol_filter_t filter); +struct perf_sample *sample);const char *perf_event__name (unsigned int id);
tools/perf/util/session.c +1 -2
@@ -1503,8 +1503,7 @@ void perf_evsel__print_ip(struct perf_evsel *evsel, union perf_event *event,int print_oneline = print_opts &PRINT_IP_OPT_ONELINE ;char s = print_oneline ?' ' :'\t' ; -if (perf_event__preprocess_sample (event, machine, &al, sample, -NULL ) <0 ) { +if (perf_event__preprocess_sample (event, machine, &al, sample) <0 ) {error ("problem processing %d event, skipping it.\n" , event->header.type);return ;
Adrian Hunter
reviewerPATCH 7/8 perf tools: remove filter parameter of thread__find_addr_location()
In reply to Adrian HunterNow that the symbol filter is recorded on the machine there is no need to pass it to thread__find_addr_location(). So remove it.
--- tools/perf/util/event.c | 9 +++++---- tools/perf/util/machine.c | 8 ++++---- tools/perf/util/thread.h | 3 +-- tools/perf/util/unwind.c | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-)
tools/perf/util/event.c +5 -4
@@ -670,12 +670,13 @@ try_again:void thread__find_addr_location (struct thread *thread,struct machine *machine,u8 cpumode,enum map_type type,u64 addr, -struct addr_location *al, -symbol_filter_t filter) +struct addr_location *al) { -thread__find_addr_map (thread, machine, cpumode, type, addr, al, filter); +thread__find_addr_map (thread, machine, cpumode, type, addr, al, + machine->symbol_filter);if (al->map !=NULL ) - al->sym =map__find_symbol (al->map, al->addr, filter); + al->sym =map__find_symbol (al->map, al->addr, + machine->symbol_filter);else al->sym =NULL ; }
tools/perf/util/machine.c +4 -4
@@ -1130,7 +1130,7 @@ static void ip__resolve_ams(struct machine *machine, struct thread *thread,* or else, the symbol is unknown */ thread__find_addr_location (thread, machine, m,MAP__FUNCTION , - ip, &al,NULL ); + ip, &al);if (al.sym) goto found; }
@@ -1148,8 +1148,8 @@ static void ip__resolve_data(struct machine *machine, struct thread *thread,memset (&al,0 ,sizeof (al)); -thread__find_addr_location (thread, machine, m,MAP__VARIABLE , addr, &al, -NULL ); +thread__find_addr_location (thread, machine, m,MAP__VARIABLE , addr, + &al); ams->addr = addr; ams->al_addr = al.addr; ams->sym = al.sym;
@@ -1244,7 +1244,7 @@ static int machine__resolve_callchain_sample(struct machine *machine, al.filtered = false;thread__find_addr_location (thread, machine, cpumode, -MAP__FUNCTION , ip, &al,NULL ); +MAP__FUNCTION , ip, &al);if (al.sym !=NULL ) {if (sort__has_parent && !*parent &&symbol__match_regex (al.sym, &parent_regex))
tools/perf/util/thread.h +1 -2
@@ -45,8 +45,7 @@ void thread__find_addr_map(struct thread *thread, struct machine *machine,void thread__find_addr_location (struct thread *thread,struct machine *machine,u8 cpumode,enum map_type type,u64 addr, -struct addr_location *al, -symbol_filter_t filter); +struct addr_location *al);static inline void *thread__priv (struct thread *thread) {
tools/perf/util/unwind.c +1 -1
@@ -473,7 +473,7 @@ static int entry(u64 ip, struct thread *thread, struct machine *machine,thread__find_addr_location (thread, machine,PERF_RECORD_MISC_USER , -MAP__FUNCTION , ip, &al,NULL ); +MAP__FUNCTION , ip, &al); e.ip = ip; e.map = al.map;
Signature · 1 line
1.7.11.7
tip-bot for Adrian Hunter
merge bot[tip:perf/core] perf tools: Remove filter parameter of thread__find_addr_location()
perf tools: Remove filter parameter of thread__find_addr_location()
Commit-ID: 61710bdee324aab1c148c8573ee49cea59d05874 Gitweb: http://git.kernel.org/tip/61710bdee324aab1c148c8573ee49cea59d05874 Author: Adrian Hunter <[email protected]> AuthorDate: Thu, 8 Aug 2013 14:32:26 +0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 12 Aug 2013 10:31:12 -0300
perf tools: Remove filter parameter of thread__find_addr_location()
Now that the symbol filter is recorded on the machine there is no need to pass it to thread__find_addr_location(). So remove it.
--- tools/perf/util/event.c | 9 +++++---- tools/perf/util/machine.c | 8 ++++---- tools/perf/util/thread.h | 3 +-- tools/perf/util/unwind.c | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-)
tools/perf/util/event.c +5 -4
@@ -670,12 +670,13 @@ try_again:void thread__find_addr_location (struct thread *thread,struct machine *machine,u8 cpumode,enum map_type type,u64 addr, -struct addr_location *al, -symbol_filter_t filter) +struct addr_location *al) { -thread__find_addr_map (thread, machine, cpumode, type, addr, al, filter); +thread__find_addr_map (thread, machine, cpumode, type, addr, al, + machine->symbol_filter);if (al->map !=NULL ) - al->sym =map__find_symbol (al->map, al->addr, filter); + al->sym =map__find_symbol (al->map, al->addr, + machine->symbol_filter);else al->sym =NULL ; }
tools/perf/util/machine.c +4 -4
@@ -1130,7 +1130,7 @@ static void ip__resolve_ams(struct machine *machine, struct thread *thread,* or else, the symbol is unknown */ thread__find_addr_location (thread, machine, m,MAP__FUNCTION , - ip, &al,NULL ); + ip, &al);if (al.sym) goto found; }
@@ -1148,8 +1148,8 @@ static void ip__resolve_data(struct machine *machine, struct thread *thread,memset (&al,0 ,sizeof (al)); -thread__find_addr_location (thread, machine, m,MAP__VARIABLE , addr, &al, -NULL ); +thread__find_addr_location (thread, machine, m,MAP__VARIABLE , addr, + &al); ams->addr = addr; ams->al_addr = al.addr; ams->sym = al.sym;
@@ -1244,7 +1244,7 @@ static int machine__resolve_callchain_sample(struct machine *machine, al.filtered = false;thread__find_addr_location (thread, machine, cpumode, -MAP__FUNCTION , ip, &al,NULL ); +MAP__FUNCTION , ip, &al);if (al.sym !=NULL ) {if (sort__has_parent && !*parent &&symbol__match_regex (al.sym, &parent_regex))
tools/perf/util/thread.h +1 -2
@@ -45,8 +45,7 @@ void thread__find_addr_map(struct thread *thread, struct machine *machine,void thread__find_addr_location (struct thread *thread,struct machine *machine,u8 cpumode,enum map_type type,u64 addr, -struct addr_location *al, -symbol_filter_t filter); +struct addr_location *al);static inline void *thread__priv (struct thread *thread) {
tools/perf/util/unwind.c +1 -1
@@ -473,7 +473,7 @@ static int entry(u64 ip, struct thread *thread, struct machine *machine,thread__find_addr_location (thread, machine,PERF_RECORD_MISC_USER , -MAP__FUNCTION , ip, &al,NULL ); +MAP__FUNCTION , ip, &al); e.ip = ip; e.map = al.map;
Adrian Hunter
reviewerPATCH 8/8 perf tools: remove filter parameter of thread__find_addr_map()
In reply to Adrian HunterNow that the symbol filter is recorded on the machine there is no need to pass it to thread__find_addr_map(). So remove it.
--- tools/perf/builtin-inject.c | 2 +- tools/perf/builtin-script.c | 4 ++-- tools/perf/tests/code-reading.c | 2 +- tools/perf/util/build-id.c | 2 +- tools/perf/util/event.c | 9 ++++----- tools/perf/util/thread.h | 2 +- tools/perf/util/unwind.c | 4 ++-- 7 files changed, 12 insertions(+), 13 deletions(-)
tools/perf/builtin-inject.c +1 -1
@@ -206,7 +206,7 @@ static int perf_event__inject_buildid(struct perf_tool *tool, }thread__find_addr_map (thread, machine, cpumode,MAP__FUNCTION , - event->ip.ip, &al,NULL ); + event->ip.ip, &al);if (al.map !=NULL ) {if (!al.map->dso->hit) {
tools/perf/builtin-script.c +2 -2
@@ -341,10 +341,10 @@ static void print_sample_addr(union perf_event *event,return ;thread__find_addr_map (thread, machine, cpumode,MAP__FUNCTION , - sample->addr, &al,NULL ); + sample->addr, &al);if (!al.map)thread__find_addr_map (thread, machine, cpumode,MAP__VARIABLE , - sample->addr, &al,NULL ); + sample->addr, &al); al.cpu = sample->cpu; al.sym =NULL ;
tools/perf/tests/code-reading.c +1 -1
@@ -147,7 +147,7 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode,pr_debug ("Reading object code for memory address: %#" PRIx64"\n" , addr);thread__find_addr_map (thread, machine, cpumode,MAP__FUNCTION , addr, - &al,NULL ); + &al);if (!al.map || !al.map->dso) {pr_debug ("thread__find_addr_map failed\n" );return -1 ;
tools/perf/util/build-id.c +1 -1
@@ -33,7 +33,7 @@ int build_id__mark_dso_hit(struct perf_tool *tool __maybe_unused, }thread__find_addr_map (thread, machine, cpumode,MAP__FUNCTION , - event->ip.ip, &al,NULL ); + event->ip.ip, &al);if (al.map !=NULL ) al.map->dso->hit =1 ;
tools/perf/util/event.c +4 -5
@@ -592,7 +592,7 @@ int perf_event__process(struct perf_tool *tool __maybe_unused,void thread__find_addr_map (struct thread *self,struct machine *machine,u8 cpumode,enum map_type type,u64 addr, -struct addr_location *al,symbol_filter_t filter) +struct addr_location *al) {struct map_groups *mg = &self->mg;bool load_map = false;
@@ -663,7 +663,7 @@ try_again:* must be done prior to using kernel maps. */ if (load_map) -map__load (al->map, filter); +map__load (al->map, machine->symbol_filter); al->addr = al->map->map_ip (al->map, al->addr); } }
@@ -672,8 +672,7 @@ void thread__find_addr_location(struct thread *thread, struct machine *machine, u8 cpumode, enum map_type type, u64 addr, struct addr_location *al) { -thread__find_addr_map (thread ,machine ,cpumode ,type ,addr ,al , - machine->symbol_filter); +thread__find_addr_map (thread ,machine ,cpumode ,type ,addr ,al );if (al->map !=NULL ) al->sym =map__find_symbol (al->map, al->addr, machine->symbol_filter);
@@ -709,7 +708,7 @@ int perf_event__preprocess_sample(const union perf_event *event,machine__create_kernel_maps (machine);thread__find_addr_map (thread, machine, cpumode,MAP__FUNCTION , - event->ip.ip, al, machine->symbol_filter); + event->ip.ip, al);dump_printf (" ...... dso: %s\n" , al->map ? al->map->dso->long_name : al->level =='H' ?"[hypervisor]" :"<not found>" );
tools/perf/util/thread.h +1 -1
@@ -41,7 +41,7 @@ static inline struct map *thread__find_map(struct thread *self,void thread__find_addr_map (struct thread *thread,struct machine *machine,u8 cpumode,enum map_type type,u64 addr, -struct addr_location *al,symbol_filter_t filter); +struct addr_location *al); void thread__find_addr_location(struct thread *thread, struct machine *machine, u8 cpumode, enum map_type type, u64 addr,
tools/perf/util/unwind.c +2 -2
@@ -272,7 +272,7 @@ static struct map *find_map(unw_word_t ip, struct unwind_info *ui)struct addr_location al;thread__find_addr_map (ui->thread, ui->machine,PERF_RECORD_MISC_USER , -MAP__FUNCTION , ip, &al,NULL ); +MAP__FUNCTION , ip, &al);return al.map; }
@@ -349,7 +349,7 @@ static int access_dso_mem(struct unwind_info *ui, unw_word_t addr,ssize_t size;thread__find_addr_map (ui->thread, ui->machine,PERF_RECORD_MISC_USER , -MAP__FUNCTION , addr, &al,NULL ); +MAP__FUNCTION , addr, &al);if (!al.map) {pr_debug ("unwind: no map for %lx\n" , (unsigned long )addr);return -1 ;
Signature · 1 line
1.7.11.7
tip-bot for Adrian Hunter
merge bot[tip:perf/core] perf tools: Remove filter parameter of thread__find_addr_map()
perf tools: Remove filter parameter of thread__find_addr_map()
Commit-ID: 326f59bf645ea6c99709c67d9712df46019fa7a8 Gitweb: http://git.kernel.org/tip/326f59bf645ea6c99709c67d9712df46019fa7a8 Author: Adrian Hunter <[email protected]> AuthorDate: Thu, 8 Aug 2013 14:32:27 +0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 12 Aug 2013 10:31:12 -0300
perf tools: Remove filter parameter of thread__find_addr_map()
Now that the symbol filter is recorded on the machine there is no need to pass it to thread__find_addr_map(). So remove it.
--- tools/perf/builtin-inject.c | 2 +- tools/perf/builtin-script.c | 4 ++-- tools/perf/tests/code-reading.c | 2 +- tools/perf/util/build-id.c | 2 +- tools/perf/util/event.c | 9 ++++----- tools/perf/util/thread.h | 2 +- tools/perf/util/unwind.c | 4 ++-- 7 files changed, 12 insertions(+), 13 deletions(-)
tools/perf/builtin-inject.c +1 -1
@@ -206,7 +206,7 @@ static int perf_event__inject_buildid(struct perf_tool *tool, }thread__find_addr_map (thread, machine, cpumode,MAP__FUNCTION , - event->ip.ip, &al,NULL ); + event->ip.ip, &al);if (al.map !=NULL ) {if (!al.map->dso->hit) {
tools/perf/builtin-script.c +2 -2
@@ -361,10 +361,10 @@ static void print_sample_addr(union perf_event *event,return ;thread__find_addr_map (thread, machine, cpumode,MAP__FUNCTION , - sample->addr, &al,NULL ); + sample->addr, &al);if (!al.map)thread__find_addr_map (thread, machine, cpumode,MAP__VARIABLE , - sample->addr, &al,NULL ); + sample->addr, &al); al.cpu = sample->cpu; al.sym =NULL ;
tools/perf/tests/code-reading.c +1 -1
@@ -147,7 +147,7 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode,pr_debug ("Reading object code for memory address: %#" PRIx64"\n" , addr);thread__find_addr_map (thread, machine, cpumode,MAP__FUNCTION , addr, - &al,NULL ); + &al);if (!al.map || !al.map->dso) {pr_debug ("thread__find_addr_map failed\n" );return -1 ;
tools/perf/util/build-id.c +1 -1
@@ -33,7 +33,7 @@ int build_id__mark_dso_hit(struct perf_tool *tool __maybe_unused, }thread__find_addr_map (thread, machine, cpumode,MAP__FUNCTION , - event->ip.ip, &al,NULL ); + event->ip.ip, &al);if (al.map !=NULL ) al.map->dso->hit =1 ;
tools/perf/util/event.c +4 -5
@@ -592,7 +592,7 @@ int perf_event__process(struct perf_tool *tool __maybe_unused,void thread__find_addr_map (struct thread *self,struct machine *machine,u8 cpumode,enum map_type type,u64 addr, -struct addr_location *al,symbol_filter_t filter) +struct addr_location *al) {struct map_groups *mg = &self->mg;bool load_map = false;
@@ -663,7 +663,7 @@ try_again:* must be done prior to using kernel maps. */ if (load_map) -map__load (al->map, filter); +map__load (al->map, machine->symbol_filter); al->addr = al->map->map_ip (al->map, al->addr); } }
@@ -672,8 +672,7 @@ void thread__find_addr_location(struct thread *thread, struct machine *machine, u8 cpumode, enum map_type type, u64 addr, struct addr_location *al) { -thread__find_addr_map (thread ,machine ,cpumode ,type ,addr ,al , - machine->symbol_filter); +thread__find_addr_map (thread ,machine ,cpumode ,type ,addr ,al );if (al->map !=NULL ) al->sym =map__find_symbol (al->map, al->addr, machine->symbol_filter);
@@ -709,7 +708,7 @@ int perf_event__preprocess_sample(const union perf_event *event,machine__create_kernel_maps (machine);thread__find_addr_map (thread, machine, cpumode,MAP__FUNCTION , - event->ip.ip, al, machine->symbol_filter); + event->ip.ip, al);dump_printf (" ...... dso: %s\n" , al->map ? al->map->dso->long_name : al->level =='H' ?"[hypervisor]" :"<not found>" );
tools/perf/util/thread.h +1 -1
@@ -41,7 +41,7 @@ static inline struct map *thread__find_map(struct thread *self,void thread__find_addr_map (struct thread *thread,struct machine *machine,u8 cpumode,enum map_type type,u64 addr, -struct addr_location *al,symbol_filter_t filter); +struct addr_location *al); void thread__find_addr_location(struct thread *thread, struct machine *machine, u8 cpumode, enum map_type type, u64 addr,
tools/perf/util/unwind.c +2 -2
@@ -272,7 +272,7 @@ static struct map *find_map(unw_word_t ip, struct unwind_info *ui)struct addr_location al;thread__find_addr_map (ui->thread, ui->machine,PERF_RECORD_MISC_USER , -MAP__FUNCTION , ip, &al,NULL ); +MAP__FUNCTION , ip, &al);return al.map; }
@@ -349,7 +349,7 @@ static int access_dso_mem(struct unwind_info *ui, unw_word_t addr,ssize_t size;thread__find_addr_map (ui->thread, ui->machine,PERF_RECORD_MISC_USER , -MAP__FUNCTION , addr, &al,NULL ); +MAP__FUNCTION , addr, &al);if (!al.map) {pr_debug ("unwind: no map for %lx\n" , (unsigned long )addr);return -1 ;
Arnaldo Carvalho de Melo
AppliedEm Thu, Aug 08, 2013 at 02:32:19PM +0300, Adrian Hunter escreveu:
Quoted 11 lines
Here are some patches that add symbol filter to struct machine as we briefly discussed on irc.
The first patch puts the symbol filter on both struct machine and struct machines so that guest machines added later inherit the same symbol filter.
The next 4 patches change the tools to set the machines symbol filter.
The final 3 patches remove symbol filter as a parameter in some cases where it is redundant.
Thanks, applied!
- Arnaldo