Skip to contentSkip to conversation

Fix an issue with runtime remapping and multilibs

PATCH New Mark Hatle 1 participant 2 messages Aug 9, 2013

lore
Share & tools
lore

Mark Hatle

author
#0 lore raw

PATCH 1/1 Fix an issue with runtime remapping and multilibs

Fix an issue with runtime remapping and multilibs when the remapped filename is the same as the original (non-multilib) name. This can happen with all arch, and module packages.

Mark Hatle (1):
image.bbclass: Move runtime_mapping_rename to avoid conflict w/
multilib

 meta/classes/image.bbclass | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)
Signature · 1 line
1.8.3
author
#1 lore raw

PATCH 1/1 image.bbclass: Move runtime_mapping_rename to avoid conflict w/ multilib

[YOCTO #4993]

Move the runtime_mapping_rename into a prefunc for the do_rootfs function. Otherwise doing it in the python section could occur BEFORE the multilib classes renaming.

If the package 'b' is a kernel module, then lib32-b and b should both point to the same package. The runtime_mapping code will do this automatically.

Before if you ran: bitbake lib32-<image>

It may do:

start PACKAGE_INSTALL (a b c)
remap (a b c)
MULTILIB naming (lib32-a lib32-b lib32-c)

What we want is:

start PACKAGE_INSTALL (a b c)
MULTILIB naming (lib32-a lib32-b lib32-c)
remap (lib32-a b lib32-c)

Signed-off-by Mark Hatle <[email protected]>
---
 meta/classes/image.bbclass | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)
meta/classes/image.bbclass +11 -6
index cf02f88..4aae3a7 100644
@@ -128,12 +128,6 @@ python () {
 
     d.setVar('IMAGE_FEATURES', ' '.join(list(remain_features)))
 
-    if d.getVar('BB_WORKERCONTEXT', True) is not None:
-        pn = d.getVar('PN', True)
-        runtime_mapping_rename("PACKAGE_INSTALL", pn, d)
-        runtime_mapping_rename("PACKAGE_INSTALL_ATTEMPTONLY", pn, d)
-        runtime_mapping_rename("BAD_RECOMMENDATIONS", pn, d)
-
     # Ensure we have the vendor list for complementary package handling
     ml_vendor_list = ""
     multilibs = d.getVar('MULTILIBS', True) or ""

@@ -271,6 +265,17 @@ read_only_rootfs_hook () {
 	fi
 }
 
+# We have to delay the runtime_mapping_rename until just before rootfs runs
+# otherwise, the multilib renaming could step in and squash any fixups that
+# may have occurred.
+python rootfs_runtime_mapping() {
+    pn = d.getVar('PN', True)
+    runtime_mapping_rename("PACKAGE_INSTALL", pn, d)
+    runtime_mapping_rename("PACKAGE_INSTALL_ATTEMPTONLY", pn, d)
+    runtime_mapping_rename("BAD_RECOMMENDATIONS", pn, d)
+}
+do_rootfs[prefuncs] += "rootfs_runtime_mapping"
+
 fakeroot do_rootfs () {
 	#set -x
 	# When use the rpm incremental image generation, don't remove the rootfs
Signature · 1 line
1.8.3