usb: Move definition of USB_EHCI_BIG_ENDIAN_MMIO et al. out side of the ifs.
PATCH v2 1/1 usb: Move definition of USB_EHCI_BIG_ENDIAN_MMIO et al. out side of the ifs.
From: David Daney <[email protected]>
When CONFIG_USB_SUPPORT is not selected we get things like:
scripts/kconfig/mconf Kconfig
warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
It is much cleaner to make the various system Kconfigs select USB_EHCI_BIG_ENDIAN_MMIO rather than move the system config information into USB's Kconfig, but the warnings are annoying.
Eliminate the warning by moving the definition of USB_EHCI_BIG_ENDIAN_MMIO outside of all the Kconfig if statements. While we are at it move USB_OHCI_BIG_ENDIAN_DESC, USB_OHCI_BIG_ENDIAN_MMIO, USB_OHCI_LITTLE_ENDIAN and USB_EHCI_BIG_ENDIAN_DESC too, as they could very well suffer similar problems for other systems.
Get rid of the redundant "default n" in USB_OHCI_BIG_ENDIAN_DESC and USB_OHCI_BIG_ENDIAN_MMIO
---
Change from v1: Added USB_OHCI_BIG_ENDIAN_DESC, USB_OHCI_BIG_ENDIAN_MMIO, USB_OHCI_LITTLE_ENDIAN and USB_EHCI_BIG_ENDIAN_DESC to the set of symbols moved.
drivers/usb/Kconfig | 17 +++++++++++++++++ drivers/usb/host/Kconfig | 20 -------------------- 2 files changed, 17 insertions(+), 20 deletions(-)
drivers/usb/Kconfig +17 -0
@@ -6,9 +6,26 @@ config USB_ARCH_HAS_OHCI bool +config USB_OHCI_BIG_ENDIAN_DESC + bool + +config USB_OHCI_BIG_ENDIAN_MMIO + bool + +config USB_OHCI_LITTLE_ENDIAN + bool + default n if STB03xxx || PPC_MPC52xx + default y + config USB_ARCH_HAS_EHCI bool +config USB_EHCI_BIG_ENDIAN_MMIO + bool + +config USB_EHCI_BIG_ENDIAN_DESC + bool + config USB_ARCH_HAS_XHCI bool
drivers/usb/host/Kconfig +0 -20
@@ -113,12 +113,6 @@ config USB_EHCI_HCD_PMC_MSP Enables support for the onchip USB controller on the PMC_MSP7100 Family SoC's. If unsure, say N. -config USB_EHCI_BIG_ENDIAN_MMIO - bool - -config USB_EHCI_BIG_ENDIAN_DESC - bool - config XPS_USB_HCD_XILINX bool "Use Xilinx usb host EHCI controller core" depends on (PPC32 || MICROBLAZE)
@@ -506,20 +500,6 @@ config USB_OCTEON_OHCI controller. It is needed for low-speed USB 1.0 device support. All CN6XXX based chips with USB are supported. - -config USB_OHCI_BIG_ENDIAN_DESC - bool - default n - -config USB_OHCI_BIG_ENDIAN_MMIO - bool - default n - -config USB_OHCI_LITTLE_ENDIAN - bool - default n if STB03xxx || PPC_MPC52xx - default y - endif # USB_OHCI_HCD config USB_UHCI_HCD
Signature · 1 line
1.7.11.7
Quoted 21 lines · David Daney
From: David Daney <[email protected]>
When
CONFIG_USB_SUPPORTis not selected we get things like:
scripts/kconfig/mconfKconfig
warning: (MIPS_SEAD3&&PMC_MSP&&CPU_CAVIUM_OCTEON) selectsUSB_EHCI_BIG_ENDIAN_MMIOwhich has unmet direct dependencies (USB_SUPPORT&& USB)It is much cleaner to make the various system Kconfigs select
USB_EHCI_BIG_ENDIAN_MMIOrather than move the system config information into USB'sKconfig, but the warnings are annoying.Eliminate the warning by moving the definition of
USB_EHCI_BIG_ENDIAN_MMIOoutside of all theKconfigif statements. While we are at it moveUSB_OHCI_BIG_ENDIAN_DESC,USB_OHCI_BIG_ENDIAN_MMIO,USB_OHCI_LITTLE_ENDIANandUSB_EHCI_BIG_ENDIAN_DESCtoo, as they could very well suffer similar problems for other systems.Get rid of the redundant "default n" in
USB_OHCI_BIG_ENDIAN_DESCandUSB_OHCI_BIG_ENDIAN_MMIO
Quoted 7 lines
Signed-off-by David Daney <[email protected]>Cc Alan Stern <[email protected]>---
Change from v1: Added
USB_OHCI_BIG_ENDIAN_DESC,USB_OHCI_BIG_ENDIAN_MMIO,USB_OHCI_LITTLE_ENDIANandUSB_EHCI_BIG_ENDIAN_DESCto the set of symbols moved.