Skip to contentSkip to conversation

irq: enable all irqs unconditionally in irq_resume

PATCH New Laxman Dewangan 1 participant 1 message Aug 13, 2013 IRQ

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 irq: enable all irqs unconditionally in irq_resume

When system enters into suspend, it disable all irqs in single function call. This disables EARLY_RESUME irqs also along with normal irqs.

The EARLY_RESUME irqs get enabled in sys_core_ops->resume and non-EARLY_RESUME irqs get enabled in normal system resume path.

When suspend_noirq failed or suspend is aborted for any reason, the EARLY_RESUME irqs do not get enabled as sys_core_ops->resume() call did not happen. It only enables the non-EARLY_RESUME irqs in normal disable for remaining life of system.

Enable all irqs unconditionally in normal irq_resume() regardless of EARLY_RESUME irqs have been already enabled or not.

---
Creating this patch based on disucssion on patch
[PATCH] irq: enable suspended EARLY_RESUME irqs forcefully if not resumed

Making simple change as susggested by Thomas.

 kernel/irq/pm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/irq/pm.c +1 -1
index cb228bf..abcd6ca 100644
@@ -50,7 +50,7 @@ static void resume_irqs(bool want_early)
 		bool is_early = desc->action &&
 			desc->action->flags & IRQF_EARLY_RESUME;
 
-		if (is_early != want_early)
+		if (!is_early && want_early)
 			continue;
 
 		raw_spin_lock_irqsave(&desc->lock, flags);
Signature · 1 line
1.7.1.1