drivers/misc/hpilo: Correct panic when an AUX iLO is detected
PATCH 1/1 drivers/misc/hpilo: Correct panic when an AUX iLO is detected
Using an uninitialized variable 'devnum' after 'goto out;' was causing panic. Just go ahead and return, we need to ignore AUX iLO devs.
Oops: 0002 [#1] SMP . . . RIP [<ffffffffa033e270>] ilo_probe+0xec/0xe7c [hpilo] --- drivers/misc/hpilo.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/misc/hpilo.c +2 -2
@@ -759,7 +759,7 @@ static int ilo_probe(struct pci_dev *pdev,/* Ignore subsystem_device = 0x1979 (set by BIOS) */ if (pdev->subsystem_device ==0x1979 ) - goto out; +return 0 ;if (max_ccb >MAX_CCB ) max_ccb =MAX_CCB ;
@@ -899,7 +899,7 @@ static void __exit ilo_exit(void)class_destroy (ilo_class); } -MODULE_VERSION ("1.4" ); +MODULE_VERSION ("1.4.1" );MODULE_ALIAS (ILO_NAME );MODULE_DESCRIPTION (ILO_NAME );MODULE_AUTHOR ("David Altobelli <[email protected]>" );
Signature · 1 line
1.7.1
Greg KH
maintainerQuoted 11 lines · Mark Rusk
Using an uninitialized variable 'devnum' after 'goto out;' was causing panic. Just go ahead and return, we need to ignore AUX iLO devs.
Oops: 0002 [#1] SMP . . . RIP [<ffffffffa033e270>] ilo_probe+0xec/0xe7c [hpilo] --- drivers/misc/hpilo.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
I think you forgot to run this patch through the checkpatch.pl tool before you sent it out, right (hint, no signed-off-by line...)
Please fix it up and resend, so that it can be applied...
greg k-h