Skip to contentSkip to conversation

drivers/misc/hpilo: Correct panic when an AUX iLO is detected

PATCH New Mark Rusk 1 participant 1 message Aug 14, 2013

Subsystems (2)
lore
Share & tools
lore

Mark Rusk

author
#0 lore raw

PATCH 1/1 drivers/misc/hpilo: Correct panic when an AUX iLO is detected

Using an uninitialized variable 'devnum' after 'goto out;' was causing panic. Just go ahead and return, we need to ignore AUX iLO devs.

 Oops: 0002 [#1] SMP
   .
   .
   .
 RIP  [<ffffffffa033e270>] ilo_probe+0xec/0xe7c [hpilo]
---
 drivers/misc/hpilo.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/misc/hpilo.c +2 -2
index 621c7a3..b83e3ca 100644
@@ -759,7 +759,7 @@ static int ilo_probe(struct pci_dev *pdev,
 
 	/* Ignore subsystem_device = 0x1979 (set by BIOS)  */
 	if (pdev->subsystem_device == 0x1979)
-		goto out;
+		return 0;
 
 	if (max_ccb > MAX_CCB)
 		max_ccb = MAX_CCB;
@@ -899,7 +899,7 @@ static void __exit ilo_exit(void)
 	class_destroy(ilo_class);
 }
 
-MODULE_VERSION("1.4");
+MODULE_VERSION("1.4.1");
 MODULE_ALIAS(ILO_NAME);
 MODULE_DESCRIPTION(ILO_NAME);
 MODULE_AUTHOR("David Altobelli <[email protected]>");
Signature · 1 line
1.7.1