LTTng ringbuffer ABI calls for index generation
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 2/2 LTTng ringbuffer ABI calls for index generation
These new calls export the data required for the consumer to generate the index while tracing :
- timestamp begin
- timestamp end
- events discarded
- context size
- packet size
- stream id
--- include/lttng/ust-ctl.h | 14 ++++ liblttng-ust-ctl/ustctl.c | 125 +++++++++++++++++++++++++++++++ liblttng-ust/lttng-rb-clients.h | 19 +++++ liblttng-ust/lttng-ring-buffer-client.h | 91 ++++++++++++++++++++++ 4 files changed, 249 insertions(+)
include/lttng/ust-ctl.h +14 -0
@@ -220,6 +220,20 @@ int ustctl_put_subbuf(struct ustctl_consumer_stream *stream);void ustctl_flush_buffer (struct ustctl_consumer_stream *stream,int producer_active); +/* index */ +int ustctl_get_timestamp_begin (struct ustctl_consumer_stream *stream, +uint64_t *timestamp_begin); +int ustctl_get_timestamp_end (struct ustctl_consumer_stream *stream, +uint64_t *timestamp_end); +int ustctl_get_events_discarded (struct ustctl_consumer_stream *stream, +uint64_t *events_discarded); +int ustctl_get_content_size (struct ustctl_consumer_stream *stream, +uint64_t *content_size); +int ustctl_get_packet_size (struct ustctl_consumer_stream *stream, +uint64_t *packet_size); +int ustctl_get_stream_id (struct ustctl_consumer_stream *stream, +uint64_t *stream_id); +/* event registry management */ enum ustctl_socket_type {
liblttng-ust-ctl/ustctl.c +125 -0
137 lines not on this page · raw message
liblttng-ust/lttng-rb-clients.h +19 -0
@@ -21,6 +21,25 @@struct lttng_ust_client_lib_ring_buffer_client_cb {struct lttng_ust_lib_ring_buffer_client_cb parent; + +int (*timestamp_begin) (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *timestamp_begin); +int (*timestamp_end) (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *timestamp_end); +int (*events_discarded) (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *events_discarded); +int (*content_size) (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *content_size); +int (*packet_size) (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *packet_size); +int (*stream_id) (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *stream_id); };#endif /* _LTTNG_RB_CLIENT_H */
liblttng-ust/lttng-ring-buffer-client.h +91 -0
103 lines not on this page · raw message
Signature · 1 line
1.7.10.4
Re: [UST PATCH 1/2] Specialize lttng_ust_lib_ring_buffer_client_cb
In reply to a message not in the archiveQuoted 21 lines · * Julien Desfossez ([email protected]) wrote:
Prepare the ring-buffer config to have custom callbacks. These custom callbacks are not related to the ring-buffer operations but allow applications to add custom functions.
No additional feature or change in behaviour in this patch.Signed-off-by Julien Desfossez <[email protected]>--- include/lttng/ringbuffer-config.h | 4 +++- include/lttng/ust-events.h | 6 ++--- liblttng-ust/Makefile.am | 1 + liblttng-ust/lttng-rb-clients.h | 26 ++++++++++++++++++++++ liblttng-ust/lttng-ring-buffer-client.h | 18 ++++++++++++++- liblttng-ust/lttng-ring-buffer-metadata-client.h | 18 ++++++++++++++- 6 files changed, 67 insertions(+), 6 deletions(-) create mode 100644 liblttng-ust/lttng-rb-clients.hinclude/lttng/ringbuffer-config.h +0
-0
include/lttng/ringbuffer-config.h struct lttng_ust_lib_ring_buffer_client_cb { · line 135
Quoted 3 lines
include/lttng/ringbuffer-config.h +0
-0@@ -133,7 +133,8 @@ struct lttng_ust_lib_ring_buffer_client_cb {* RING_BUFFER_WAKEUP_NONE does not perform any wakeup whatsoever. The client * has the responsibility to perform wakeups. */
just to be on the safe side (this structure is not packed):
include/lttng/ringbuffer-config.h struct lttng_ust_lib_ring_buffer_client_cb { · line 138
Quoted 4 lines
include/lttng/ringbuffer-config.h +2
-1-#define LTTNG_UST_RING_BUFFER_CONFIG_PADDING 32 +#define LTTNG_UST_RING_BUFFER_CONFIG_PADDING \ + (32 - sizeof(const struct lttng_ust_lib_ring_buffer_client_cb *))
#define LTTNG_UST_RING_BUFFER_CONFIG_PADDING 20
(32 - 4 - 8, worse case)
include/lttng/ringbuffer-config.h struct lttng_ust_lib_ring_buffer_config { · line 207
Quoted 6 lines
include/lttng/ringbuffer-config.h +0
-0enum lttng_ust_lib_ring_buffer_alloc_types {RING_BUFFER_ALLOC_PER_CPU ,@@ -204,6 +205,7 @@ struct lttng_ust_lib_ring_buffer_config {* callbacks and update the cb pointers. */ int client_type;
int _unused1;
(because int client_type has a structure that contains pointers, so we'll have padding added on 64-bit archs) It's better to explicitly enforce the padding. (yes, this should have been packed form the start. Too late.)
Thanks,
Mathieu
Quoted 158 lines
include/lttng/ringbuffer-config.h +1
-0+const struct lttng_ust_lib_ring_buffer_client_cb *cb_ptr;char padding[LTTNG_UST_RING_BUFFER_CONFIG_PADDING ]; };include/lttng/ust-events.h +3
-3@@ -569,9 +569,9 @@ int lttng_add_ip_to_ctx(struct lttng_ctx **ctx);void lttng_context_vtid_reset (void );void lttng_context_vpid_reset (void ); -extern const struct lttng_ust_lib_ring_buffer_client_cb *lttng_client_callbacks_metadata; -extern const struct lttng_ust_lib_ring_buffer_client_cb *lttng_client_callbacks_discard; -extern const struct lttng_ust_lib_ring_buffer_client_cb *lttng_client_callbacks_overwrite; +extern const struct lttng_ust_client_lib_ring_buffer_client_cb *lttng_client_callbacks_metadata; +extern const struct lttng_ust_client_lib_ring_buffer_client_cb *lttng_client_callbacks_discard; +extern const struct lttng_ust_client_lib_ring_buffer_client_cb *lttng_client_callbacks_overwrite;struct lttng_transport *lttng_transport_find (const char *name);liblttng-ust/Makefile.am +1
-0@@ -47,6 +47,7 @@ liblttng_ust_support_la_SOURCES = \ lttng-tracer.h \ lttng-tracer-core.h \ ust-core.c \ + lttng-rb-clients.h \ lttng-ring-buffer-client.h \ lttng-ring-buffer-client-discard.c \ lttng-ring-buffer-client-discard-rt.c \liblttng-ust/lttng-rb-clients.h new file +26
-0@@ -0,0 +1,26 @@ +#ifndef _LTTNG_RB_CLIENT_H +#define _LTTNG_RB_CLIENT_H + +/* +* Copyright (c) 2013 - Mathieu Desnoyers <[email protected]> +* +* This library is free software; you can redistribute it and/or +* modify it under the terms of the GNU Lesser General Public +* License as published by the Free Software Foundation; only +* version 2.1 of the License. +* +* This library is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +* Lesser General Public License for more details. +* +* You should have received a copy of the GNU Lesser General Public +* License along with this library; if not, write to the Free Software +* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +*/ + +struct lttng_ust_client_lib_ring_buffer_client_cb { +struct lttng_ust_lib_ring_buffer_client_cb parent; +}; + +#endif /* _LTTNG_RB_CLIENT_H */ liblttng-ust/lttng-ring-buffer-client.h +17
-1@@ -161,6 +161,7 @@ unsigned char record_header_size(const struct lttng_ust_lib_ring_buffer_config * }#include "../libringbuffer/api.h" +#include "lttng-rb-clients.h" static void lttng_write_event_header_slow(const struct lttng_ust_lib_ring_buffer_config *config,@@ -385,6 +386,19 @@ static void client_buffer_finalize(struct lttng_ust_lib_ring_buffer *buf, void * { } +static const +struct lttng_ust_client_lib_ring_buffer_client_cb client_cb = { + .parent = { + .ring_buffer_clock_read = client_ring_buffer_clock_read, + .record_header_size = client_record_header_size, + .subbuffer_header_size = client_packet_header_size, + .buffer_begin = client_buffer_begin, + .buffer_end = client_buffer_end, + .buffer_create = client_buffer_create, + .buffer_finalize = client_buffer_finalize, + }, +}; +static const struct lttng_ust_lib_ring_buffer_config client_config = { .cb.ring_buffer_clock_read = client_ring_buffer_clock_read, .cb.record_header_size = client_record_header_size,@@ -404,9 +418,11 @@ static const struct lttng_ust_lib_ring_buffer_config client_config = { .ipi = RING_BUFFER_NO_IPI_BARRIER, .wakeup = LTTNG_CLIENT_WAKEUP, .client_type = LTTNG_CLIENT_TYPE, + + .cb_ptr = &client_cb.parent, }; -const struct lttng_ust_lib_ring_buffer_client_cb *LTTNG_CLIENT_CALLBACKS = &client_config.cb; +const struct lttng_ust_client_lib_ring_buffer_client_cb *LTTNG_CLIENT_CALLBACKS = &client_cb;static struct lttng_channel *_channel_create(const char *name,liblttng-ust/lttng-ring-buffer-metadata-client.h +17
-1@@ -61,6 +61,7 @@ unsigned char record_header_size(const struct lttng_ust_lib_ring_buffer_config * }#include "../libringbuffer/api.h" +#include "lttng-rb-clients.h" static uint64_t client_ring_buffer_clock_read (struct channel *chan) {@@ -153,6 +154,19 @@ static void client_buffer_finalize(struct lttng_ust_lib_ring_buffer *buf, { } +static const +struct lttng_ust_client_lib_ring_buffer_client_cb client_cb = { + .parent = { + .ring_buffer_clock_read = client_ring_buffer_clock_read, + .record_header_size = client_record_header_size, + .subbuffer_header_size = client_packet_header_size, + .buffer_begin = client_buffer_begin, + .buffer_end = client_buffer_end, + .buffer_create = client_buffer_create, + .buffer_finalize = client_buffer_finalize, + }, +}; +static const struct lttng_ust_lib_ring_buffer_config client_config = { .cb.ring_buffer_clock_read = client_ring_buffer_clock_read, .cb.record_header_size = client_record_header_size,@@ -172,9 +186,11 @@ static const struct lttng_ust_lib_ring_buffer_config client_config = { .ipi = RING_BUFFER_NO_IPI_BARRIER, .wakeup = RING_BUFFER_WAKEUP_BY_WRITER, .client_type = LTTNG_CLIENT_TYPE, + + .cb_ptr = &client_cb.parent, }; -const struct lttng_ust_lib_ring_buffer_client_cb *LTTNG_CLIENT_CALLBACKS = &client_config.cb; +const struct lttng_ust_client_lib_ring_buffer_client_cb *LTTNG_CLIENT_CALLBACKS = &client_cb;static struct lttng_channel *_channel_create(const char *name,Signature · 1 line
1.7.10.4
Signature · 3 lines
Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 8 lines · * Julien Desfossez ([email protected]) wrote:
These new calls export the data required for the consumer to generate the index while tracing :
- timestamp begin
- timestamp end
- events discarded
- context size
- packet size
- stream id
technically good. A few style "nits" below.
Quoted 49 lines
Signed-off-by Julien Desfossez <[email protected]>--- include/lttng/ust-ctl.h | 14 ++++ liblttng-ust-ctl/ustctl.c | 125 +++++++++++++++++++++++++++++++ liblttng-ust/lttng-rb-clients.h | 19 +++++ liblttng-ust/lttng-ring-buffer-client.h | 91 ++++++++++++++++++++++ 4 files changed, 249 insertions(+)include/lttng/ust-ctl.h +14
-0@@ -220,6 +220,20 @@ int ustctl_put_subbuf(struct ustctl_consumer_stream *stream);void ustctl_flush_buffer (struct ustctl_consumer_stream *stream,int producer_active); +/* index */ +int ustctl_get_timestamp_begin (struct ustctl_consumer_stream *stream, +uint64_t *timestamp_begin); +int ustctl_get_timestamp_end (struct ustctl_consumer_stream *stream, +uint64_t *timestamp_end); +int ustctl_get_events_discarded (struct ustctl_consumer_stream *stream, +uint64_t *events_discarded); +int ustctl_get_content_size (struct ustctl_consumer_stream *stream, +uint64_t *content_size); +int ustctl_get_packet_size (struct ustctl_consumer_stream *stream, +uint64_t *packet_size); +int ustctl_get_stream_id (struct ustctl_consumer_stream *stream, +uint64_t *stream_id); +/* event registry management */ enum ustctl_socket_type {liblttng-ust-ctl/ustctl.c +1
-0@@ -31,6 +31,7 @@#include "../libringbuffer/backend.h" #include "../libringbuffer/frontend.h" #include "../liblttng-ust/wait.h" +#include "../liblttng-ust/lttng-rb-clients.h" /* * Number of milliseconds to retry before failing metadata writes on @@ -1461,6 +1462,130 @@ void ustctl_flush_buffer(struct ustctl_consumer_stream *stream, consumer_chan->chan->handle); }
liblttng-ust-ctl/ustctl.c void ustctl_flush_buffer(struct ustctl_consumer_stream *stream, · line 1473
Quoted 10 lines
liblttng-ust-ctl/ustctl.c +9
-0+static +struct lttng_ust_client_lib_ring_buffer_client_cb *get_client_cb ( +struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle) +{ +struct channel *chan; +const struct lttng_ust_lib_ring_buffer_config *config; +struct lttng_ust_client_lib_ring_buffer_client_cb *client_cb; +
I'm tempted to just keep the empty line between declarations and code, and remove other empty lines.
Quoted 10 lines
liblttng-ust-ctl/ustctl.c +10
-0+ chan =shmp (handle, buf->backend.chan); + config = &chan->backend.config; + +if (!config->cb_ptr) +return NULL ; + + client_cb =caa_container_of (config->cb_ptr, + struct lttng_ust_client_lib_ring_buffer_client_cb, + parent); +
liblttng-ust-ctl/ustctl.c void ustctl_flush_buffer(struct ustctl_consumer_stream *stream, · line 1493
Quoted 10 lines
liblttng-ust-ctl/ustctl.c +10
-0+return client_cb; +} + +int ustctl_get_timestamp_begin (struct ustctl_consumer_stream *stream, +uint64_t *timestamp_begin) +{ +struct lttng_ust_client_lib_ring_buffer_client_cb *client_cb; +struct lttng_ust_lib_ring_buffer *buf = stream->buf; +struct lttng_ust_shm_handle *handle = stream->chan->chan->handle; +
here too. (and others below)
Quoted 135 lines
liblttng-ust-ctl/ustctl.c +95
-0+if (!stream || !timestamp_begin) +return -EINVAL ; + + client_cb =get_client_cb (buf, handle); +if (!client_cb) +return -ENOSYS ; + +return client_cb->timestamp_begin (buf, handle, timestamp_begin); +} + +int ustctl_get_timestamp_end (struct ustctl_consumer_stream *stream, +uint64_t *timestamp_end) +{ +struct lttng_ust_client_lib_ring_buffer_client_cb *client_cb; +struct lttng_ust_lib_ring_buffer *buf = stream->buf; +struct lttng_ust_shm_handle *handle = stream->chan->chan->handle; + +if (!stream || !timestamp_end) +return -EINVAL ; + + client_cb =get_client_cb (buf, handle); +if (!client_cb) +return -ENOSYS ; + +return client_cb->timestamp_end (buf, handle, timestamp_end); +} + +int ustctl_get_events_discarded (struct ustctl_consumer_stream *stream, +uint64_t *events_discarded) +{ +struct lttng_ust_client_lib_ring_buffer_client_cb *client_cb; +struct lttng_ust_lib_ring_buffer *buf = stream->buf; +struct lttng_ust_shm_handle *handle = stream->chan->chan->handle; + +if (!stream || !events_discarded) +return -EINVAL ; + + client_cb =get_client_cb (buf, handle); +if (!client_cb) +return -ENOSYS ; + +return client_cb->events_discarded (buf, handle, events_discarded); +} + +int ustctl_get_content_size (struct ustctl_consumer_stream *stream, +uint64_t *content_size) +{ +struct lttng_ust_client_lib_ring_buffer_client_cb *client_cb; +struct lttng_ust_lib_ring_buffer *buf = stream->buf; +struct lttng_ust_shm_handle *handle = stream->chan->chan->handle; + +if (!stream || !content_size) +return -EINVAL ; + + client_cb =get_client_cb (buf, handle); +if (!client_cb) +return -ENOSYS ; + +return client_cb->content_size (buf, handle, content_size); +} + +int ustctl_get_packet_size (struct ustctl_consumer_stream *stream, +uint64_t *packet_size) +{ +struct lttng_ust_client_lib_ring_buffer_client_cb *client_cb; +struct lttng_ust_lib_ring_buffer *buf = stream->buf; +struct lttng_ust_shm_handle *handle = stream->chan->chan->handle; + +if (!stream || !packet_size) +return -EINVAL ; + + client_cb =get_client_cb (buf, handle); +if (!client_cb) +return -ENOSYS ; + +return client_cb->packet_size (buf, handle, packet_size); +} + +int ustctl_get_stream_id (struct ustctl_consumer_stream *stream, +uint64_t *stream_id) +{ +struct lttng_ust_client_lib_ring_buffer_client_cb *client_cb; +struct lttng_ust_lib_ring_buffer *buf = stream->buf; +struct lttng_ust_shm_handle *handle = stream->chan->chan->handle; + +if (!stream || !stream_id) +return -EINVAL ; + + client_cb =get_client_cb (buf, handle); +if (!client_cb) +return -ENOSYS ; + +return client_cb->stream_id (buf, handle, stream_id); +} +/* * Returns 0 on success, negative error value on error. */ liblttng-ust/lttng-rb-clients.h +19
-0@@ -21,6 +21,25 @@struct lttng_ust_client_lib_ring_buffer_client_cb {struct lttng_ust_lib_ring_buffer_client_cb parent; + +int (*timestamp_begin) (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *timestamp_begin); +int (*timestamp_end) (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *timestamp_end); +int (*events_discarded) (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *events_discarded); +int (*content_size) (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *content_size); +int (*packet_size) (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *packet_size); +int (*stream_id) (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *stream_id); };#endif /* _LTTNG_RB_CLIENT_H */ liblttng-ust/lttng-ring-buffer-client.h +0
-0@@ -386,6 +386,91 @@ static void client_buffer_finalize(struct lttng_ust_lib_ring_buffer *buf, void * { }
liblttng-ust/lttng-ring-buffer-client.h static void client_buffer_finalize(struct lttng_ust_lib_ring_buffer *buf, void * · line 397
Quoted 10 lines
liblttng-ust/lttng-ring-buffer-client.h +9
-0+static struct packet_header *client_packet_header (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle) +{ +struct channel *chan =shmp (handle, buf->backend.chan); +struct lttng_channel *lttng_chan =channel_get_private (chan); +unsigned long sb_index; +struct lttng_ust_lib_ring_buffer_backend *bufb; +struct packet_header *header; +
here too.
Quoted 7 lines
liblttng-ust/lttng-ring-buffer-client.h +7
-0+ bufb = &buf->backend; + sb_index =subbuffer_id_get_index (<tng_chan->chan->backend.config, + bufb->buf_rsb.id); + + header =lib_ring_buffer_offset_address (bufb, + sb_index * lttng_chan->chan->backend.subbuf_size, + handle);
liblttng-ust/lttng-ring-buffer-client.h static void client_buffer_finalize(struct lttng_ust_lib_ring_buffer *buf, void * · line 414
Quoted 10 lines
liblttng-ust/lttng-ring-buffer-client.h +10
-0+ +return header; +} + +static int client_timestamp_begin (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *timestamp_begin) +{ +struct packet_header *header =client_packet_header (buf, handle); +
here, I'm tempted to do the following:
struct packet_header *header;
header = client_packet_header(buf, handle);*timestamp_begin = header->ctx.timestamp_begin;
return 0;
I don't enforce it strictly anywhere, but it's good IMO not to put assignments on variable declarations when they are functions calls and can possibly have side effects. It's then clear to the eye what is declarations and what is "code".
So, e.g.:
int myvar = somefct();
-> ideally change into:
int myvar;
myvar = somefct();
However:
int myvar = 5;
is fine, because the assignment cannot possible have side-effects.
The same applies to other functions below.
Thanks,
Mathieu
Quoted 78 lines
liblttng-ust/lttng-ring-buffer-client.h +65
-0+ *timestamp_begin = header->ctx.timestamp_begin; + +return 0 ; +} + +static int client_timestamp_end (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *timestamp_end) +{ +struct packet_header *header =client_packet_header (buf, handle); + + *timestamp_end = header->ctx.timestamp_end; + +return 0 ; +} + +static int client_events_discarded (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *events_discarded) +{ +struct packet_header *header =client_packet_header (buf, handle); + + *events_discarded = header->ctx.events_discarded; + +return 0 ; +} + +static int client_content_size (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *content_size) +{ +struct packet_header *header =client_packet_header (buf, handle); + + *content_size = header->ctx.content_size; + +return 0 ; +} + +static int client_packet_size (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *packet_size) +{ +struct packet_header *header =client_packet_header (buf, handle); + + *packet_size = header->ctx.packet_size; + +return 0 ; +} + +static int client_stream_id (struct lttng_ust_lib_ring_buffer *buf, +struct lttng_ust_shm_handle *handle, +uint64_t *stream_id) +{ +struct packet_header *header =client_packet_header (buf, handle); + + *stream_id = header->stream_id; + +return 0 ; +}static const struct lttng_ust_client_lib_ring_buffer_client_cb client_cb = { .parent = {@@ -397,6 +482,12 @@ struct lttng_ust_client_lib_ring_buffer_client_cb client_cb = { .buffer_create = client_buffer_create, .buffer_finalize = client_buffer_finalize, }, + .timestamp_begin = client_timestamp_begin, + .timestamp_end = client_timestamp_end, + .events_discarded = client_events_discarded, + .content_size = client_content_size, + .packet_size = client_packet_size, + .stream_id = client_stream_id, };static const struct lttng_ust_lib_ring_buffer_config client_config = {Signature · 1 line
1.7.10.4
Signature · 3 lines
Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com