Skip to contentSkip to conversation

SDK_NAME: Change to include image name and machine.

PATCH Superseded Elizabeth Flanagan 3 participants 5 messages Aug 19, 2013 – Aug 20, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SDK_NAME: Change to include image name and machine.

[YOCTO #4618]

When building out multiple toolchains with the same target arch you can end up having toolchains with the same name. Making the naming a bit more granular by adding IMAGE_BASENAME and MACHINE to SDK_NAME

---
 meta-yocto/conf/distro/poky.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-yocto/conf/distro/poky.conf +1 -1
index 7be7d92..f0da032 100644
@@ -22,7 +22,7 @@ PREFERRED_VERSION_linux-yocto_qemumips ?= "3.8%"
 PREFERRED_VERSION_linux-yocto_qemumips64 ?= "3.8%"
 PREFERRED_VERSION_linux-yocto_qemuppc ?= "3.8%"
 
-SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${TARGET_ARCH}"
+SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${IMAGE_BASENAME}-${MACHINE}-${TARGET_ARCH}"
 SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
 
 EXTRAOPKGCONFIG = "poky-feed-config-opkg"
Signature · 1 line
1.8.1.2
#1 lore raw
Quoted 6 lines · Elizabeth Flanagan

[YOCTO #4618]

When building out multiple toolchains with the same target arch you can end up having toolchains with the same name. Making the naming a bit more granular by adding IMAGE_BASENAME and MACHINE to SDK_NAME

What about using TUNE_PKGARCH as oe-core does since 5a1f172d35be610688842a8a9a84f24edb9aeb51 ?

Quoted 26 lines
---
 meta-yocto/conf/distro/poky.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-yocto/conf/distro/poky.conf +1 -1
index 7be7d92..f0da032 100644
@@ -22,7 +22,7 @@ PREFERRED_VERSION_linux-yocto_qemumips ?= "3.8%"
 PREFERRED_VERSION_linux-yocto_qemumips64 ?= "3.8%"
 PREFERRED_VERSION_linux-yocto_qemuppc ?= "3.8%"
 
-SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${TARGET_ARCH}"
+SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${IMAGE_BASENAME}-${MACHINE}-${TARGET_ARCH}"
 SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
 
 EXTRAOPKGCONFIG = "poky-feed-config-opkg"
Signature · 6 lines
1.8.1.2

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
In reply to Elizabeth Flanagan
Quoted 17 lines · Elizabeth Flanagan

[YOCTO #4618]

When building out multiple toolchains with the same target arch you can end up having toolchains with the same name. Making the naming a bit more granular by adding IMAGE_BASENAME and MACHINE to SDK_NAME

---
 meta-yocto/conf/distro/poky.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-yocto/conf/distro/poky.conf +0 -0
index 7be7d92..f0da032 100644

meta-yocto/conf/distro/poky.conf PREFERRED_VERSION_linux-yocto_qemumips ?= "3.8%" · line 28

Quoted 8 lines
meta-yocto/conf/distro/poky.conf +1 -1
@@ -22,7 +22,7 @@ PREFERRED_VERSION_linux-yocto_qemumips ?= "3.8%"
 PREFERRED_VERSION_linux-yocto_qemumips64 ?= "3.8%"
 PREFERRED_VERSION_linux-yocto_qemuppc ?= "3.8%"
 
-SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${TARGET_ARCH}"
+SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${IMAGE_BASENAME}-${MACHINE}-${TARGET_ARCH}"
 SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
 
 EXTRAOPKGCONFIG = "poky-feed-config-opkg"

Are there differences in the SDK/ADT tarball between machines?

I appreciate its theoretically possible but in reality, they should be the same and if they're not we have various problems.

Cheers,

Richard

#3 lore raw

There apparently are differences caused by each machines tunings (for example, meta-fsl-arm's imx53qsb is armv7a-vfp-neon, whereas qemuarm is armv5te). With SDK_NAME as it is, you'd end up with two files that have the exact same name and toolchains builds that are different. Example. qemuarm's toolchain env setup should be named 'environment-setup-armv5te-poky-linux-gnueabi' but the toolchain I just downloaded from the last master build is 'environment-setup-armv7a-vfp-neon-poky-linux-gnueabi' because it's the toolchain from the meta-fsl-arm build. I'm not sure how deep the issues go outside of these relatively small naming issues. ccing: Yi Zhao as I'm sure he can tell us more.

I agree that TUNE_PKGARCH is probably a better solution than TARGET_ARCH but with how I'm generating toolchains now (bitbake core-image-sato -c populate_sdk) I can see a day when having the IMAGE_BASENAME included would be a very useful thing.

So, would anyone be opposed to:

SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${IMAGE_BASENAME}-${TUNE_PKGARCH}"

-b

Quoted 36 lines · Richard Purdie
Quoted 17 lines · Elizabeth Flanagan

[YOCTO #4618]

When building out multiple toolchains with the same target arch you can end up having toolchains with the same name. Making the naming a bit more granular by adding IMAGE_BASENAME and MACHINE to SDK_NAME

---
 meta-yocto/conf/distro/poky.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-yocto/conf/distro/poky.conf +0 -0
index 7be7d92..f0da032 100644

meta-yocto/conf/distro/poky.conf PREFERRED_VERSION_linux-yocto_qemumips ?= "3.8%" · line 28

Quoted 8 lines
meta-yocto/conf/distro/poky.conf +1 -1
@@ -22,7 +22,7 @@ PREFERRED_VERSION_linux-yocto_qemumips ?= "3.8%"
 PREFERRED_VERSION_linux-yocto_qemumips64 ?= "3.8%"
 PREFERRED_VERSION_linux-yocto_qemuppc ?= "3.8%"
 
-SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${TARGET_ARCH}"
+SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${IMAGE_BASENAME}-${MACHINE}-${TARGET_ARCH}"
 SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
 
 EXTRAOPKGCONFIG = "poky-feed-config-opkg"

Are there differences in the SDK/ADT tarball between machines?

I appreciate its theoretically possible but in reality, they should be the same and if they're not we have various problems.

Cheers,

Richard

Signature · 3 lines
Elizabeth Flanagan
Yocto Project
Build and Release
#4 lore raw
Quoted 12 lines · Elizabeth

There apparently are differences caused by each machines tunings (for example, meta-fsl-arm's imx53qsb is armv7a-vfp-neon, whereas qemuarm is armv5te). With SDK_NAME as it is, you'd end up with two files that have the exact same name and toolchains builds that are different. Example. qemuarm's toolchain env setup should be named 'environment-setup-armv5te-poky-linux-gnueabi' but the toolchain I just downloaded from the last master build is 'environment-setup-armv7a-vfp-neon-poky-linux-gnueabi' because it's the toolchain from the meta-fsl-arm build. I'm not sure how deep the issues go outside of these relatively small naming issues. ccing: Yi Zhao as I'm sure he can tell us more.

Quoted 8 lines

I agree that TUNE_PKGARCH is probably a better solution than TARGET_ARCH but with how I'm generating toolchains now (bitbake core-image-sato -c populate_sdk) I can see a day when having the IMAGE_BASENAME included would be a very useful thing.

So, would anyone be opposed to:

SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${IMAGE_BASENAME}-${TUNE_PKGARCH}"

Looks good to me, it was ${MACHINE} which worried me, TUNE_PKGARCH is the right thing.

We should also remove [nostamp] from any SDK/ADT bits where it remains.

Cheers,

Richard