Skip to contentSkip to conversation

stat: fix the wrong return code

PATCH In review Zhangle Yang 2 participants 2 messages Aug 22, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 stat: fix the wrong return code

After stat -h is executed, the return code is 1.
This patch changes it to 0.

---
 .../stat/stat-3.3/fix-error-return.patch           |   16 ++++++++++++++++
 meta/recipes-extended/stat/stat_3.3.bb             |    3 ++-
 2 files changed, 18 insertions(+), 1 deletions(-)
 create mode 100644 meta/recipes-extended/stat/stat-3.3/fix-error-return.patch
meta/recipes-extended/stat/stat-3.3/fix-error-return.patch new file +16 -0
new file mode 100644
index 0000000..032995d
@@ -0,0 +1,16 @@
+This patch fixies the wrong return code of stat -h.
+
+Upstream-Status: Pending
+Signed-off-by: Zhangle Yang <[email protected]>
+
+--- stat-3.3/stat.c.orig	2013-08-22 10:49:45.000000000 +0800
++++ stat-3.3/stat.c	2013-08-22 10:50:31.000000000 +0800
+@@ -845,7 +845,7 @@
+     fprintf(stderr, "\t\t%%S - Security ID in SE-Linux\n");
+     fprintf(stderr, "\t\t%%C - Security context in SE-Linux\n");
+     fprintf(stderr, "\t\t%%d - Free file nodes in file system\n");
+-    exit(1);
++    exit(0);
+ }
+   
+ 
meta/recipes-extended/stat/stat_3.3.bb +2 -1
index 73e0873..1131bdf 100644
@@ -8,7 +8,8 @@ BBCLASSEXTEND = "native"
 
 PR = "r0"
 
-SRC_URI = "ftp://metalab.unc.edu/pub/Linux/utils/file/stat-3.3.tar.gz"
+SRC_URI = "ftp://metalab.unc.edu/pub/Linux/utils/file/stat-3.3.tar.gz \
+           file://fix-error-return.patch"
 SRC_URI[md5sum] = "37e247e8e400ad9205f1b0500b728fd3"
 SRC_URI[sha256sum] = "7071f0384a423a938dd542c1f08547a02824f6359acd3ef3f944b2c4c2d1ee09"
 
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 2 lines · Zhangle Yang

After stat -h is executed, the return code is 1.
This patch changes it to 0.

aside from the patch. why don't we use stat from coreutils or busybox and drop maintaining this old version of stat. Are there some use cases where we don't have busy box or coreutils on box ?

Quoted 50 lines

---
.../stat/stat-3.3/fix-error-return.patch | 16 ++++++++++++++++
meta/recipes-extended/stat/stat_3.3.bb | 3 ++-

2 files changed, 18 insertions(+), 1 deletions(-)

create mode 100644 meta/recipes-extended/stat/stat-3.3/fix-error-return.patch

meta/recipes-extended/stat/stat-3.3/fix-error-return.patch new file +16 -0
new file mode 100644
index 0000000..032995d
@@ -0,0 +1,16 @@
+This patch fixies the wrong return code of stat -h.
+
+Upstream-Status: Pending
+Signed-off-by: Zhangle Yang <[email protected]>
+
+--- stat-3.3/stat.c.orig	2013-08-22 10:49:45.000000000 +0800
++++ stat-3.3/stat.c	2013-08-22 10:50:31.000000000 +0800
+@@ -845,7 +845,7 @@
+     fprintf(stderr, "\t\t%%S - Security ID in SE-Linux\n");
+     fprintf(stderr, "\t\t%%C - Security context in SE-Linux\n");
+     fprintf(stderr, "\t\t%%d - Free file nodes in file system\n");
+-    exit(1);
++    exit(0);
+ }
+   
+ 
meta/recipes-extended/stat/stat_3.3.bb +0 -0
index 73e0873..1131bdf 100644
@@ -8,7 +8,8 @@ BBCLASSEXTEND = "native"
 

PR = "r0"

meta/recipes-extended/stat/stat_3.3.bb +2 -1
-SRC_URI = "ftp://metalab.unc.edu/pub/Linux/utils/file/stat-3.3.tar.gz"
+SRC_URI = "ftp://metalab.unc.edu/pub/Linux/utils/file/stat-3.3.tar.gz \
+           file://fix-error-return.patch"

SRC_URI[md5sum] = "37e247e8e400ad9205f1b0500b728fd3"
SRC_URI[sha256sum] = "7071f0384a423a938dd542c1f08547a02824f6359acd3ef3f944b2c4c2d1ee09"

Signature · 6 lines
1.7.4.1

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core