Skip to contentSkip to conversation

drm/i915: ivb: fix typo in dp voltage swing reg val

PATCH Applied Imre Deak 3 participants 6 messages Aug 23, 2013

Subsystems (2)
lore
Share & tools
lore

Imre Deak

author
#0 lore raw

PATCH 1/1 drm/i915: ivb: fix typo in dp voltage swing reg val

Fix the typo introduced in

commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85

Author: Keith Packard <[email protected]>
Date:   Wed Nov 16 16:26:07 2011 -0800

drm/i915: Hook up Ivybridge eDP

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880

---
 drivers/gpu/drm/i915/i915_reg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +1 -1
index 2b96d6b..019fd1f 100644
@@ -4525,7 +4525,7 @@
 #define EDP_LINK_TRAIN_600MV_0DB_IVB		(0x30 <<22)
 #define EDP_LINK_TRAIN_600MV_3_5DB_IVB		(0x36 <<22)
 #define EDP_LINK_TRAIN_800MV_0DB_IVB		(0x38 <<22)
-#define EDP_LINK_TRAIN_800MV_3_5DB_IVB		(0x33 <<22)
+#define EDP_LINK_TRAIN_800MV_3_5DB_IVB		(0x3e <<22)
 
 /* legacy values */
 #define EDP_LINK_TRAIN_500MV_0DB_IVB		(0x00 <<22)
Signature · 1 line
1.8.3.2
Reviewed-by on v1 1/1
#1 lore raw

2013/8/23 Imre Deak <[email protected]>:

Quoted 11 lines

Fix the typo introduced in

commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85

Author: Keith Packard <[email protected]>
Date:   Wed Nov 16 16:26:07 2011 -0800

drm/i915: Hook up Ivybridge eDP

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880

Nice catch!

Quoted 24 lines
---
 drivers/gpu/drm/i915/i915_reg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +1 -2
index 2b96d6b..019fd1f 100644
@@ -4525,7 +4525,7 @@
 #define EDP_LINK_TRAIN_600MV_0DB_IVB           (0x30 <<22)
 #define EDP_LINK_TRAIN_600MV_3_5DB_IVB         (0x36 <<22)
 #define EDP_LINK_TRAIN_800MV_0DB_IVB           (0x38 <<22)
-#define EDP_LINK_TRAIN_800MV_3_5DB_IVB         (0x33 <<22)
+#define EDP_LINK_TRAIN_800MV_3_5DB_IVB         (0x3e <<22)
 
 /* legacy values */
 #define EDP_LINK_TRAIN_500MV_0DB_IVB           (0x00 <<22)
--

1.8.3.2

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 1 line
Paulo Zanoni
#2 lore raw
Quoted 9 lines · Paulo Zanoni

2013/8/23 Imre Deak <[email protected]>:

Quoted 8 lines

Fix the typo introduced in

commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85

Author: Keith Packard <[email protected]>
Date:   Wed Nov 16 16:26:07 2011 -0800

drm/i915: Hook up Ivybridge eDP

Quoted 7 lines
Quoted 3 lines

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880

Nice catch!

Queued for -next, thanks for the patch.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#3 lore raw
Quoted 14 lines · Daniel Vetter
Quoted 13 lines · Paulo Zanoni

2013/8/23 Imre Deak <[email protected]>:

Quoted 11 lines

Fix the typo introduced in

commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85

Author: Keith Packard <[email protected]>
Date:   Wed Nov 16 16:26:07 2011 -0800

drm/i915: Hook up Ivybridge eDP

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880

Quoted 5 lines
Quoted 3 lines

Nice catch!

Queued for -next, thanks for the patch.

Ok, dropped again since Paulo told me on irc that we fail link training without this and so this is a black screen fix and so should go to -fixes with cc: stable.

Grumpy maintainer note: Stuff like this _really_ must be part of the commit message. A headline of "fix typo in ..." plus no mention of any further impact than the fixed type for a black screen bug in the commit message is seriously misleading.

Also this should imo be caught in review (since Paulo obviously knew what's going on).

Please resend.

Thanks, Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
author
#4 lore raw

PATCH v2 1/1 drm/i915: ivb: fix typo in dp voltage swing reg val

In reply to Imre Deak

Fix the typo introduced in

commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85

Author: Keith Packard <[email protected]>
Date:   Wed Nov 16 16:26:07 2011 -0800

drm/i915: Hook up Ivybridge eDP

This fixes eDP link-training failures and cases where all voltage swing /pre-emphasis levels were tried and failed during clock recovery and - as a fallback - we go on to do channel equalization with the last voltage swing/pre-emphasis level which will succeed. Both issues can lead to a blank screen.

v2:
- improve commit message

CC: [email protected]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880

---
 drivers/gpu/drm/i915/i915_reg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +1 -1
index 2b96d6b..019fd1f 100644
@@ -4525,7 +4525,7 @@
 #define EDP_LINK_TRAIN_600MV_0DB_IVB		(0x30 <<22)
 #define EDP_LINK_TRAIN_600MV_3_5DB_IVB		(0x36 <<22)
 #define EDP_LINK_TRAIN_800MV_0DB_IVB		(0x38 <<22)
-#define EDP_LINK_TRAIN_800MV_3_5DB_IVB		(0x33 <<22)
+#define EDP_LINK_TRAIN_800MV_3_5DB_IVB		(0x3e <<22)
 
 /* legacy values */
 #define EDP_LINK_TRAIN_500MV_0DB_IVB		(0x00 <<22)
Signature · 1 line
1.8.3.2
#5 lore raw
Quoted 14 lines · Imre Deak

Fix the typo introduced in

commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85

Author: Keith Packard <[email protected]>
Date:   Wed Nov 16 16:26:07 2011 -0800

drm/i915: Hook up Ivybridge eDP

This fixes eDP link-training failures and cases where all voltage swing /pre-emphasis levels were tried and failed during clock recovery and - as a fallback - we go on to do channel equalization with the last voltage swing/pre-emphasis level which will succeed. Both issues can lead to a blank screen.

Quoted 7 lines

v2:
- improve commit message

CC: [email protected]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880

Picked up for -fixes, thanks for the patch. Although I've frobbed the commit message a bit more and dropped the "typo" part. Since patches with "typo" headlines really don't belong into post -rc6 pull requests ;-) -Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch