Skip to contentSkip to conversation

X86: MM: Add PAT Type write-through in combination with mtrr

PATCH New Andreas Werner 1 participant 1 message Aug 25, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 X86: MM: Add PAT Type write-through in combination with mtrr

This patch adds the Write-through memory type in combination with mtrr. If you call ioremap_cache to request cachable memory (write-back) the function tries to set the PAT to write-back only if the mtrr setting of the requested region is also marked as Write-Back.

If the mttr regions are marked e.g. as Write-through or with other types, the function will always return UC- memory.

If you check the Intel document " IA-32 SDM vol 3a table Effective Memory Type", there are many other combinations possible.

This patch will only add the following combination:
PAT=Write-Back + MTRR=Write-Through = Effective Memory of Write-Through

Tested on - Intel (R) Atom E680 (Tunnel Creek)
- Intel (R) Core(TM)2 Duo

---
 arch/x86/mm/pat.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
arch/x86/mm/pat.c +8 -3
index 6574388..9cfe107 100644
@@ -149,10 +149,15 @@ static unsigned long pat_x_mtrr_type(u64 start, u64 end, unsigned long req_type)
 		u8 mtrr_type;
 
 		mtrr_type = mtrr_type_lookup(start, end);
-		if (mtrr_type != MTRR_TYPE_WRBACK)
-			return _PAGE_CACHE_UC_MINUS;
 
-		return _PAGE_CACHE_WB;
+		switch (mtrr_type) {
+		case MTRR_TYPE_WRBACK:
+		case MTRR_TYPE_WRTHROUGH:
+		  return _PAGE_CACHE_WB;
+
+		default:
+		  return _PAGE_CACHE_UC_MINUS;
+		}
 	}
 
 	return req_type;
Signature · 1 line
1.8.3.4