pinctrl: tegra: Convert to devm_ioremap_resource

PATCH In review Axel Lin 3 participants 3 messages Aug 27, 2013 – Aug 28, 2013

Subsystems (2)

Tegra architecture support Pin control

lore

Share & tools

lore

Axel Lin

author

2013-08-27 01:07 UTC #0 lore raw

PATCH v2 1/1 pinctrl: tegra: Convert to devm_ioremap_resource

Using the new devm_ioremap_resource() we can greatly simplify resource handling.

Signed-off-by Axel Lin <[email protected]>

---
v2: add commit log.

 drivers/pinctrl/pinctrl-tegra.c | 22 +++-------------------
 1 file changed, 3 insertions(+), 19 deletions(-)

drivers/pinctrl/pinctrl-tegra.c +3 ~~-19~~

index 637bcd3..be7e900 100644
@@ -643,25 +643,9 @@ int tegra_pinctrl_probe(struct platform_device *pdev,
 
 	for (i = 0; i < pmx->nbanks; i++) {
 		res = platform_get_resource(pdev, IORESOURCE_MEM, i);
-		if (!res) {
-			dev_err(&pdev->dev, "Missing MEM resource\n");
-			return -ENODEV;
-		}
-
-		if (!devm_request_mem_region(&pdev->dev, res->start,
-					    resource_size(res),
-					    dev_name(&pdev->dev))) {
-			dev_err(&pdev->dev,
-				"Couldn't request MEM resource %d\n", i);
-			return -ENODEV;
-		}
-
-		pmx->regs[i] = devm_ioremap(&pdev->dev, res->start,
-					    resource_size(res));
-		if (!pmx->regs[i]) {
-			dev_err(&pdev->dev, "Couldn't ioremap regs %d\n", i);
-			return -ENODEV;
-		}
+		pmx->regs[i] = devm_ioremap_resource(&pdev->dev, res);
+		if (IS_ERR(pmx->regs[i]))
+			return PTR_ERR(pmx->regs[i]);
 	}
 
 	pmx->pctl = pinctrl_register(&tegra_pinctrl_desc, &pdev->dev, pmx);