Skip to contentSkip to conversation

xtensa: Fix broken allmodconfig build

PATCH In review Guenter Roeck 2 participants 4 messages Aug 28, 2013 – Sep 6, 2013 Tensilica Xtensa port (xtensa)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xtensa: Fix broken allmodconfig build

xtansa allmodbuild fails with:

arch/xtensa/kernel/xtensa_ksyms.c:129:1: error: '_mcount' undeclared here (not in a function) make[2]: *** [arch/xtensa/kernel/xtensa_ksyms.o] Error 1
make[1]: *** [arch/xtensa/kernel] Error 2

The breakage is due to commit 478ba61af (xtensa: add static function tracer support) which exports _mcount without declaring it.

---
 arch/xtensa/kernel/xtensa_ksyms.c |    1 +
 1 file changed, 1 insertion(+)
arch/xtensa/kernel/xtensa_ksyms.c +1 -0
index d8507f8..74a60c7 100644
@@ -25,6 +25,7 @@
 #include <asm/io.h>
 #include <asm/page.h>
 #include <asm/pgalloc.h>
+#include <asm/ftrace.h>
 #ifdef CONFIG_BLK_DEV_FD
 #include <asm/floppy.h>
 #endif
Signature · 1 line
1.7.9.7
#1 lore raw
Quoted 2 lines · Guenter Roeck

xtansa allmodbuild fails with:

Grmpf.

s/xtansa/xtensa

Guenter

Quoted 26 lines

arch/xtensa/kernel/xtensa_ksyms.c:129:1: error: '_mcount' undeclared here (not in a function) make[2]: *** [arch/xtensa/kernel/xtensa_ksyms.o] Error 1
make[1]: *** [arch/xtensa/kernel] Error 2

The breakage is due to commit 478ba61af (xtensa: add static function tracer support) which exports _mcount without declaring it.

---
  arch/xtensa/kernel/xtensa_ksyms.c |    1 +
  1 file changed, 1 insertion(+)
arch/xtensa/kernel/xtensa_ksyms.c +1 -0
index d8507f8..74a60c7 100644
@@ -25,6 +25,7 @@
  #include <asm/io.h>
  #include <asm/page.h>
  #include <asm/pgalloc.h>
+#include <asm/ftrace.h>
  #ifdef CONFIG_BLK_DEV_FD
  #include <asm/floppy.h>
  #endif
#2 lore raw
In reply to Guenter Roeck
Quoted 6 lines · Guenter Roeck

xtansa allmodbuild fails with:

arch/xtensa/kernel/xtensa_ksyms.c:129:1: error: '_mcount' undeclared here (not in a function) make[2]: *** [arch/xtensa/kernel/xtensa_ksyms.o] Error 1
make[1]: *** [arch/xtensa/kernel] Error 2

Quoted 6 lines

The breakage is due to commit 478ba61af (xtensa: add static function tracer support) which exports _mcount without declaring it.

---

Ping ... 3.11 now ships with xtensa allmodconfig broken, which is completely unnecessary.

Guenter

Quoted 16 lines
  arch/xtensa/kernel/xtensa_ksyms.c |    1 +
  1 file changed, 1 insertion(+)
arch/xtensa/kernel/xtensa_ksyms.c +1 -0
index d8507f8..74a60c7 100644
@@ -25,6 +25,7 @@
  #include <asm/io.h>
  #include <asm/page.h>
  #include <asm/pgalloc.h>
+#include <asm/ftrace.h>
  #ifdef CONFIG_BLK_DEV_FD
  #include <asm/floppy.h>
  #endif
maintainer
#3 lore raw

Hi Guenter,

Quoted 7 lines · Guenter Roeck
Quoted 6 lines · Guenter Roeck

xtansa allmodbuild fails with:

arch/xtensa/kernel/xtensa_ksyms.c:129:1: error: '_mcount' undeclared here (not in a function) make[2]: *** [arch/xtensa/kernel/xtensa_ksyms.o] Error 1
make[1]: *** [arch/xtensa/kernel] Error 2

Quoted 8 lines
Quoted 6 lines

The breakage is due to commit 478ba61af (xtensa: add static function tracer support) which exports _mcount without declaring it.

---

Ping ... 3.11 now ships with xtensa allmodconfig broken, which is completely unnecessary.

Sorry for the delay. I just added it to the xtensa for_next tree, and will push it upstream shortly.

Thanks,
-Chris