Skip to contentSkip to conversation

busybox: set default log buffer size to 64 at compile time

PATCH In review Paul Eggleton 2 participants 2 messages Aug 28, 2013

lore
Share & tools
lore

Paul Eggleton

author
#0 lore raw

PATCH 1/1 busybox: set default log buffer size to 64 at compile time

This provides a more reasonable log buffer size to avoid losing earlier events, and 64K is not a problem for modern systems. When the buffer is used on sysvinit-based systems, which it isn't by default, 64K is already the runtime default size unless /etc/syslog-startup.conf is modified or deleted, so this only really affects systems using systemd. This completely removes the need for the busybox bbappend in meta-oe.

Signed-off-by Paul Eggleton <[email protected]>
---
 meta/recipes-core/busybox/busybox-1.21.1/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/busybox/busybox-1.21.1/defconfig +1 -1
index bdfdadf..e287a0d 100644
@@ -1012,7 +1012,7 @@ CONFIG_FEATURE_SYSLOGD_DUP=y
 CONFIG_FEATURE_SYSLOGD_CFG=y
 CONFIG_FEATURE_SYSLOGD_READ_BUFFER_SIZE=256
 CONFIG_FEATURE_IPC_SYSLOG=y
-CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE=16
+CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE=64
 CONFIG_LOGREAD=y
 CONFIG_FEATURE_LOGREAD_REDUCED_LOCKING=y
 CONFIG_KLOGD=y
Signature · 1 line
1.8.1.2
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Paul Eggleton

This provides a more reasonable log buffer size to avoid losing earlier events, and 64K is not a problem for modern systems. When the buffer is used on sysvinit-based systems, which it isn't by default, 64K is already the runtime default size unless /etc/syslog-startup.conf is modified or deleted, so this only really affects systems using systemd. This completely removes the need for the busybox bbappend in meta-oe.

Signed-off-by Paul Eggleton <[email protected]>

Looks good.

Acked-by Khem Raj <[email protected]>
Quoted 24 lines

---
meta/recipes-core/busybox/busybox-1.21.1/defconfig | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/busybox/busybox-1.21.1/defconfig +0 -0
index bdfdadf..e287a0d 100644
@@ -1012,7 +1012,7 @@ CONFIG_FEATURE_SYSLOGD_DUP=y

CONFIG_FEATURE_SYSLOGD_CFG=y
CONFIG_FEATURE_SYSLOGD_READ_BUFFER_SIZE=256
CONFIG_FEATURE_IPC_SYSLOG=y

meta/recipes-core/busybox/busybox-1.21.1/defconfig +1 -1
-CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE=16
+CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE=64

CONFIG_LOGREAD=y
CONFIG_FEATURE_LOGREAD_REDUCED_LOCKING=y
CONFIG_KLOGD=y

Signature · 6 lines
1.8.1.2

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core