Skip to contentSkip to conversation

qemu: add recommend of kernel-modules for all qemu machines

PATCH In review Ross Burton 5 participants 10 messages Sep 4, 2013 – Sep 5, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu: add recommend of kernel-modules for all qemu machines

Only qemumips was recommending kernel-modules which meant that the other qemu machines were missing some kernel modules, for example binfmt-misc.

Move the recommends to qemu.inc so that all qemu machines pull in the kernel modules that have been built.

[ YOCTO #4863 ]

---
 meta/conf/machine/include/qemu.inc |    2 ++
 meta/conf/machine/qemumips.conf    |    2 --
 meta/conf/machine/qemumips64.conf  |    2 --
 3 files changed, 2 insertions(+), 4 deletions(-)
meta/conf/machine/include/qemu.inc +2 -0
index 545f8d1..7baf13e 100644
@@ -27,3 +27,5 @@ EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
 
 # Provide the nfs server kernel module for all qemu images
 KERNEL_FEATURES_append_pn-linux-yocto = " features/nfsd/nfsd-enable.scc"
+
+MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
meta/conf/machine/qemumips.conf +0 -2
index ce1c419..89721a6 100644
@@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
 SERIAL_CONSOLE = "115200 ttyS0"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
meta/conf/machine/qemumips64.conf +0 -2
index b2c7998..7ba98cb 100644
@@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
 SERIAL_CONSOLE = "115200 ttyS0"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 6 lines · Ross Burton

Only qemumips was recommending kernel-modules which meant that the other qemu machines were missing some kernel modules, for example binfmt-misc.

Move the recommends to qemu.inc so that all qemu machines pull in the kernel modules that have been built.

Quoted 8 lines

[ YOCTO #4863 ]

---
 meta/conf/machine/include/qemu.inc |    2 ++
 meta/conf/machine/qemumips.conf    |    2 --
 meta/conf/machine/qemumips64.conf  |    2 --
 3 files changed, 2 insertions(+), 4 deletions(-)

How many modules are built for the qemu machines? Are they all useful? I'm just trying to get a feel for how much we're adding here and whether this is the right thing to be doing...

Cheers,

Richard

Quoted 31 lines
meta/conf/machine/include/qemu.inc +2 -0
index 545f8d1..7baf13e 100644
@@ -27,3 +27,5 @@ EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
 
 # Provide the nfs server kernel module for all qemu images
 KERNEL_FEATURES_append_pn-linux-yocto = " features/nfsd/nfsd-enable.scc"
+
+MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
meta/conf/machine/qemumips.conf +0 -2
index ce1c419..89721a6 100644
@@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
 SERIAL_CONSOLE = "115200 ttyS0"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
meta/conf/machine/qemumips64.conf +0 -2
index b2c7998..7ba98cb 100644
@@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
 SERIAL_CONSOLE = "115200 ttyS0"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
#2 lore raw
Quoted 16 lines · Richard Purdie
Quoted 6 lines · Ross Burton

Only qemumips was recommending kernel-modules which meant that the other qemu machines were missing some kernel modules, for example binfmt-misc.

Move the recommends to qemu.inc so that all qemu machines pull in the kernel modules that have been built.

Quoted 8 lines

[ YOCTO #4863 ]

---
 meta/conf/machine/include/qemu.inc |    2 ++
 meta/conf/machine/qemumips.conf    |    2 --
 meta/conf/machine/qemumips64.conf  |    2 --
 3 files changed, 2 insertions(+), 4 deletions(-)
Quoted 3 lines

How many modules are built for the qemu machines? Are they all useful? I'm just trying to get a feel for how much we're adding here and whether this is the right thing to be doing...

We can control the configs as tightly as we want, so if we are building too much for this, I'm happy to trim things down.

Cheers,

Bruce

Quoted 44 lines

Cheers,

Richard

Quoted 26 lines
meta/conf/machine/include/qemu.inc +2 -0
index 545f8d1..7baf13e 100644
@@ -27,3 +27,5 @@ EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
 
 # Provide the nfs server kernel module for all qemu images
 KERNEL_FEATURES_append_pn-linux-yocto = " features/nfsd/nfsd-enable.scc"
+
+MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
meta/conf/machine/qemumips.conf +0 -2
index ce1c419..89721a6 100644
@@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
 SERIAL_CONSOLE = "115200 ttyS0"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
meta/conf/machine/qemumips64.conf +0 -0
index b2c7998..7ba98cb 100644

meta/conf/machine/qemumips64.conf KERNEL_IMAGETYPE = "vmlinux" · line 13

Quoted 5 lines
meta/conf/machine/qemumips64.conf +0 -2
@@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
 SERIAL_CONSOLE = "115200 ttyS0"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
#3 lore raw
Quoted 18 lines · Bruce Ashfield
Quoted 16 lines · Richard Purdie
Quoted 14 lines · Ross Burton

Only qemumips was recommending kernel-modules which meant that the other qemu machines were missing some kernel modules, for example binfmt-misc.

Move the recommends to qemu.inc so that all qemu machines pull in the kernel modules that have been built.

[ YOCTO #4863 ]

---
 meta/conf/machine/include/qemu.inc |    2 ++
 meta/conf/machine/qemumips.conf    |    2 --
 meta/conf/machine/qemumips64.conf  |    2 --
 3 files changed, 2 insertions(+), 4 deletions(-)
Quoted 6 lines
Quoted 3 lines

How many modules are built for the qemu machines? Are they all useful? I'm just trying to get a feel for how much we're adding here and whether this is the right thing to be doing...

We can control the configs as tightly as we want, so if we are building too much for this, I'm happy to trim things down.

I don't think this is right way to do it.

It's good to have as many optional modules available in feed (so to enable many modules in configs - you never know what obscure device someone will try to test with qemu and one more module and package in feed has smaller overhead then need to change configs) and install only important modules by default in every image.

Quoted 59 lines

Cheers,

Bruce

Quoted 44 lines

Cheers,

Richard

Quoted 26 lines
meta/conf/machine/include/qemu.inc +2 -0
index 545f8d1..7baf13e 100644
@@ -27,3 +27,5 @@ EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
 
 # Provide the nfs server kernel module for all qemu images
 KERNEL_FEATURES_append_pn-linux-yocto = " features/nfsd/nfsd-enable.scc"
+
+MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
meta/conf/machine/qemumips.conf +0 -2
index ce1c419..89721a6 100644
@@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
 SERIAL_CONSOLE = "115200 ttyS0"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
meta/conf/machine/qemumips64.conf +0 -0
index b2c7998..7ba98cb 100644

meta/conf/machine/qemumips64.conf KERNEL_IMAGETYPE = "vmlinux" · line 13

Quoted 5 lines
meta/conf/machine/qemumips64.conf +0 -2
@@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
 SERIAL_CONSOLE = "115200 ttyS0"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 6 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw
Quoted 7 lines · Martin Jansa

I don't think this is right way to do it.

It's good to have as many optional modules available in feed (so to enable many modules in configs - you never know what obscure device someone will try to test with qemu and one more module and package in feed has smaller overhead then need to change configs) and install only important modules by default in every image.

But isn't the range of devices supported on a particular qemu machine incredibly limited?

I've also decided that maybe systemd isn't being quite as clever as it should and maybe fixing it there is the real fix.

Ross

#5 lore raw
Quoted 2 lines · Ross

I've also decided that maybe systemd isn't being quite as clever as it should and maybe fixing it there is the real fix.

s/systemd/Linux/.

The bug is that doing a "df" on a qemu systemd image results in it attempting to automount /proc/sys/fs/binfmt_misc. The automount unit has ConditionPathExists=/proc/sys/fs/binfmt_misc/ to stop it attempting to automount when binfmt is disabled but hooray Linux if binfmt_misc is a module that directory exists even when the module isn't actually loaded, giving a no such device error when accessed. The intention here I believe is so that an access to that directory can invoke an automounter (systemd, in this case) which can then load the modules and mount the virtual filesystem.

There appear to be two options.

1) The QA scripts ignore any binfmt_misc unit mounts failing
2) systemd RRECOMMENDS kernel-module-binfmt-misc

(the third option of teaching systemd how to recognise this situation and refuse to start the unit appears impossible)

(CCing Stefan for his input)

To be honest I'm leaning towards (1) right now as binfmt_misc is only required in specific situations.

Ross

#6 lore raw
Quoted 16 lines · Ross
Quoted 2 lines · Ross

I've also decided that maybe systemd isn't being quite as clever as it should and maybe fixing it there is the real fix.

s/systemd/Linux/.

The bug is that doing a "df" on a qemu systemd image results in it attempting to automount /proc/sys/fs/binfmt_misc. The automount unit has ConditionPathExists=/proc/sys/fs/binfmt_misc/ to stop it attempting to automount when binfmt is disabled but hooray Linux if binfmt_misc is a module that directory exists even when the module isn't actually loaded, giving a no such device error when accessed. The intention here I believe is so that an access to that directory can invoke an automounter (systemd, in this case) which can then load the modules and mount the virtual filesystem.

Quoted 8 lines

There appear to be two options.

1) The QA scripts ignore any binfmt_misc unit mounts failing
2) systemd RRECOMMENDS kernel-module-binfmt-misc

(the third option of teaching systemd how to recognise this situation and refuse to start the unit appears impossible)

I honestly like second option more. And the third even better :) (sure changing the test to ignore binfmt_misc unit from systemctl --failed output can be easily done, but seems like just hiding the fail to me).

I just tested that the third option can be done (for this case at least) by changing ConditionPathExists=/proc/sys/fs/binfmt_misc/ to ConditionDirectoryNotEmpty=/proc/sys/fs/binfmt_misc/ for proc-sys-fs-binfmt_misc.automount unit file and
"df" doesn't complain as it doesn't attempt to automount anymore. On a system which does have that module loaded there are two files there so that's why the condition works.

Cheers,
Stefan

Quoted 6 lines

(CCing Stefan for his input)

To be honest I'm leaning towards (1) right now as binfmt_misc is only required in specific situations.

Ross

#7 lore raw
Quoted 7 lines · StefanX

I just tested that the third option can be done (for this case at least) by changing ConditionPathExists=/proc/sys/fs/binfmt_misc/ to ConditionDirectoryNotEmpty=/proc/sys/fs/binfmt_misc/ for proc-sys-fs-binfmt_misc.automount unit file and
"df" doesn't complain as it doesn't attempt to automount anymore. On a system which does have that module loaded there are two files there so that's why the condition works.

Confirmed, patch incoming.

Ross

#8 lore raw
Quoted 10 lines · Ross
Quoted 7 lines · StefanX

I just tested that the third option can be done (for this case at least) by changing ConditionPathExists=/proc/sys/fs/binfmt_misc/ to ConditionDirectoryNotEmpty=/proc/sys/fs/binfmt_misc/ for proc-sys-fs-binfmt_misc.automount unit file and
"df" doesn't complain as it doesn't attempt to automount anymore. On a system which does have that module loaded there are two files there so that's why the condition works.

Confirmed, patch incoming.

I take it back, this is wrong. When the module is available on disk but not yet loaded the binfmt_misc directory is empty, so this change means it shouldn't be automounting. It is, which is... interesting.

Ross

#9 lore raw
In reply to Martin Jansa
Quoted 26 lines · Martin Jansa
Quoted 18 lines · Bruce Ashfield
Quoted 16 lines · Richard Purdie
Quoted 14 lines · Ross Burton

Only qemumips was recommending kernel-modules which meant that the other qemu machines were missing some kernel modules, for example binfmt-misc.

Move the recommends to qemu.inc so that all qemu machines pull in the kernel modules that have been built.

[ YOCTO #4863 ]

---
 meta/conf/machine/include/qemu.inc |    2 ++
 meta/conf/machine/qemumips.conf    |    2 --
 meta/conf/machine/qemumips64.conf  |    2 --
 3 files changed, 2 insertions(+), 4 deletions(-)
Quoted 6 lines
Quoted 3 lines

How many modules are built for the qemu machines? Are they all useful? I'm just trying to get a feel for how much we're adding here and whether this is the right thing to be doing...

We can control the configs as tightly as we want, so if we are building too much for this, I'm happy to trim things down.

Quoted 7 lines

I don't think this is right way to do it.

It's good to have as many optional modules available in feed (so to enable many modules in configs - you never know what obscure device someone will try to test with qemu and one more module and package in feed has smaller overhead then need to change configs) and install only important modules by default in every image.

There's definite advantages to both, and I'm aware of preferences for and against, so there's a place for either model.

I'm targeting specific machines, with known good configurations and feature mixes. So getting the config right, and trusting that configuration is the route that I take, and then just install everything that is built. Rather than having the granularity and the need to depend on individual modules, which ends up tying all my layers, to a specific set of kernel options .. which that base BSP likes to be at liberty to change.

Having the options in the feed is nice, so somewhere in the middle would be my ideal :)

Cheers,

Bruce

Quoted 63 lines
Quoted 53 lines

Cheers,

Bruce

Quoted 35 lines

Cheers,

Richard

Quoted 28 lines
meta/conf/machine/include/qemu.inc +2 -0
index 545f8d1..7baf13e 100644
@@ -27,3 +27,5 @@ EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
 
 # Provide the nfs server kernel module for all qemu images
 KERNEL_FEATURES_append_pn-linux-yocto = " features/nfsd/nfsd-enable.scc"
+
+MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
meta/conf/machine/qemumips.conf +0 -2
index ce1c419..89721a6 100644
@@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
 SERIAL_CONSOLE = "115200 ttyS0"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
meta/conf/machine/qemumips64.conf +0 -0
index b2c7998..7ba98cb 100644
@@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
Quoted 9 lines

meta/conf/machine/qemumips64.conf KERNEL_IMAGETYPE = "vmlinux" · line 13

Quoted 3 lines
meta/conf/machine/qemumips64.conf +0 -2
 SERIAL_CONSOLE = "115200 ttyS0"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Quoted 7 lines

--
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
_______________________________________________
Openembedded-core mailing list [email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
Martin 'JaMa' Jansa jabber: [email protected]

Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"