Skip to contentSkip to conversation

bluez4/5: Add EXCLUDE_FROM_WORLD = 1

PATCH In review Saul Wold 3 participants 3 messages Sep 11, 2013 – Sep 12, 2013

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

PATCH 1/1 bluez4/5: Add EXCLUDE_FROM_WORLD = 1

We can't build both recipes in the world build as there is a collision of package name and PR values. Specificly the libasound-module-bluez which is the same in both goes backwards from r5 (bluez4) -> r0 (bluez5) and the subpackage_metadata check fails:

ERROR: Recipe lib32-bluez5 is trying to change PR from 'r0' to 'r5'. This will cause do_package_write_* failures since the incorrect data will be used and they will be unable to find the right workdir.

[YOCTO #5165]

---
 meta/recipes-connectivity/bluez/bluez4.inc  | 1 +
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
 2 files changed, 3 insertions(+)
meta/recipes-connectivity/bluez/bluez4.inc +1 -0
index b540622..e4f6834 100644
@@ -43,3 +43,4 @@ EXTRA_OECONF = "\
   --with-udevrulesdir=`pkg-config --variable=udevdir udev`/rules.d \
 "
 
+EXCLUDE_FROM_WORLD = "1"
meta/recipes-connectivity/bluez5/bluez5.inc +2 -0
index e5cb9e8..2e25d86 100644
@@ -82,3 +82,5 @@ FILES_${PN}-dbg += "\
 RDEPENDS_${PN}-testtools += "python python-dbus python-pygobject"
 
 SYSTEMD_SERVICE_${PN} = "bluetooth.service"
+
+EXCLUDE_FROM_WORLD = "1"
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 31 lines · On Wednesday 11 September 2013 14:38:01 Saul Wold wrote:

We can't build both recipes in the world build as there is a collision of package name and PR values. Specificly the libasound-module-bluez which is the same in both goes backwards from r5 (bluez4) -> r0 (bluez5) and the subpackage_metadata check fails:

ERROR: Recipe lib32-bluez5 is trying to change PR from 'r0' to 'r5'. This will cause do_package_write_* failures since the incorrect data will be used and they will be unable to find the right workdir.

[YOCTO #5165]

---
 meta/recipes-connectivity/bluez/bluez4.inc  | 1 +
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
 2 files changed, 3 insertions(+)
(quoted diff) +0 -0

b/meta/recipes-connectivity/bluez/bluez4.inc index b540622..e4f6834 100644

meta/recipes-connectivity/bluez/bluez4.inc +1 -0
@@ -43,3 +43,4 @@ EXTRA_OECONF = "\
   --with-udevrulesdir=`pkg-config --variable=udevdir udev`/rules.d \
 "
 
+EXCLUDE_FROM_WORLD = "1"
(quoted diff) +0 -0

b/meta/recipes-connectivity/bluez5/bluez5.inc index e5cb9e8..2e25d86 100644

meta/recipes-connectivity/bluez5/bluez5.inc FILES_${PN}-dbg += "\ · line 86

Quoted 5 lines
meta/recipes-connectivity/bluez5/bluez5.inc +2 -0
@@ -82,3 +82,5 @@ FILES_${PN}-dbg += "\
 RDEPENDS_${PN}-testtools += "python python-dbus python-pygobject"
 
 SYSTEMD_SERVICE_${PN} = "bluetooth.service"
+
+EXCLUDE_FROM_WORLD = "1"

Surely we don't need to exclude both from world, just one of them?

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#2 lore raw
Quoted 34 lines · Paul Eggleton
Quoted 33 lines · On Wednesday 11 September 2013 14:38:01 Saul Wold wrote:

We can't build both recipes in the world build as there is a collision of package name and PR values. Specificly the libasound-module-bluez which is the same in both goes backwards from r5 (bluez4) -> r0 (bluez5) and the subpackage_metadata check fails:

ERROR: Recipe lib32-bluez5 is trying to change PR from 'r0' to 'r5'. This will cause do_package_write_* failures since the incorrect data will be used and they will be unable to find the right workdir.

[YOCTO #5165]

---
 meta/recipes-connectivity/bluez/bluez4.inc  | 1 +
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
 2 files changed, 3 insertions(+)
(quoted diff) +0 -0

b/meta/recipes-connectivity/bluez/bluez4.inc index b540622..e4f6834 100644

meta/recipes-connectivity/bluez/bluez4.inc +1 -0
@@ -43,3 +43,4 @@ EXTRA_OECONF = "\
   --with-udevrulesdir=`pkg-config --variable=udevdir udev`/rules.d \
 "
 
+EXCLUDE_FROM_WORLD = "1"
(quoted diff) +0 -0

b/meta/recipes-connectivity/bluez5/bluez5.inc index e5cb9e8..2e25d86 100644

meta/recipes-connectivity/bluez5/bluez5.inc +0 -0
@@ -82,3 +82,5 @@ FILES_${PN}-dbg += "\
 RDEPENDS_${PN}-testtools += "python python-dbus python-pygobject"
 
Quoted 5 lines

meta/recipes-connectivity/bluez5/bluez5.inc FILES_${PN}-dbg += "\ · line 86

Quoted 3 lines
meta/recipes-connectivity/bluez5/bluez5.inc +2 -0
 SYSTEMD_SERVICE_${PN} = "bluetooth.service"
+
+EXCLUDE_FROM_WORLD = "1"

Surely we don't need to exclude both from world, just one of them?

This way the right one gets selected by the dependency trees. If you do it the other way, we'd have to revisit the problem and anyone choosing an alternative would possibly end up with build issues.

Cheers,

Richard