Time: Clocksource: fix 'ret' data type of sysfs_override_clocksource() and sysfs_unbind_clocksource()
PATCH 1/1 Time: Clocksource: fix 'ret' data type of sysfs_override_clocksource() and sysfs_unbind_clocksource()
From: Elad Wexler <[email protected]>
sysfs_override_clocksource(): The expression 'if (ret >= 0)' is always true. This will cause clocksource_select() to always run.
Thus modified ret to be of type ssize_t.
sysfs_unbind_clocksource(): The expression 'if (ret < 0)' is always false. So in case sysfs_get_uname() failed, the expression won't take an effect. Thus modified ret to be of type ssize_t.
--- kernel/time/clocksource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/time/clocksource.c +2 -2
@@ -924,7 +924,7 @@ static ssize_t sysfs_override_clocksource(struct device *dev,struct device_attribute *attr, const char *buf, size_t count) { - size_t ret; + ssize_t ret;mutex_lock (&clocksource_mutex);
@@ -952,7 +952,7 @@ static ssize_t sysfs_unbind_clocksource(struct device *dev, {struct clocksource *cs;char name[CS_NAME_LEN ]; -size_t ret; +ssize_t ret; ret =sysfs_get_uname (buf, name, count);if (ret <0 )
Signature · 1 line
1.8.3.1
Quoted 11 lines · On 09/12/2013 03:28 AM, [email protected] wrote:
From: Elad Wexler <[email protected]>
sysfs_override_clocksource(): The expression 'if (ret >= 0)' is always true. This will causeclocksource_select()to always run.
Thus modified ret to be of typessize_t.
sysfs_unbind_clocksource(): The expression 'if (ret < 0)' is always false. So in casesysfs_get_uname()failed, the expression won't take an effect. Thus modified ret to be of typessize_t.Signed-off-by Elad Wexler <[email protected]>
Queued for 3.13.
thanks
-john