Skip to contentSkip to conversation

ehci-dbgp: drop dead code.

PATCH New Tim Deegan 1 participant 1 message Sep 12, 2013 USB

lore
Share & tools
lore

Tim Deegan

author
#0 lore raw

PATCH 1/1 ehci-dbgp: drop dead code.

We can only reach this spot by breaking out of the scan loop, so by construction ret > 0.

Found by Coverity, in a copy of this file in the Xen sources.

---
 drivers/usb/early/ehci-dbgp.c |    4 ----
 1 file changed, 4 deletions(-)
drivers/usb/early/ehci-dbgp.c +0 -4
index 5e29dde..8cfc319 100644
@@ -568,10 +568,6 @@ try_again:
 		dbgp_printk("Could not find attached debug device\n");
 		goto err;
 	}
-	if (ret < 0) {
-		dbgp_printk("Attached device is not a debug device\n");
-		goto err;
-	}
 	dbgp_endpoint_out = dbgp_desc.bDebugOutEndpoint;
 	dbgp_endpoint_in = dbgp_desc.bDebugInEndpoint;
 
Signature · 1 line
1.7.10.4