linux-libc-headers: Add big warning about antisocial behaviour
PATCH 1/1 linux-libc-headers: Add big warning about antisocial behaviour
I'm getting concerned with the number of people forking this recipe and not understanding what they're doing. I'm therefore proposing adding in a suitable warning to people thinking of copying it.
---
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +22 -0
@@ -2,6 +2,28 @@ DESCRIPTION = "Sanitized set of kernel headers for the C library's use." SECTION = "devel" LICENSE = "GPLv2" +######################################################################### +#### PLEASE READ +######################################################################### +# +# You're probably looking here thinking you need to create some new copy +# of linux-libc-headers since you have your own custom kernel. To put +# this simply, you DO NOT. +# +# Why? These headers are used to build the libc. If you customise the +# headers you are customising the libc and the libc becomes machine +# specific. Most people do not add custom libc extensions to the kernel +# and have a machine specific libc. +# +# But you have some kernel headers you need for some driver? That is fine +# but get them from STAGING_KERNEL_DIR where the kernel installs itself. +# This will make the package using them machine specific but this is much +# better than having a maching specific C library. This does mean your +# recipe needs a DEPENDS += "virtual/kernel" but again, that is fine and +# makes total sense. +# +# -- RP + LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" python __anonymous () {
Quoted 28 lines · Richard Purdie
I'm getting concerned with the number of people forking this recipe and not understanding what they're doing. I'm therefore proposing adding in a suitable warning to people thinking of copying it.
Signed-off-by Richard Purdie <[email protected]<javascript:;>Quoted 1 line
---
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +0
-0@@ -2,6 +2,28 @@ DESCRIPTION = "Sanitized set of kernel headers for the Clibrary's use."
SECTION = "devel"
LICENSE = "GPLv2"meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +11
-0+######################################################################### +#### PLEASE READ +######################################################################### +# +# You're probably looking here thinking you need to create some new copy +# of linux-libc-headers since you have your own custom kernel. To put +# this simply, you DO NOT. +# +# Why? These headers are used to build the libc. If you customise the +# headers you are customising the libc and the libc becomes machine +# specific. Most people do not add custom libc extensions to the kernel
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc DESCRIPTION = "Sanitized set of kernel headers for the C library's use." · line 25
Quoted 10 lines
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +10
-0+# and have a machine specific libc. +# +# But you have some kernel headers you need for some driver? That is fine +# but get them from STAGING_KERNEL_DIR where the kernel installs itself. +# This will make the package using them machine specific but this is much +# better than having a maching specific C library. This does mean your +# recipe needs a DEPENDS += "virtual/kernel" but again, that is fine and +# makes total sense. +# +# -- RP
There are cases where we have bsps with 2.6.3x kernels and libc compiled against 3.10 assumes syscalls
Which the kernel will not provide. These kinds are genuine cases for creating equivalent recipes
You should mention the valid case too in this notice and basically asses the user is knowing what. He is doing
+
Quoted 10 lines
LIC_FILES_CHKSUM= "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"python
__anonymous() {_______________________________________________
Openembedded-core mailing list [email protected] <javascript:;>
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 2 lines · Khem Raj
There are cases where we have bsps with 2.6.3x kernels and libc compiled against 3.10 assumes syscalls
That is a bug in glibc. It should not be doing that unless configured --enable-kernel=3.10.x (and this is the whole point of the --enable-kernel option). If it's assuming 3.10.x syscalls under --enable-kernel=2.6.x then it is broken and should be fixed.
p.
Quoted 5 lines · Richard Purdie
I'm getting concerned with the number of people forking this recipe and not understanding what they're doing. I'm therefore proposing adding in a suitable warning to people thinking of copying it.
Signed-off-by Richard Purdie <[email protected]>
Signature · 2 lines
Anders Darander ChargeStorm AB / eStorm AB
Quoted 41 lines · Khem Raj
On Friday, September 13, 2013, Richard Purdie wrote:
I'm getting concerned with the number of people forking this recipe and not understanding what they're doing. I'm therefore proposing adding in a suitable warning to people thinking of copying it.
Signed-off-by Richard Purdie <[email protected]>---
diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc index 96fe2ff..79b7dc4 100644
--- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc @@ -2,6 +2,28 @@ DESCRIPTION = "Sanitized set of kernel headers for the C library's use."
SECTION = "devel"
LICENSE = "GPLv2"+#########################################################################
+#### PLEASE READ
+#########################################################################
+#
+# You're probably looking here thinking you need to create some new copy +# of linux-libc-headers since you have your own custom kernel. To put +# this simply, you DO NOT.
+#
+# Why? These headers are used to build the libc. If you customise the +# headers you are customising the libc and the libc becomes machine +# specific. Most people do not add custom libc extensions to the kernel +# and have a machine specific libc.
+#
+# But you have some kernel headers you need for some driver? That is fine +# but get them fromSTAGING_KERNEL_DIRwhere the kernel installs itself. +# This will make the package using them machine specific but this is much +# better than having a maching specific C library. This does mean your +# recipe needs a DEPENDS += "virtual/kernel" but again, that is fine and +# makes total sense.
+#
+# -- RP
Quoted 6 lines
There are cases where we have bsps with 2.6.3x kernels and libc compiled against 3.10 assumes syscalls
Which the kernel will not provide. These kinds are genuine cases for creating equivalent recipes
You should mention the valid case too in this notice and basically asses the user is knowing what. He is doing
I'd be inclined to say that anyone working on / adding a bsp that needs this, will (hopefully) understand this anyway. If you know that 3.x-based kernel headers aren't working, you're going to add a patched linux-libc-headers regardless of the warning above.
Cheers,
Ander
Signature · 2 lines
Anders Darander ChargeStorm AB / eStorm AB
Quoted 4 lines · Richard Purdie
I'm getting concerned with the number of people forking this recipe and not understanding what they're doing. I'm therefore proposing adding in a suitable warning to people thinking of copying it.
This definitely has my vote. Its an issue that I'm constantly explaining as well.
Quoted 41 lines
Signed-off-by Richard Purdie <[email protected]>---
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +22
-0@@ -2,6 +2,28 @@ DESCRIPTION = "Sanitized set of kernel headers for the C library's use." SECTION = "devel" LICENSE = "GPLv2" +######################################################################### +#### PLEASE READ +######################################################################### +# +# You're probably looking here thinking you need to create some new copy +# of linux-libc-headers since you have your own custom kernel. To put +# this simply, you DO NOT. +# +# Why? These headers are used to build the libc. If you customise the +# headers you are customising the libc and the libc becomes machine +# specific. Most people do not add custom libc extensions to the kernel +# and have a machine specific libc. +# +# But you have some kernel headers you need for some driver? That is fine +# but get them from STAGING_KERNEL_DIR where the kernel installs itself. +# This will make the package using them machine specific but this is much +# better than having a maching specific C library. This does mean your +# recipe needs a DEPENDS += "virtual/kernel" but again, that is fine and +# makes total sense. +# +# -- RP + LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" python __anonymous () {_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
Quoted 21 lines · Richard Purdie
I'm getting concerned with the number of people forking this recipe and not understanding what they're doing. I'm therefore proposing adding in a suitable warning to people thinking of copying it.
Signed-off-by Richard Purdie <[email protected]>---
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +7
-0@@ -2,6 +2,28 @@ DESCRIPTION = "Sanitized set of kernel headers for the C library's use." SECTION = "devel" LICENSE = "GPLv2" +######################################################################### +#### PLEASE READ +######################################################################### +# +# You're probably looking here thinking you need to create some new copy +# of linux-libc-headers since you have your own custom kernel. To put +# this simply, you DO NOT.
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc DESCRIPTION = "Sanitized set of kernel headers for the C library's use." · line 21
Quoted 10 lines
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +10
-0+# +# Why? These headers are used to build the libc. If you customise the +# headers you are customising the libc and the libc becomes machine +# specific. Most people do not add custom libc extensions to the kernel +# and have a machine specific libc. +# +# But you have some kernel headers you need for some driver? That is fine +# but get them from STAGING_KERNEL_DIR where the kernel installs itself. +# This will make the package using them machine specific but this is much +# better than having a maching specific C library. This does mean your
Typo in the above, "maching" should be "machine"...
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc DESCRIPTION = "Sanitized set of kernel headers for the C library's use." · line 26
Quoted 5 lines
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +5
-0+# recipe needs a DEPENDS += "virtual/kernel" but again, that is fine and +# makes total sense. +# +# -- RP +
I am completely in favor of this. People don't get that custom kernel headers have severe ramifications in projects. I've had to explain this to hundreds over the last few years (and they keep doing it anyway)..
--Mark
Quoted 10 lines
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +0
-0LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" python __anonymous () {_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 51 lines · Mark Hatle
Quoted 24 lines · Richard Purdie
I'm getting concerned with the number of people forking this recipe and not understanding what they're doing. I'm therefore proposing adding in a suitable warning to people thinking of copying it.
Signed-off-by Richard Purdie <[email protected]>---
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +0
-0@@ -2,6 +2,28 @@ DESCRIPTION = "Sanitized set of kernel headers for the Clibrary's use."
SECTION = "devel"
LICENSE = "GPLv2"meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +7
-0+######################################################################### +#### PLEASE READ +######################################################################### +# +# You're probably looking here thinking you need to create some new copy +# of linux-libc-headers since you have your own custom kernel. To put +# this simply, you DO NOT.meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc DESCRIPTION = "Sanitized set of kernel headers for the C library's use." · line 21
Quoted 10 lines
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +10
-0+# +# Why? These headers are used to build the libc. If you customise the +# headers you are customising the libc and the libc becomes machine +# specific. Most people do not add custom libc extensions to the kernel +# and have a machine specific libc. +# +# But you have some kernel headers you need for some driver? That is fine +# but get them from STAGING_KERNEL_DIR where the kernel installs itself. +# This will make the package using them machine specific but this is much +# better than having a maching specific C library. This does mean yourTypo in the above, "maching" should be "machine"...
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc DESCRIPTION = "Sanitized set of kernel headers for the C library's use." · line 26
Quoted 5 lines
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +5
-0+# recipe needs a DEPENDS += "virtual/kernel" but again, that is fine and +# makes total sense. +# +# -- RP +I am completely in favor of this. People don't get that custom kernel headers have severe ramifications in projects. I've had to explain this to hundreds over the last few years (and they keep doing it anyway)..
Quoted 4 lines
Acked-by Mark Hatle (with change mentioned above)--Mark
I can only agree to that what you are saying makes perfectly sense. Do not fix what is not broken ;)
However, we did stumble into one problem when stepping up to a later baseline using a 3.8 kernel. The patch for Makefile.headerinst could not be applied to our vendor specific 3.6 kernel branch so we were force to disable it completely. Did we take the wrong turn somewhere?
Thanks.
Hans
Quoted 16 lines
Quoted 11 lines
LIC_FILES_CHKSUM= "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"python __anonymous () {_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 9 lines · Phil Blundell
Quoted 2 lines · Khem Raj
There are cases where we have bsps with 2.6.3x kernels and libc compiled against 3.10 assumes syscalls
That is a bug in glibc. It should not be doing that unless configured --enable-kernel=3.10.x (and this is the whole point of the --enable-kernel option). If it's assuming 3.10.x syscalls under --enable-kernel=2.6.x then it is broken and should be fixed.
we have OLDEST_KERNEL = "2.6.16" and thats not a problem. However one case where it showed up was when building udev > 164 with kernels where accept4 call was not wired for arm e.g. since udev looked up definition of SOCK_CLOEXEC which it found but that 2.6.32 kernel really did not support it.
Quoted 4 lines
p.
Quoted 11 lines · Khem Raj
Quoted 9 lines · Phil Blundell
Quoted 2 lines · Khem Raj
There are cases where we have bsps with 2.6.3x kernels and libc compiled against 3.10 assumes syscalls
That is a bug in glibc. It should not be doing that unless configured --enable-kernel=3.10.x (and this is the whole point of the --enable-kernel option). If it's assuming 3.10.x syscalls under --enable-kernel=2.6.x then it is broken and should be fixed.
Quoted 5 lines
we have
OLDEST_KERNEL= "2.6.16" and thats not a problem. However one case where it showed up was when building udev > 164 with kernels where accept4 call was not wired for arm e.g. since udev looked up definition ofSOCK_CLOEXECwhich it found but that 2.6.32 kernel really did not support it.
That sounds slightly different to the problem you were originally describing ("libc compiled against 3.10") but I think the answer is basically still the same: it is a bug in udev, and udev ought to be fixed.
p.
Quoted 18 lines · Phil Blundell
Quoted 11 lines · Khem Raj
Quoted 9 lines · Phil Blundell
Quoted 2 lines · Khem Raj
There are cases where we have bsps with 2.6.3x kernels and libc compiled against 3.10 assumes syscalls
That is a bug in glibc. It should not be doing that unless configured --enable-kernel=3.10.x (and this is the whole point of the --enable-kernel option). If it's assuming 3.10.x syscalls under --enable-kernel=2.6.x then it is broken and should be fixed.
Quoted 5 lines
we have
OLDEST_KERNEL= "2.6.16" and thats not a problem. However one case where it showed up was when building udev > 164 with kernels where accept4 call was not wired for arm e.g. since udev looked up definition ofSOCK_CLOEXECwhich it found but that 2.6.32 kernel really did not support it.
Quoted 5 lines
That sounds slightly different to the problem you were originally describing ("libc compiled against 3.10") but I think the answer is basically still the same: it is a bug in udev, and udev ought to be fixed.
if you check for kernel version yes but its not wrong by testing a given kernel API which it is doing
anyway i think the notice that rp added is good in general and may be will help folks to upgrade and unify kernels in long run
Quoted 4 lines
p.