scsi: delete decade+ obsolete aic7xxx_old driver
Subsystems (2)
PATCH 1/1 scsi: delete decade+ obsolete aic7xxx_old driver
After getting warnings in an allyesconfig build[1] from this driver, I decided to remind myself just how old it was, and whether it warranted fixing. In the Kconfig help text, I found:
"This driver will eventually be phased out entirely"
Going back to the history archive, I see the line was added[2] in Feb 2002, when we moved from v2.4.2.1 ---> v2.4.2.2
So, with over a decade of notification, and multiple major releases since then, I think we can justify removing this. Currently we have people wasting time building it during routine testing, and then wasting more time re-researching the known reported warnings, only to find that nobody really is willing to integrate the fixes[3] for it.
A quick search didn't seem to indicate any active user base for it. If someone happens to have a quirky _old_ card that the eleven year old "new" driver doesn't work with, then it is entirely reasonable that they stick with a kernel version that predates this removal.
[1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’:
drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’:
drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch]
[2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit 44e8778c
[3] https://lkml.org/lkml/2012/10/29/215
---
[This is an "--irreversible-delete" pseudo-patch which doesn't show all the file content that was deleted wholesale. The full commit is at:git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux.git aic7xxx-delete ]
Documentation/scsi/00-INDEX | 2 - Documentation/scsi/aic7xxx_old.txt | 511 -- MAINTAINERS | 1 - drivers/scsi/Kconfig | 41 - drivers/scsi/Makefile | 1 - drivers/scsi/aic7xxx_old.c | 11149 ------------------------------ drivers/scsi/aic7xxx_old/aic7xxx.h | 28 - drivers/scsi/aic7xxx_old/aic7xxx.reg | 1401 ---- drivers/scsi/aic7xxx_old/aic7xxx.seq | 1539 ----- drivers/scsi/aic7xxx_old/aic7xxx_proc.c | 270 - drivers/scsi/aic7xxx_old/aic7xxx_reg.h | 629 -- drivers/scsi/aic7xxx_old/aic7xxx_seq.c | 817 --- drivers/scsi/aic7xxx_old/scsi_message.h | 49 - drivers/scsi/aic7xxx_old/sequencer.h | 135 - 14 files changed, 16573 deletions(-) delete mode 100644 Documentation/scsi/aic7xxx_old.txt delete mode 100644 drivers/scsi/aic7xxx_old.c delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.h delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.reg delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx.seq delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_proc.c delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_reg.h delete mode 100644 drivers/scsi/aic7xxx_old/aic7xxx_seq.c delete mode 100644 drivers/scsi/aic7xxx_old/scsi_message.h delete mode 100644 drivers/scsi/aic7xxx_old/sequencer.h
Documentation/scsi/00-INDEX +0 -2
@@ -42,8 +42,6 @@ aic79xx.txt - Adaptec Ultra320 SCSI host adapters aic7xxx.txt - info on driver for Adaptec controllers -aic7xxx_old.txt - - info on driver for Adaptec controllers, old generation arcmsr_spec.txt - ARECA FIRMWARE SPEC (for IOP331 adapter) dc395x.txt
Documentation/scsi/aic7xxx_old.txt deleted +0 -0
MAINTAINERS +0 -1
@@ -470,7 +470,6 @@ M: Hannes Reinecke <[email protected]> L: [email protected] S: Maintained F: drivers/scsi/aic7xxx/ -F: drivers/scsi/aic7xxx_old/ AIMSLAB FM RADIO RECEIVER DRIVER M: Hans Verkuil <[email protected]>
drivers/scsi/Kconfig +0 -41
47 lines not on this page · raw message
drivers/scsi/Makefile +0 -1
@@ -70,7 +70,6 @@ obj-$(CONFIG_SCSI_AHA1740) += aha1740.o obj-$(CONFIG_SCSI_AIC7XXX) += aic7xxx/ obj-$(CONFIG_SCSI_AIC79XX) += aic7xxx/ obj-$(CONFIG_SCSI_AACRAID) += aacraid/ -obj-$(CONFIG_SCSI_AIC7XXX_OLD) += aic7xxx_old.o obj-$(CONFIG_SCSI_AIC94XX) += aic94xx/ obj-$(CONFIG_SCSI_PM8001) += pm8001/ obj-$(CONFIG_SCSI_ISCI) += isci/
drivers/scsi/aic7xxx_old.c deleted +0 -0
drivers/scsi/aic7xxx_old/aic7xxx.h deleted +0 -0
drivers/scsi/aic7xxx_old/aic7xxx.reg deleted +0 -0
drivers/scsi/aic7xxx_old/aic7xxx.seq deleted +0 -0
drivers/scsi/aic7xxx_old/aic7xxx_proc.c deleted +0 -0
drivers/scsi/aic7xxx_old/aic7xxx_reg.h deleted +0 -0
drivers/scsi/aic7xxx_old/aic7xxx_seq.c deleted +0 -0
drivers/scsi/aic7xxx_old/scsi_message.h deleted +0 -0
drivers/scsi/aic7xxx_old/sequencer.h deleted +0 -0
Signature · 6 lines
1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · Paul Gortmaker
Currently we have people wasting time building it during routine testing, and then wasting more time re-researching the known reported warnings, only to find that nobody really is willing to integrate the fixes[3] for it.
[...]
Well, this didn't end up as an entire waste of my time. After that message I sent a patch to Fedora's kernel list, and a reminder a few months later[1]. That prompted Josh Boyer to remove this old driver from the Fedora build[2].
And now that driver is disabled in all kernels that Fedora currently ships. I'm not familiar with any complaints about this decision.
Paul Bolle
[1] https://lists.fedoraproject.org/pipermail/kernel/2013-February/004102.html
[2] http://pkgs.fedoraproject.org/cgit/kernel.git/commit/?id=2192022f4bf13b30e389e77170da7ae08fd28ecf
Hannes Reinecke
Acked-byQuoted 10 lines · Paul Bolle
Quoted 8 lines · Paul Gortmaker
Currently we have people wasting time building it during routine testing, and then wasting more time re-researching the known reported warnings, only to find that nobody really is willing to integrate the fixes[3] for it.
[...]
Quoted 8 lines
Well, this didn't end up as an entire waste of my time. After that message I sent a patch to Fedora's kernel list, and a reminder a few months later[1]. That prompted Josh Boyer to remove this old driver from the Fedora build[2].
And now that driver is disabled in all kernels that Fedora currently ships. I'm not familiar with any complaints about this decision.
Ok, good to know.
So this patch appears to be good, then.
Cheers,
Hannes
Signature · 8 lines
Dr. Hannes Reinecke zSeries & Storage [email protected] +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html