Skip to contentSkip to conversation

cifs: don't spam the logs on unexpected lookup errors

PATCH Superseded Jeff Layton 1 participant 2 messages Sep 17, 2013 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: don't spam the logs on unexpected lookup errors

Andrey reported that he was seeing cifs.ko spam the logs with messages like this:

CIFS VFS: Unexpected lookup error -26

He was listing the root directory of a server and hitting an error when trying to QUERY_PATH_INFO against hiberfil.sys and pagefile.sys. The right fix would be to switch the lookup code over to using FIND_FIRST, but until then we really don't need to report this at a level of KERN_ERR. Convert this message over to FYI level.

---
 fs/cifs/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifs/dir.c +1 -1
index d3e2eaa..55c38cf 100644
@@ -755,7 +755,7 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry,
 	/*	if it was once a directory (but how can we tell?) we could do
 		shrink_dcache_parent(direntry); */
 	} else if (rc != -EACCES) {
-		cifs_dbg(VFS, "Unexpected lookup error %d\n", rc);
+		cifs_dbg(FYI, "Unexpected lookup error %d\n", rc);
 		/* We special case check for Access Denied - since that
 		is a common return code */
 	}
Signature · 1 line
1.8.3.1

A message that is not in the archive (sent off-list or not yet received): CAH2r5mvVhOy22dGcOhCojZn0TiwdrtyW1SV_ePMiKqZkhgsPFQ@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAH2r5mvVhOy22dGcOhCojZn0TiwdrtyW1SV_ePMiKqZkhgsPFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#3 lore raw
Quoted 1 line · On Tue, 17 Sep 2013 09:48:27 -0500 Steve French…

Why not change it to ignore sharing violation?

That's just taking us down the special-case rabbit hole. This is not information that is particularly relevant to anyone unless they're trying to debug a problem, and in that situation having them turn up cifsFYI makes more sense.

Quoted 40 lines

What happens if vers=2.1 ie smb2.1

Quoted 36 lines · Jeff Layton

Andrey reported that he was seeing cifs.ko spam the logs with messages like this:

CIFS VFS: Unexpected lookup error -26

He was listing the root directory of a server and hitting an error when trying to QUERY_PATH_INFO against hiberfil.sys and pagefile.sys. The right fix would be to switch the lookup code over to using FIND_FIRST, but until then we really don't need to report this at a level of KERN_ERR. Convert this message over to FYI level.

---
 fs/cifs/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifs/dir.c +0 -0
index d3e2eaa..55c38cf 100644
@@ -755,7 +755,7 @@ cifs_lookup(struct inode *parent_dir_inode, struct
 dentry *direntry,
        /*      if it was once a directory (but how can we tell?) we could

do

                shrink_dcache_parent(direntry); */
        } else if (rc != -EACCES) {
fs/cifs/dir.c +1 -2
-               cifs_dbg(VFS, "Unexpected lookup error %d\n", rc);
+               cifs_dbg(FYI, "Unexpected lookup error %d\n", rc);
                /* We special case check for Access Denied - since that
                is a common return code */
        }
--

1.8.3.1

Signature · 1 line
Jeff Layton <[email protected]>