Skip to contentSkip to conversation

Integration of former (deprecated?) libao recipe from https://github.com/tworaz/oe-tworaz/blob/master/meta-jlime/recipes-support/libao/libao_1.1.0.bb

PATCH In review JC 3 participants 6 messages Sep 17, 2013

lore
Share & tools
lore

JC

author
#0 lore raw

PATCH 1/1 Integration of former (deprecated?) libao recipe from https://github.com/tworaz/oe-tworaz/blob/master/meta-jlime/recipes-support/libao/libao_1.1.0.bb

From: JC Verdie <[email protected]>

---
 meta/recipes-multimedia/libao/libao_1.1.0.bb | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 meta/recipes-multimedia/libao/libao_1.1.0.bb
meta/recipes-multimedia/libao/libao_1.1.0.bb new file +21 -0
new file mode 100644
index 0000000..687e773
@@ -0,0 +1,21 @@
+SECTION = "multimedia"
+
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
+
+SRC_URI="http://downloads.xiph.org/releases/ao/${P}.tar.gz"
+SRC_URI[md5sum] = "2b2508c29bc97e4dc218fa162cf883c8"
+SRC_URI[sha256sum] = "29de5bb9b1726ba890455ef7e562d877df87811febb0d99ee69164b88c171bd4"
+
+inherit autotools
+
+do_install_append () {
+    find "${D}" -name '*.la' -exec rm -f {} +
+}
+
+python populate_packages_prepend () {
+    rootdir = bb.data.expand('${libdir}/ao/plugins-4', d)
+    rootdir_dbg = bb.data.expand('${libdir}/ao/plugins-4/.debug', d)
+    do_split_packages(d, rootdir, '^(.*)\.so$', output_pattern='${PN}-plugin-%s', description='AO %s plugin')
+    do_split_packages(d, rootdir_dbg, '^(.*)\.so$', output_pattern='${PN}-plugin-%s-dbg', description='AO %s plugin debug data')
+}
Signature · 1 line
1.8.1.2
#1 lore raw
Quoted 3 lines · JC

From: JC Verdie <[email protected]>

Couple of tips on the commit message:

First line of the commit message should be "libao: add version 1.1.0" or similar and should be and fairly short, put the link to the source within the body of the commit message and possibly reference the author of the recipe you're copying this from if you can.

Signature · 4 lines
Paul Barker

Email: [email protected]
http://www.paulbarker.me.uk
#2 lore raw
Quoted 11 lines · On Tuesday 17 September 2013 14:07:01 Paul Barker wrote:
Quoted 3 lines · JC

From: JC Verdie <[email protected]>

Couple of tips on the commit message:

First line of the commit message should be "libao: add version 1.1.0" or similar and should be and fairly short, put the link to the source within the body of the commit message and possibly reference the author of the recipe you're copying this from if you can.

Right. A few other things:

1) Since nothing in OE-Core needs this at the moment, this should really be added to meta-multimedia (within the meta-openembedded repository) and sent to the openembedded-devel mailing list marked with [meta-multimedia] in the subject.

2) Please use ${BP} in SRC_URI rather than ${P} so that multilib builds can work

3) It would be nice to have SUMMARY and HOMEPAGE set in the recipe (and possibly also DESCRIPTION if you have a longer description).

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
author
#3 lore raw
Quoted 8 lines · Paul Eggleton

Right. A few other things:

1) Since nothing in OE-Core needs this at the moment, this should really be added to meta-multimedia (within the meta-openembedded repository) and sent to the openembedded-devel mailing list marked with [meta-multimedia] in the subject.

Quoted 9 lines

2) Please use ${BP} in SRC_URI rather than ${P} so that multilib builds can work

3) It would be nice to have SUMMARY and HOMEPAGE set in the recipe (and possibly also DESCRIPTION if you have a longer description).

Cheers,
Paul

I sent a new one trying to comply with your reco. But I could not work on head anymore, since it's broken (at least for me). I'm afraid the patch appears to belong to "dylan" but I'm not a git guru enough to check how to commit it at the right place (I mean, I could simply use my non working git clone of HEAD and commit it untested but I'm not sure that's the way to go).

I'm not sure how to add the [meta-multimedia] tag to the git send-mail, also. Sorry for being dumb :(

Jay

#4 lore raw
Quoted 21 lines · On Tuesday 17 September 2013 10:52:22 JC wrote:
Quoted 7 lines · Paul Eggleton

Right. A few other things:

1) Since nothing in OE-Core needs this at the moment, this should really be added to meta-multimedia (within the meta-openembedded repository) and sent to the openembedded-devel mailing list marked with [meta-multimedia] in the subject.

Quoted 5 lines

2) Please use ${BP} in SRC_URI rather than ${P} so that multilib builds can work

3) It would be nice to have SUMMARY and HOMEPAGE set in the recipe (and possibly also DESCRIPTION if you have a longer description).

I sent a new one trying to comply with your reco. But I could not work on head anymore, since it's broken (at least for me). I'm afraid the patch appears to belong to "dylan" but I'm not a git guru enough to check how to commit it at the right place (I mean, I could simply use my non working git clone of HEAD and commit it untested but I'm not sure that's the way to go).

Quoted 2 lines

I'm not sure how to add the [meta-multimedia] tag to the git send-mail, also. Sorry for being dumb :(

It's not being dumb, we all had to go through this at some point :)

You just need to re-send your latest version using git-send-email with the --subject-prefix="meta-multimedia][PATCH" option to the openembedded- [email protected] mailing list rather than this one.

FWIW I did a quick build-test on top of master and it built successfully at least.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
author
#5 lore raw
Quoted 23 lines · Paul Eggleton
Quoted 20 lines · On Tuesday 17 September 2013 10:52:22 JC wrote:
Quoted 7 lines · Paul Eggleton

Right. A few other things:

1) Since nothing in OE-Core needs this at the moment, this should really be added to meta-multimedia (within the meta-openembedded repository) and sent to the openembedded-devel mailing list marked with [meta-multimedia] in the subject.

Quoted 5 lines

2) Please use ${BP} in SRC_URI rather than ${P} so that multilib builds can work

3) It would be nice to have SUMMARY and HOMEPAGE set in the recipe (and possibly also DESCRIPTION if you have a longer description).

I sent a new one trying to comply with your reco. But I could not work on head anymore, since it's broken (at least for me). I'm afraid the patch appears to belong to "dylan" but I'm not a git guru enough to check how to commit it at the right place (I mean, I could simply use my non working git clone of HEAD and commit it untested but I'm not sure that's the way to go).

Quoted 2 lines

I'm not sure how to add the [meta-multimedia] tag to the git send-mail, also. Sorry for being dumb :(

Quoted 8 lines

It's not being dumb, we all had to go through this at some point :)

You just need to re-send your latest version using git-send-email with the --subject-prefix="meta-multimedia][PATCH" option to the openembedded- [email protected] mailing list rather than this one.

FWIW I did a quick build-test on top of master and it built successfully at least.

Thanks a lot Paul, I just did as instructed...

Jay

Quoted 3 lines

Cheers,
Paul