qt4-x11-free: disable QGtkStyle
PATCH 1/1 qt4-x11-free: disable QGtkStyle
This currently leads to a floating dependency on GTK+. Since most users in an embedded context won't need this, just disable it by default.
Fixes [YOCTO #5116].
--- meta/recipes-qt/qt4/qt4-x11-free.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-qt/qt4/qt4-x11-free.inc +1 -1
@@ -12,7 +12,7 @@ INC_PR = "r50" QT_GLFLAGS ?= "${@base_contains('DISTRO_FEATURES', 'opengl', '-opengl', '-no-opengl', d)} " QT_GLFLAGS_qemux86 = "-opengl" QT_GLFLAGS_qemuppc = "-opengl" -QT_X11_FLAGS ?= "-no-xinerama -no-xkb" +QT_X11_FLAGS ?= "-no-xinerama -no-xkb -no-gtkstyle" QT_CONFIG_FLAGS += "${QT_X11_FLAGS}" QT_BASE_LIB ?= "libqt"
Signature · 1 line
1.8.1.2
Quoted 23 lines · On Friday 20 September 2013 15:58:26 Andreas Müller wrote:
Quoted 21 lines · Paul Eggleton
This currently leads to a floating dependency on GTK+. Since most users in an embedded context won't need this, just disable it by default.
Fixes [YOCTO #5116].
Signed-off-by Paul Eggleton <[email protected]>---
meta/recipes-qt/qt4/qt4-x11-free.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0b/meta/recipes-qt/qt4/qt4-x11-free.inc index 4b29f55..369b3d5 100644
meta/recipes-qt/qt4/qt4-x11-free.inc +0
-0@@ -12,7 +12,7 @@ INC_PR = "r50" QT_GLFLAGS ?= "${@base_contains('DISTRO_FEATURES', 'opengl', '-opengl', '-no-opengl', d)} " QT_GLFLAGS_qemux86 = "-opengl" QT_GLFLAGS_qemuppc = "-opengl"
Quoted 7 lines
Quoted 5 lines
meta/recipes-qt/qt4/qt4-x11-free.inc +1
-1-QT_X11_FLAGS ?= "-no-xinerama -no-xkb" +QT_X11_FLAGS ?= "-no-xinerama -no-xkb -no-gtkstyle"
QT_CONFIG_FLAGS+= "${QT_X11_FLAGS}"
QT_BASE_LIB?= "libqt"How about PACKAGECONFIG for this?
Ultimately I decided against introducing PACKAGECONFIG just for this, because the Qt recipes currently avoid it (PACKAGECONFIG cannot support a number of the additional library options for Qt since they are tri-state; not to mention that PACKAGECONFIG isn't just a drop-in for Qt because it doesn't use autotools/cmake and therefore doesn't use EXTRA_OECONF/EXTRA_OECMAKE). I figured that the few users who do want QGTKStyle can just set QT_X11_FLAGS as desired.
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Quoted 32 lines · Paul Eggleton
Quoted 23 lines · On Friday 20 September 2013 15:58:26 Andreas Müller wrote:
Quoted 21 lines · Paul Eggleton
This currently leads to a floating dependency on GTK+. Since most users in an embedded context won't need this, just disable it by default.
Fixes [YOCTO #5116].
Signed-off-by Paul Eggleton <[email protected]>---
meta/recipes-qt/qt4/qt4-x11-free.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0b/meta/recipes-qt/qt4/qt4-x11-free.inc index 4b29f55..369b3d5 100644
meta/recipes-qt/qt4/qt4-x11-free.inc +0
-0@@ -12,7 +12,7 @@ INC_PR = "r50" QT_GLFLAGS ?= "${@base_contains('DISTRO_FEATURES', 'opengl', '-opengl', '-no-opengl', d)} " QT_GLFLAGS_qemux86 = "-opengl" QT_GLFLAGS_qemuppc = "-opengl"Quoted 7 lines
Quoted 5 lines
meta/recipes-qt/qt4/qt4-x11-free.inc +1
-1-QT_X11_FLAGS ?= "-no-xinerama -no-xkb" +QT_X11_FLAGS ?= "-no-xinerama -no-xkb -no-gtkstyle"
QT_CONFIG_FLAGS+= "${QT_X11_FLAGS}"
QT_BASE_LIB?= "libqt"How about PACKAGECONFIG for this?
Quoted 7 lines
Ultimately I decided against introducing PACKAGECONFIG just for this, because the Qt recipes currently avoid it (PACKAGECONFIG cannot support a number of the additional library options for Qt since they are tri-state; not to mention that PACKAGECONFIG isn't just a drop-in for Qt because it doesn't use autotools/cmake and therefore doesn't use EXTRA_OECONF/EXTRA_OECMAKE). I figured that the few users who do want QGTKStyle can just set
QT_X11_FLAGSas desired.
FWIW: I'm using PACKAGECONFIG in meta-qt5, you're right that it cannot cover all 3 states for each option, but most common scenarios need to select only between 2 and automatically added DEPENDS/RDEPENDS is big plus.
To support PACKAGECONFIG without autotools/cmake inherit I just add generated EXTRA_OECONF to QT_CONFIG_FLAGS.
But I agree that in this patch it's easier without introducing PACKAGECONFIG for qt4.
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Quoted 44 lines · On Friday 20 September 2013 16:42:05 Martin Jansa wrote:
Quoted 35 lines · Paul Eggleton
Quoted 26 lines · On Friday 20 September 2013 15:58:26 Andreas Müller wrote:
On Fri, Sep 20, 2013 at 3:01 PM, Paul Eggleton
Quoted 23 lines · <[email protected]> wrote:
This currently leads to a floating dependency on GTK+. Since most users
in an embedded context won't need this, just disable it by default.Fixes [YOCTO #5116].
Signed-off-by Paul Eggleton <[email protected]>---
meta/recipes-qt/qt4/qt4-x11-free.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0b/meta/recipes-qt/qt4/qt4-x11-free.inc index 4b29f55..369b3d5 100644
meta/recipes-qt/qt4/qt4-x11-free.inc +0
-0@@ -12,7 +12,7 @@ INC_PR = "r50" QT_GLFLAGS ?= "${@base_contains('DISTRO_FEATURES', 'opengl', '-opengl', '-no-opengl', d)} " QT_GLFLAGS_qemux86 = "-opengl" QT_GLFLAGS_qemuppc = "-opengl"Quoted 7 lines
Quoted 5 lines
meta/recipes-qt/qt4/qt4-x11-free.inc +1
-1-QT_X11_FLAGS ?= "-no-xinerama -no-xkb" +QT_X11_FLAGS ?= "-no-xinerama -no-xkb -no-gtkstyle"
QT_CONFIG_FLAGS+= "${QT_X11_FLAGS}"
QT_BASE_LIB?= "libqt"How about PACKAGECONFIG for this?
Quoted 7 lines
Ultimately I decided against introducing PACKAGECONFIG just for this, because the Qt recipes currently avoid it (PACKAGECONFIG cannot support a number of the additional library options for Qt since they are tri-state; not to mention that PACKAGECONFIG isn't just a drop-in for Qt because it doesn't use autotools/cmake and therefore doesn't use EXTRA_OECONF/EXTRA_OECMAKE). I figured that the few users who do want QGTKStyle can just set
QT_X11_FLAGSas desired.
Quoted 4 lines
FWIW: I'm using PACKAGECONFIG in meta-qt5, you're right that it cannot cover all 3 states for each option, but most common scenarios need to select only between 2 and automatically added DEPENDS/RDEPENDS is big plus.
On this wider issue, I have given some thought to how we could expand PACKAGECONFIG to support multi-state options, although I'm hesitant to make the already slightly opaque PACKAGECONFIG syntax any more complicated. Something to think about further for the next development cycle perhaps.
Quoted 2 lines
To support PACKAGECONFIG without autotools/cmake inherit I just add generated
EXTRA_OECONFtoQT_CONFIG_FLAGS.
I didn't try it but Peter reported that this caused a failure when he tried this as a solution (presumably because there is junk in EXTRA_OECONF already that isn't suitable for passing to Qt4's configure). It ought to be able to work though.
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Quoted 6 lines · Paul Eggleton
This currently leads to a floating dependency on GTK+. Since most users in an embedded context won't need this, just disable it by default.
Fixes [YOCTO #5116].
Signed-off-by Paul Eggleton <[email protected]>
Personally I use the QGtkStyle in some products but I am all in favor of this. This avoids floating dependencies and I can easily re-add it back in our internal layer.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750