Skip to contentSkip to conversation

hmp: block-stream: fix typo

PATCH In review Anthony Liguori 2 participants 2 messages Sep 20, 2013 – Sep 23, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hmp: block-stream: fix typo

Found this by enabling C++ errors. The bool and enum arguments are mistakenly flipped.

---
 hmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hmp.c +1 -1
index 2a90295..5891507 100644
@@ -1163,7 +1163,7 @@ void hmp_block_stream(Monitor *mon, const QDict *qdict)
 
     qmp_block_stream(device, base != NULL, base,
                      qdict_haskey(qdict, "speed"), speed,
-                     BLOCKDEV_ON_ERROR_REPORT, true, &error);
+                     true, BLOCKDEV_ON_ERROR_REPORT, &error);
 
     hmp_handle_error(mon, &error);
 }
Signature · 1 line
1.8.0
Acked-by on v1 1/1
#1 lore raw
Quoted 23 lines · Anthony Liguori

Found this by enabling C++ errors. The bool and enum arguments are mistakenly flipped.

---
 hmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hmp.c +1 -1
index 2a90295..5891507 100644
@@ -1163,7 +1163,7 @@ void hmp_block_stream(Monitor *mon, const QDict *qdict)
 
     qmp_block_stream(device, base != NULL, base,
                      qdict_haskey(qdict, "speed"), speed,
-                     BLOCKDEV_ON_ERROR_REPORT, true, &error);
+                     true, BLOCKDEV_ON_ERROR_REPORT, &error);
 
     hmp_handle_error(mon, &error);
 }
Signature · 1 line
1.8.0