virtio-net: broken RX filtering logic fixed
PATCH 1/1 virtio-net: broken RX filtering logic fixed
From: Dmitry Fleytman <[email protected]>
Upon processing of VIRTIO_NET_CTRL_MAC_TABLE_SET command multicast list overwrites unicast list in mac_table.
This leads to broken logic for both unicast and multicast RX filtering.
Signed-off-by Dmitry Fleytman <[email protected]>
--- hw/net/virtio-net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
hw/net/virtio-net.c +2 -1
@@ -656,7 +656,8 @@ static int virtio_net_handle_mac(VirtIONet *n, uint8_t cmd, }if (n->mac_table.in_use + mac_data.entries <=MAC_TABLE_ENTRIES ) { - s =iov_to_buf (iov, iov_cnt,0 , n->mac_table.macs, + s =iov_to_buf (iov, iov_cnt,0 , + &n->mac_table.macs[n->mac_table.in_use *ETH_ALEN ], mac_data.entries *ETH_ALEN );if (s != mac_data.entries *ETH_ALEN ) { goto error;
Signature · 1 line
1.8.3.1
Stefan Hajnoczi
AppliedQuoted 10 lines · Dmitry Fleytman
From: Dmitry Fleytman <[email protected]>
Upon processing of
VIRTIO_NET_CTRL_MAC_TABLE_SETcommand multicast list overwrites unicast list inmac_table.
This leads to broken logic for both unicast and multicast RX filtering.Signed-off-by Dmitry Fleytman <[email protected]>--- hw/net/virtio-net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, applied to my net-next tree:
https://github.com/stefanha/qemu/commits/net-next
Stefan