=?y?q?=5BPATCH=20V2=5D=20kconfig/menu=2Ec=3A=20fix=20uninitialized=20variable=20warning?=
In file included from scripts/kconfig/zconf.tab.c:2537:0:scripts/kconfig/menu.c: In function ‘get_symbol_str’:scripts/kconfig/menu.c:586:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized]
jump->offset = r->len - 1;
^
scripts/kconfig/menu.c:547:19: note: ‘jump’ was declared here
struct jump_key *jump;
^Change V2:
1)Added comment as suggested.
--- scripts/kconfig/menu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kconfig/menu.c +2 -1
@@ -544,7 +544,8 @@ static void get_prompt_str(struct gstr *r, struct property *prop, {int i, j;struct menu *submenu[8 ], *menu, *location =NULL ; -struct jump_key *jump; +/* Initializing to avoid a spurious warning observed in gcc 4.8.0 */ +struct jump_key *jump =NULL ;str_printf (r,_ ("Prompt: %s\n" ),_ (prop->text)); menu = prop->menu->parent;
Signature · 1 line
1.7.10.4
Re: [PATCH V2] kconfig/menu.c: fix uninitialized variable warning
Madhavan, All,
On 2013-09-22 22:35 +0530, Madhavan Srinivasan spake thusly:
Quoted 4 lines
In file included from
scripts/kconfig/zconf.tab.c:2537:0:scripts/kconfig/menu.c: In function ‘get_symbol_str’:scripts/kconfig/menu.c:586:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Quoted 8 lines
jump->offset = r->len - 1; ^ scripts/kconfig/menu.c:547:19: note: ‘jump’ was declared here struct jump_key *jump; ^Change V2:
1)Added comment as suggested.
Maybe I'm mislead, but I think Benjamin and I suggested a comment that explained the warning was just spurious, and there would be no code change. Something like:
/* gcc 4.8.0 on (your distro and version) warns about 'jump may be
* used uninitialized', which is wrong. The warning does not appear
* with gcc != 4.8.0 */
struct jump_key *jump;
This is so, if sometime in the future the code changes, and the variable is indeeded used uninitialised, we have a proper warning by gcc in this case.
Care to resend, please?
Regards,
Yann E. MORIN.
Quoted 22 lines
Signed-off-by Madhavan Srinivasan <[email protected]>--- scripts/kconfig/menu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)scripts/kconfig/menu.c +2
-1@@ -544,7 +544,8 @@ static void get_prompt_str(struct gstr *r, struct property *prop, {int i, j;struct menu *submenu[8 ], *menu, *location =NULL ; -struct jump_key *jump; +/* Initializing to avoid a spurious warning observed in gcc 4.8.0 */ +struct jump_key *jump =NULL ;str_printf (r,_ ("Prompt: %s\n" ),_ (prop->text)); menu = prop->menu->parent;Signature · 1 line
1.7.10.4
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'