Skip to contentSkip to conversation

batman-adv: no need for return in void functions

PATCH Applied Antonio Quartulli 2 participants 2 messages Sep 22, 2013 – Sep 24, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 batman-adv: no need for return in void functions

Only network-coding.h is using "return;" inside void stub functions. This is not a consistent with the rest of the code, therefore don't continue to do as such.
(Other stub functions will be cleaned later)

Introduced by 7dd9d8992b0c197ba656a6d9a70966cea10fc2d9 ("batman-adv: tvlv - add network coding container")

---
 network-coding.h | 1 -
 1 file changed, 1 deletion(-)
network-coding.h +0 -1
index 8a97b40..d2f110c 100644
@@ -49,7 +49,6 @@ int batadv_nc_init_debugfs(struct batadv_priv *bat_priv);
 
 static inline void batadv_nc_status_update(struct net_device *net_dev)
 {
-	return;
 }
 
 static inline int batadv_nc_init(struct batadv_priv *bat_priv)
Signature · 1 line
1.8.1.5
#1 lore raw
Quoted 5 lines · On Sunday 22 September 2013 20:26:50 Antonio Quartulli wrote:

Only network-coding.h is using "return;" inside void stub functions. This is not a consistent with the rest of the code, therefore don't continue to do as such.
(Other stub functions will be cleaned later)

Quoted 7 lines

Introduced by 7dd9d8992b0c197ba656a6d9a70966cea10fc2d9 ("batman-adv: tvlv - add network coding container")

---
 network-coding.h | 1 -
 1 file changed, 1 deletion(-)

Applied in revision 96cebef.

Thanks,
Marek