Skip to contentSkip to conversation

pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig.

PATCH In review Sonic Zhang 3 participants 3 messages Sep 23, 2013 Pin control

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig.

From: Sonic Zhang <[email protected]>

---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/Kconfig +1 -0
index 08b8337..9bb6efb 100644
@@ -51,6 +51,7 @@ config PINCTRL_AB8505
 
 config PINCTRL_ADI2
 	bool "ADI pin controller driver"
+	depends on BLACKFIN
 	select PINMUX
 	select IRQ_DOMAIN
 	help
Signature · 1 line
1.8.2.3
#2 lore raw
In reply to Sonic Zhang

The other two Coccinelle warnings were real bugs as well:

drivers/pinctrl/pinctrl-adi2.c:250:1-18: ERROR: nested lock+irqsave that reuses flags from line 249. The second spinlock_irq_save() should just be a spinlock.

drivers/pinctrl/pinctrl-adi2.c:326:16-19: ERROR: port is NULL but dereferenced. The error message dereferences a NULL pointer.

regards,
dan carpenter