Skip to contentSkip to conversation

autotools: handle dependency on intltool-native

PATCH/RFC Eric Bénard 2 participants 4 messages Sep 23, 2013

lore
Share & tools
lore
#0 lore raw

autotools' class can use intltoolize but has no dependency on it
which can leads to :
/test/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/cortexa9hf-vfp-neon-oe-linux-gnueabi/gnokii/0.6.31-r0/temp/run.do_configure.7559: line 179: intltoolize: command not found

This patch fix this problem by adding the dependency on intltool-native which can be tricky as it triggers circular dependencies very easily.

---
 meta/classes/autotools.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/autotools.bbclass +1 -0
index 883eb06..eb988cb 100644
@@ -16,6 +16,7 @@ def autotools_dep_prepend(d):
                         and not bb.data.inherits_class('cross', d) \
                         and not d.getVar('INHIBIT_DEFAULT_DEPS', True):
             deps += 'libtool-cross '
+            deps += 'intltool-native '
 
     return deps + 'gnu-config-native '
 
Signature · 1 line
1.8.4.rc3
#1 lore raw
Quoted 18 lines · Eric Bénard

autotools' class can use intltoolize but has no dependency on it
which can leads to :
/test/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/cortexa9hf-vfp-neon-oe-linux-gnueabi/gnokii/0.6.31-r0/temp/run.do_configure.7559: line 179: intltoolize: command not found

This patch fix this problem by adding the dependency on intltool-native which can be tricky as it triggers circular dependencies very easily.

---
 meta/classes/autotools.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/autotools.bbclass +0 -0
index 883eb06..eb988cb 100644

meta/classes/autotools.bbclass def autotools_dep_prepend(d): · line 21

Quoted 6 lines
meta/classes/autotools.bbclass +1 -0
@@ -16,6 +16,7 @@ def autotools_dep_prepend(d):
                         and not bb.data.inherits_class('cross', d) \
                         and not d.getVar('INHIBIT_DEFAULT_DEPS', True):
             deps += 'libtool-cross '
+            deps += 'intltool-native '
 
     return deps + 'gnu-config-native '

Its expected that recipes using that add to DEPENDS. Please lets not add in the dependency for everyone since it isn't actually used in that many places. Its small details like this which end up causing significant performance issues :/.

Cheers,

Richard

#2 lore raw
Quoted 24 lines · Richard Purdie
Quoted 23 lines · Eric Bénard

autotools' class can use intltoolize but has no dependency on it
which can leads to :
/test/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/cortexa9hf-vfp-neon-oe-linux-gnueabi/gnokii/0.6.31-r0/temp/run.do_configure.7559: line 179: intltoolize: command not found

This patch fix this problem by adding the dependency on intltool-native which can be tricky as it triggers circular dependencies very easily.

---
 meta/classes/autotools.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/autotools.bbclass +1 -0
index 883eb06..eb988cb 100644
@@ -16,6 +16,7 @@ def autotools_dep_prepend(d):
                         and not bb.data.inherits_class('cross', d) \
                         and not d.getVar('INHIBIT_DEFAULT_DEPS', True):
             deps += 'libtool-cross '
+            deps += 'intltool-native '
 
Quoted 7 lines

meta/classes/autotools.bbclass def autotools_dep_prepend(d): · line 21

Quoted 1 line
meta/classes/autotools.bbclass +0 -0
     return deps + 'gnu-config-native '

Its expected that recipes using that add to DEPENDS. Please lets not add in the dependency for everyone since it isn't actually used in that many places. Its small details like this which end up causing significant performance issues :/.

OK agreed. Would you accept a patch to add this in comment in autotools.bbclass so that this gets documented somewhere ?

Eric

#3 lore raw
Quoted 34 lines · Eric Bénard
Quoted 24 lines · Richard Purdie
Quoted 23 lines · Eric Bénard

autotools' class can use intltoolize but has no dependency on it
which can leads to :
/test/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/cortexa9hf-vfp-neon-oe-linux-gnueabi/gnokii/0.6.31-r0/temp/run.do_configure.7559: line 179: intltoolize: command not found

This patch fix this problem by adding the dependency on intltool-native which can be tricky as it triggers circular dependencies very easily.

---
 meta/classes/autotools.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/autotools.bbclass +1 -0
index 883eb06..eb988cb 100644
@@ -16,6 +16,7 @@ def autotools_dep_prepend(d):
                         and not bb.data.inherits_class('cross', d) \
                         and not d.getVar('INHIBIT_DEFAULT_DEPS', True):
             deps += 'libtool-cross '
+            deps += 'intltool-native '
 
Quoted 7 lines

meta/classes/autotools.bbclass def autotools_dep_prepend(d): · line 21

Quoted 1 line
meta/classes/autotools.bbclass +0 -0
     return deps + 'gnu-config-native '

Its expected that recipes using that add to DEPENDS. Please lets not add in the dependency for everyone since it isn't actually used in that many places. Its small details like this which end up causing significant performance issues :/.

Quoted 2 lines

OK agreed. Would you accept a patch to add this in comment in autotools.bbclass so that this gets documented somewhere ?

Yes.

Cheers,

Richard