logrotate: nees mmu
PATCH 1/2 logrotate: nees mmu
---
Fix below build error:
logrotate.o: In function `switch_user_permanently':/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:129: undefined reference to fork' logrotate.o: In function removeLogFile':/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:431: undefined reference to fork' logrotate.o: In function mailLog':/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:597: undefined reference to fork' /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:615: undefined reference to fork' logrotate.o: In function `compressLogFile':/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:533: undefined reference to `fork'
collect2: ld returned 1 exit status
make[1]: *** [logrotate] Error 1
package/logrotate/Config.in | 1 + 1 file changed, 1 insertion(+)
package/logrotate/Config.in +1 -0
@@ -2,6 +2,7 @@ config BR2_PACKAGE_LOGROTATE bool "logrotate" select BR2_PACKAGE_POPT depends on BR2_USE_WCHAR + depends on BR2_USE_MMU # fork() help A simple program to rotate logs.
Signature · 1 line
1.8.1.2
PATCH 2/2 logrotate: bump to version 3.8.6
--- package/logrotate/logrotate.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/logrotate/logrotate.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -LOGROTATE_VERSION = 3.8.4 +LOGROTATE_VERSION = 3.8.6 LOGROTATE_SOURCE = logrotate-$(LOGROTATE_VERSION).tar.gz LOGROTATE_SITE = https://www.fedorahosted.org/releases/l/o/logrotate/ LOGROTATE_LICENSE = GPLv2+
Signature · 1 line
1.8.1.2
PATCH 1/2 logrotate: nees mmu
In reply to Axel LinDear Axel Lin,
Quoted 4 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>---
Fix below build error:
Quoted 11 lines
logrotate.o: In function `switch_user_permanently':
/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:129: undefined reference tofork' logrotate.o: In functionremoveLogFile':/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:431: undefined reference tofork' logrotate.o: In functionmailLog':/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:597: undefined reference tofork' /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:615: undefined reference tofork' logrotate.o: In function `compressLogFile':/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:533: undefined reference to `fork'
collect2: ld returned 1 exit status
make[1]: *** [logrotate] Error 1
It's a minor comment, but I believe the log of the error could go within the commit log itself (i.e, before the --- separator). It really is part of the explanation of why the change is needed.
Note that there is no need to resend this patch just for this reason, it was merely a suggestion for future patches.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/2 logrotate: nees mmu
2013/10/1 Thomas Petazzoni <[email protected]>:
Quoted 19 lines
Dear Axel Lin,
Quoted 4 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>---
Fix below build error:Quoted 11 lines
logrotate.o: In function `switch_user_permanently':
/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:129: undefined reference tofork' logrotate.o: In functionremoveLogFile':/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:431: undefined reference tofork' logrotate.o: In functionmailLog':/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:597: undefined reference tofork' /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:615: undefined reference tofork' logrotate.o: In function `compressLogFile':/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:533: undefined reference to `fork'
collect2: ld returned 1 exit status
make[1]: *** [logrotate] Error 1
Quoted 6 lines
It's a minor comment, but I believe the log of the error could go within the commit log itself (i.e, before the --- separator). It really is part of the explanation of why the change is needed.
Note that there is no need to resend this patch just for this reason, it was merely a suggestion for future patches.
Actually, I check git log before sending patches.
Some commit log includes a link to the autobuild build log. But I don't find any commit log with build error so I didn't include the build error messages.
I just add the error messages here to make it easier for review.
Anyway, I will include the error message in commit log next time I send a patch.
Regards,
Axel
PATCH 2/2 logrotate: bump to version 3.8.6
In reply to Axel LinQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Axel" == Axel Lin <[email protected]> writes:
Axel> Signed-off-by: Axel Lin <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard