Skip to contentSkip to conversation

mpc85xx_edac: Remove unused function

PATCH In review Thierry Reding 3 participants 4 messages Oct 7, 2013 – Oct 8, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpc85xx_edac: Remove unused function

Commit 905e75c (powerpc/fsl-pci: Unify pci/pcie initialization code) removed the struct platform_driver that held the last reference to the mpc85xx_pci_err_remove() function. Remove the function since it is effectively dead code.

---
 drivers/edac/mpc85xx_edac.c | 23 -----------------------
 1 file changed, 23 deletions(-)
drivers/edac/mpc85xx_edac.c +0 -23
index 3eb32f6..b1e7106 100644
@@ -326,29 +326,6 @@ err:
 	return res;
 }
 EXPORT_SYMBOL(mpc85xx_pci_err_probe);
-
-static int mpc85xx_pci_err_remove(struct platform_device *op)
-{
-	struct edac_pci_ctl_info *pci = dev_get_drvdata(&op->dev);
-	struct mpc85xx_pci_pdata *pdata = pci->pvt_info;
-
-	edac_dbg(0, "\n");
-
-	out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_CAP_DR,
-		 orig_pci_err_cap_dr);
-
-	out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_EN, orig_pci_err_en);
-
-	edac_pci_del_device(pci->dev);
-
-	if (edac_op_state == EDAC_OPSTATE_INT)
-		irq_dispose_mapping(pdata->irq);
-
-	edac_pci_free_ctl_info(pci);
-
-	return 0;
-}
-
 #endif				/* CONFIG_PCI */
 
 /**************************** L2 Err device ***************************/
Signature · 1 line
1.8.4
maintainer
#1 lore raw

I'm guessing this one is for Johannes. CCed...

Quoted 52 lines · Thierry Reding

Commit 905e75c (powerpc/fsl-pci: Unify pci/pcie initialization code) removed the struct platform_driver that held the last reference to the mpc85xx_pci_err_remove() function. Remove the function since it is effectively dead code.

---
 drivers/edac/mpc85xx_edac.c | 23 -----------------------
 1 file changed, 23 deletions(-)
drivers/edac/mpc85xx_edac.c +0 -23
index 3eb32f6..b1e7106 100644
@@ -326,29 +326,6 @@ err:
 	return res;
 }
 EXPORT_SYMBOL(mpc85xx_pci_err_probe);
-
-static int mpc85xx_pci_err_remove(struct platform_device *op)
-{
-	struct edac_pci_ctl_info *pci = dev_get_drvdata(&op->dev);
-	struct mpc85xx_pci_pdata *pdata = pci->pvt_info;
-
-	edac_dbg(0, "\n");
-
-	out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_CAP_DR,
-		 orig_pci_err_cap_dr);
-
-	out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_EN, orig_pci_err_en);
-
-	edac_pci_del_device(pci->dev);
-
-	if (edac_op_state == EDAC_OPSTATE_INT)
-		irq_dispose_mapping(pdata->irq);
-
-	edac_pci_free_ctl_info(pci);
-
-	return 0;
-}
-
 #endif				/* CONFIG_PCI */
 
 /**************************** L2 Err device ***************************/
Signature · 6 lines
1.8.4

--
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 5 lines
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
#2 lore raw
In reply to Thierry Reding
Quoted 47 lines · Thierry Reding

Commit 905e75c (powerpc/fsl-pci: Unify pci/pcie initialization code) removed the struct platform_driver that held the last reference to the mpc85xx_pci_err_remove() function. Remove the function since it is effectively dead code.

---
 drivers/edac/mpc85xx_edac.c | 23 -----------------------
 1 file changed, 23 deletions(-)
drivers/edac/mpc85xx_edac.c +0 -24
index 3eb32f6..b1e7106 100644
@@ -326,29 +326,6 @@ err:
 	return res;
 }
 EXPORT_SYMBOL(mpc85xx_pci_err_probe);
-
-static int mpc85xx_pci_err_remove(struct platform_device *op)
-{
-	struct edac_pci_ctl_info *pci = dev_get_drvdata(&op->dev);
-	struct mpc85xx_pci_pdata *pdata = pci->pvt_info;
-
-	edac_dbg(0, "\n");
-
-	out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_CAP_DR,
-		 orig_pci_err_cap_dr);
-
-	out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_EN, orig_pci_err_en);
-
-	edac_pci_del_device(pci->dev);
-
-	if (edac_op_state == EDAC_OPSTATE_INT)
-		irq_dispose_mapping(pdata->irq);
-
-	edac_pci_free_ctl_info(pci);
-
-	return 0;
-}
-
 #endif				/* CONFIG_PCI */
 
 /**************************** L2 Err device ***************************/
--

1.8.4

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-edac" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Hi Thierry,

Sorry, but I already have this patch in
http://lkml.indiana.edu/hypermail/linux/kernel/1309.2/03410.html

But anyways, thanks
Johannes

#3 lore raw
Quoted 55 lines · Johannes Thumshirn
Quoted 47 lines · Thierry Reding

Commit 905e75c (powerpc/fsl-pci: Unify pci/pcie initialization code) removed the struct platform_driver that held the last reference to the mpc85xx_pci_err_remove() function. Remove the function since it is effectively dead code.

---
 drivers/edac/mpc85xx_edac.c | 23 -----------------------
 1 file changed, 23 deletions(-)
drivers/edac/mpc85xx_edac.c +0 -24
index 3eb32f6..b1e7106 100644
@@ -326,29 +326,6 @@ err:
 	return res;
 }
 EXPORT_SYMBOL(mpc85xx_pci_err_probe);
-
-static int mpc85xx_pci_err_remove(struct platform_device *op)
-{
-	struct edac_pci_ctl_info *pci = dev_get_drvdata(&op->dev);
-	struct mpc85xx_pci_pdata *pdata = pci->pvt_info;
-
-	edac_dbg(0, "\n");
-
-	out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_CAP_DR,
-		 orig_pci_err_cap_dr);
-
-	out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_EN, orig_pci_err_en);
-
-	edac_pci_del_device(pci->dev);
-
-	if (edac_op_state == EDAC_OPSTATE_INT)
-		irq_dispose_mapping(pdata->irq);
-
-	edac_pci_free_ctl_info(pci);
-
-	return 0;
-}
-
 #endif				/* CONFIG_PCI */
 
 /**************************** L2 Err device ***************************/
--

1.8.4

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-edac" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Hi Thierry,

Quoted 2 lines

Sorry, but I already have this patch in
http://lkml.indiana.edu/hypermail/linux/kernel/1309.2/03410.html

No worries.

Thierry