Tegra114: Dalmore: Add voltage reg/PMIC init for various periphs
Subsystems (2)
PATCH 1/1 Tegra114: Dalmore: Add voltage reg/PMIC init for various periphs
These powerrails are currently needed for kernel boot. This will be move to a pmic-specific driver (or even better moved to the kernel) at a later date.
--- arch/arm/include/asm/arch-tegra/board.h | 3 + board/nvidia/common/board.c | 4 + board/nvidia/dalmore/dalmore.c | 154 +++++++++++++++++++++++++++----- include/configs/dalmore.h | 3 + 4 files changed, 140 insertions(+), 24 deletions(-)
arch/arm/include/asm/arch-tegra/board.h +3 -0
@@ -29,4 +29,7 @@ void pin_mux_spi(void); /* overrideable SPI pinmux setup */void pin_mux_nand (void );/* overrideable NAND pinmux setup */ void pin_mux_display (void );/* overrideable DISPLAY pinmux setup */ +/* Enable needed power rails */ +void board_vreg_init (void ); +#endif
board/nvidia/common/board.c +4 -0
@@ -151,6 +151,10 @@ int board_init(void)# endif /* CONFIG_TEGRA_PMU */ #endif /* CONFIG_SYS_I2C_TEGRA */ +#ifdef CONFIG_TEGRA114 +/* Enable needed power rails. TBD: Move to kernel or driver init. */ +board_vreg_init (); +#endif #ifdef CONFIG_USB_EHCI_TEGRA pin_mux_usb ();board_usb_init (gd->fdt_blob);
board/nvidia/dalmore/dalmore.c +130 -24
183 lines not on this page · raw message
include/configs/dalmore.h +3 -0
@@ -87,6 +87,9 @@#define CONFIG_CMD_NET #define CONFIG_CMD_DHCP +/* Backlight enable GPIO. TBD - move to DT when LCD driver added */ +#define DSI_PANEL_BL_EN_GPIO GPIO_PH2 +#include "tegra-common-post.h" #endif /* __CONFIG_H */
Signature · 1 line
1.8.1.5
PATCH 1/1 Tegra114: Dalmore: Add voltage reg/PMIC init for various periphs
Quoted 3 lines · Tom Warren
These powerrails are currently needed for kernel boot. This will be move to a pmic-specific driver (or even better moved to the kernel) at a later date.
Which kernel? The upstream kernel has been booting on Dalmore without issue for quite a long time, without this patch.
If some other kernel needs some voltage rails to be enabled in order to use certain hardware, it must be modified to enable them itself. We should not hack around kernel deficiencies in the bootloader. A kernel should be able to boot without any bootloader at all.
PATCH 1/1 Tegra114: Dalmore: Add voltage reg/PMIC init for various periphs
As Stephen points out, the PMIC/vreg settings aren't needed to boot an upstream kernel, so I'm dropping this patch.
Thanks
Quoted 13 lines · Stephen Warren
Quoted 3 lines · Tom Warren
These powerrails are currently needed for kernel boot. This will be move to a pmic-specific driver (or even better moved to the kernel) at a later date.
Which kernel? The upstream kernel has been booting on Dalmore without issue for quite a long time, without this patch.
If some other kernel needs some voltage rails to be enabled in order to use certain hardware, it must be modified to enable them itself. We should not hack around kernel deficiencies in the bootloader. A kernel should be able to boot without any bootloader at all.