Skip to contentSkip to conversation

Few qemu-xen configuration fixes and improvement.

PATCH In review Anthony PERARD 2 participants 4 messages Oct 8, 2013 – Oct 10, 2013

lore
Share & tools
lore
#0 lore raw

cover Few qemu-xen configuration fixes and improvement.

osstest is not happy with a path been created by the QEMU build system (/usr/local/var/run). Those two patchs are fixing that and improve the call to qemu's configure.

Anthony PERARD (2):
qemu-xen: Disabling build of guest-agent.
qemu-xen: Set localstatedir to /var.

 tools/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Signature · 1 line
Anthony PERARD
#1 lore raw

PATCH 1/2 qemu-xen: Disabling build of guest-agent.

It is not use when QEMU is run with Xen.

---
 tools/Makefile | 1 +
 1 file changed, 1 insertion(+)
tools/Makefile +1 -0
index 066df66..206b79a 100644
@@ -201,6 +201,7 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find
 		--datadir=$(SHAREDIR)/qemu-xen \
 		--disable-kvm \
 		--disable-docs \
+		--disable-guest-agent \
 		--python=$(PYTHON) \
 		$(IOEMU_CONFIGURE_CROSS); \
 	$(MAKE) all
Signature · 1 line
Anthony PERARD
#2 lore raw

PATCH 2/2 qemu-xen: Set localstatedir to /var.

In reply to Anthony PERARD

This path is used by the QEMU build system to create the /run directory. If local-state-dir is not set, the result become $prefix/var which is not an acceptable path.

---
 tools/Makefile | 1 +
 1 file changed, 1 insertion(+)
tools/Makefile +1 -0
index 206b79a..b73f0a9 100644
@@ -199,6 +199,7 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find
 		-L$(XEN_ROOT)/tools/xenstore" \
 		--bindir=$(LIBEXEC) \
 		--datadir=$(SHAREDIR)/qemu-xen \
+		--localstatedir=/var \
 		--disable-kvm \
 		--disable-docs \
 		--disable-guest-agent \
Signature · 1 line
Anthony PERARD
#3 lore raw
In reply to Anthony PERARD
Quoted 3 lines · Anthony PERARD

osstest is not happy with a path been created by the QEMU build system (/usr/local/var/run). Those two patchs are fixing that and improve the call to qemu's configure.

Acked + applied both. Once this passes xen-unstables gate then that ought to unblock the qemu osstest failures I think.