xfsprogs: introduce the free inode btree
cover xfsprogs: introduce the free inode btree
Hi all,
This is the userspace portion of v1 finobt support corresponding to:
http://oss.sgi.com/archives/xfs/2013-10/msg00206.html
Patches 1-9 are straight application of the corresponding kernel patches with omissions where appropriate. At this point, I'd suggest review of those patches target the kernel equivalents, as this set will progress using the kernel set as a base.
The remaining three patches add basic mkfs support, the ability to print the agi_free_root and agi_free_level from xfs_db and fix a minor bug in repair. Real support for repair is not yet available. Reviews on the additional userspace specific bits are appreciated. Otherwise, this set is probably more useful for testing/experimentation on the feature itself.
Brian
Brian Foster (12):
xfsprogs: refactor xfs_ialloc_btree.c to support multiple inobt
numbers
xfsprogs: reserve v5 superblock read-only compat. feature bit for
finobt
xfsprogs: support the XFS_BTNUM_FINOBT free inode btree type
xfsprogs: update inode allocation/free transaction reservations for
finobt
xfsprogs: insert newly allocated inode chunks into the finobt
xfsprogs: use and update the finobt on inode allocation
xfsprogs: refactor xfs_difree() inobt bits into xfs_difree_inobt()
helper
xfsprogs: update the finobt on inode free
xfsprogs: enable the finobt feature on v5 superblocks xfsprogs/mkfs: finobt mkfs support
xfsprogs/db: finobt support
xfsprogs/repair: account for finobt in ag 0 geometry pre-calculation
db/agi.c | 2 + db/btblock.c | 12 + include/xfs_ag.h | 32 ++- include/xfs_btree.h | 3 + include/xfs_ialloc_btree.h | 17 +- include/xfs_sb.h | 10 +- include/xfs_trans_space.h | 7 +- include/xfs_types.h | 2 +- libxfs/xfs_btree.c | 6 +- libxfs/xfs_ialloc.c | 616 ++++++++++++++++++++++++++++++++++++++------- libxfs/xfs_ialloc_btree.c | 68 ++++- libxfs/xfs_trans_resv.c | 47 +++- mkfs/xfs_mkfs.c | 97 +++++-- repair/xfs_repair.c | 2 + 14 files changed, 770 insertions(+), 151 deletions(-)
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 1/12 xfsprogs: refactor xfs_ialloc_btree.c to support multiple inobt numbers
The introduction of the free inode btree (finobt) requires that xfs_ialloc_btree.c handle multiple trees. Refactor xfs_ialloc_btree.c so the caller specifies the btree type on cursor initialization to prepare for addition of the finobt.
--- include/xfs_ialloc_btree.h | 3 ++- libxfs/xfs_ialloc.c | 8 ++++---- libxfs/xfs_ialloc_btree.c | 8 +++++--- 3 files changed, 11 insertions(+), 8 deletions(-)
include/xfs_ialloc_btree.h +2 -1
@@ -107,7 +107,8 @@ typedef __be32 xfs_inobt_ptr_t; ((index) - 1) * sizeof(xfs_inobt_ptr_t)))extern struct xfs_btree_cur *xfs_inobt_init_cursor (struct xfs_mount *, -struct xfs_trans *,struct xfs_buf *,xfs_agnumber_t ); +struct xfs_trans *,struct xfs_buf *,xfs_agnumber_t , +xfs_btnum_t );extern int xfs_inobt_maxrecs (struct xfs_mount *,int ,int );extern const struct xfs_buf_ops xfs_inobt_buf_ops;
libxfs/xfs_ialloc.c +4 -4
@@ -432,7 +432,7 @@ xfs_ialloc_ag_alloc(/* * Insert records describing the new inode chunk into the btree. */ - cur =xfs_inobt_init_cursor (args.mp, tp, agbp, agno); + cur =xfs_inobt_init_cursor (args.mp, tp, agbp, agno,XFS_BTNUM_INO );for (thisino = newino; thisino < newino + newlen; thisino +=XFS_INODES_PER_CHUNK ) {
@@ -678,7 +678,7 @@ xfs_dialloc_ag(ASSERT (pag->pagi_freecount >0 ); restart_pagno: - cur =xfs_inobt_init_cursor (mp, tp, agbp, agno); + cur =xfs_inobt_init_cursor (mp, tp, agbp, agno,XFS_BTNUM_INO );/* * If pagino is 0 (this is the root inode allocation) use newino. * This must work because we've just allocated some.
@@ -1140,7 +1140,7 @@ xfs_difree(/* * Initialize the cursor. */ - cur =xfs_inobt_init_cursor (mp, tp, agbp, agno); + cur =xfs_inobt_init_cursor (mp, tp, agbp, agno,XFS_BTNUM_INO ); error =xfs_check_agi_freecount (cur, agi);if (error)
@@ -1271,7 +1271,7 @@ xfs_imap_lookup(* we have a record, we need to ensure it contains the inode number * we are looking up. */ - cur =xfs_inobt_init_cursor (mp, tp, agbp, agno); + cur =xfs_inobt_init_cursor (mp, tp, agbp, agno,XFS_BTNUM_INO ); error =xfs_inobt_lookup (cur, agino,XFS_LOOKUP_LE , &i);if (!error) {if (i)
libxfs/xfs_ialloc_btree.c +5 -3
@@ -30,7 +30,8 @@ xfs_inobt_dup_cursor( struct xfs_btree_cur *cur) {return xfs_inobt_init_cursor (cur->bc_mp, cur->bc_tp, - cur->bc_private.a.agbp, cur->bc_private.a.agno); + cur->bc_private.a.agbp, cur->bc_private.a.agno, + cur->bc_btnum); }STATIC void
@@ -377,7 +378,8 @@ xfs_inobt_init_cursor(struct xfs_mount *mp,/* file system mount point */ struct xfs_trans *tp, /* transaction pointer */ struct xfs_buf *agbp, /* buffer for agi structure */ - xfs_agnumber_t agno) /* allocation group number */ + xfs_agnumber_t agno, /* allocation group number */ + xfs_btnum_t btnum) /* ialloc or free ino btree */ { struct xfs_agi *agi = XFS_BUF_TO_AGI(agbp);struct xfs_btree_cur *cur;
@@ -387,7 +389,7 @@ xfs_inobt_init_cursor( cur->bc_tp = tp; cur->bc_mp = mp; cur->bc_nlevels =be32_to_cpu (agi->agi_level); - cur->bc_btnum =XFS_BTNUM_INO ; + cur->bc_btnum = btnum; cur->bc_blocklog = mp->m_sb.sb_blocklog; cur->bc_ops = &xfs_inobt_ops;
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 2/12 xfsprogs: reserve v5 superblock read-only compat. feature bit for finobt
In reply to Brian FosterReserve a v5 read-only compatibility feature bit for the finobt and create the xfs_sb_version_hasfinobt() helper to determine whether an fs has the feature enabled.
The finobt does not change existing on-disk structures, but must remain consistent with the ialloc btree. Modifications from older kernels would violate that constrant. Therefore, we restrict older kernels to read-only mounts of finobt-enabled filesystems.
Note that this does not yet enable the ability to rw mount a finobt fs (by setting the feature bit in the XFS_SB_FEAT_RO_COMPAT_ALL mask).
--- include/xfs_sb.h | 7 +++++++ 1 file changed, 7 insertions(+)
include/xfs_sb.h +7 -0
@@ -583,6 +583,7 @@ xfs_sb_has_compat_feature(return (sbp->sb_features_compat & feature) !=0 ; } +#define XFS_SB_FEAT_RO_COMPAT_FINOBT (1 << 0)/* free inode btree */ #define XFS_SB_FEAT_RO_COMPAT_ALL 0#define XFS_SB_FEAT_RO_COMPAT_UNKNOWN ~XFS_SB_FEAT_RO_COMPAT_ALL static inline bool
@@ -635,6 +636,12 @@ static inline int xfs_sb_version_hasftype(struct xfs_sb *sbp)xfs_sb_has_incompat_feature (sbp,XFS_SB_FEAT_INCOMPAT_FTYPE ); } +static inline int xfs_sb_version_hasfinobt (xfs_sb_t *sbp) +{ +return (XFS_SB_VERSION_NUM (sbp) ==XFS_SB_VERSION_5 ) && + (sbp->sb_features_ro_compat &XFS_SB_FEAT_RO_COMPAT_FINOBT ); +} +/* * end of superblock version macros */
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 3/12 xfsprogs: support the XFS_BTNUM_FINOBT free inode btree type
In reply to Brian FosterDefine the AGI fields for the finobt root/level and add magic numbers. Update the btree code to add support for the new XFS_BTNUM_FINOBT inode btree.
The finobt root block is reserved immediately following the inobt root block in the AG. Update XFS_PREALLOC_BLOCKS() to determine the starting AG data block based on whether finobt support is enabled.
--- include/xfs_ag.h | 32 +++++++++++++++---------- include/xfs_btree.h | 3 +++ include/xfs_ialloc_btree.h | 14 ++++++++++- include/xfs_types.h | 2 +- libxfs/xfs_btree.c | 6 +++-- libxfs/xfs_ialloc.c | 37 ++++++++++++++++++++++++---- libxfs/xfs_ialloc_btree.c | 60 ++++++++++++++++++++++++++++++++++++++++++++-- 7 files changed, 130 insertions(+), 24 deletions(-)
include/xfs_ag.h +19 -13
@@ -166,22 +166,28 @@ typedef struct xfs_agi {__be32 agi_pad32;__be64 agi_lsn;/* last write sequence */ +__be32 agi_free_root;/* root of the free inode btree */ +__be32 agi_free_level;/* levels in free inode btree */ +/* structure must be padded to 64 bit alignment */ } xfs_agi_t; -#define XFS_AGI_MAGICNUM 0x00000001 -#define XFS_AGI_VERSIONNUM 0x00000002 -#define XFS_AGI_SEQNO 0x00000004 -#define XFS_AGI_LENGTH 0x00000008 -#define XFS_AGI_COUNT 0x00000010 -#define XFS_AGI_ROOT 0x00000020 -#define XFS_AGI_LEVEL 0x00000040 -#define XFS_AGI_FREECOUNT 0x00000080 -#define XFS_AGI_NEWINO 0x00000100 -#define XFS_AGI_DIRINO 0x00000200 -#define XFS_AGI_UNLINKED 0x00000400 -#define XFS_AGI_NUM_BITS 11 -#define XFS_AGI_ALL_BITS ((1 << XFS_AGI_NUM_BITS) - 1) +#define XFS_AGI_MAGICNUM (1 << 0) +#define XFS_AGI_VERSIONNUM (1 << 1) +#define XFS_AGI_SEQNO (1 << 2) +#define XFS_AGI_LENGTH (1 << 3) +#define XFS_AGI_COUNT (1 << 4) +#define XFS_AGI_ROOT (1 << 5) +#define XFS_AGI_LEVEL (1 << 6) +#define XFS_AGI_FREECOUNT (1 << 7) +#define XFS_AGI_NEWINO (1 << 8) +#define XFS_AGI_DIRINO (1 << 9) +#define XFS_AGI_UNLINKED (1 << 10) +#define XFS_AGI_NUM_BITS_R1 11/* end of the 1st agi logging region */ +#define XFS_AGI_ALL_BITS_R1 ((1 << XFS_AGI_NUM_BITS_R1) - 1) +#define XFS_AGI_FREE_ROOT (1 << 11) +#define XFS_AGI_FREE_LEVEL (1 << 12) +#define XFS_AGI_NUM_BITS_R2 13/* disk block (xfs_daddr_t) in the AG */ #define XFS_AGI_DADDR (mp) ((xfs_daddr_t)(2 << (mp)->m_sectbb_log))
include/xfs_btree.h +3 -0
@@ -37,6 +37,7 @@ extern kmem_zone_t *xfs_btree_cur_zone;#define XFS_BTNUM_CNT ((xfs_btnum_t)XFS_BTNUM_CNTi)#define XFS_BTNUM_BMAP ((xfs_btnum_t)XFS_BTNUM_BMAPi)#define XFS_BTNUM_INO ((xfs_btnum_t)XFS_BTNUM_INOi) +#define XFS_BTNUM_FINO ((xfs_btnum_t)XFS_BTNUM_FINOi)/* * Generic btree header.
@@ -144,6 +145,7 @@ do { \case XFS_BTNUM_CNT :__XFS_BTREE_STATS_INC (abtc, stat);break ; \case XFS_BTNUM_BMAP :__XFS_BTREE_STATS_INC (bmbt, stat);break ; \case XFS_BTNUM_INO :__XFS_BTREE_STATS_INC (ibt, stat);break ; \ +case XFS_BTNUM_FINO :__XFS_BTREE_STATS_INC (fibt, stat);break ; \case XFS_BTNUM_MAX :ASSERT (0 );/* fucking gcc */ ;break ; \ } \ }while (0 )
@@ -157,6 +159,7 @@ do { \case XFS_BTNUM_CNT :__XFS_BTREE_STATS_ADD (abtc, stat, val);break ; \case XFS_BTNUM_BMAP :__XFS_BTREE_STATS_ADD (bmbt, stat, val);break ; \case XFS_BTNUM_INO :__XFS_BTREE_STATS_ADD (ibt, stat, val);break ; \ +case XFS_BTNUM_FINO :__XFS_BTREE_STATS_ADD (fibt, stat, val);break ; \case XFS_BTNUM_MAX :ASSERT (0 );/* fucking gcc */ ;break ; \ } \ }while (0 )
include/xfs_ialloc_btree.h +13 -1
@@ -31,6 +31,8 @@ struct xfs_mount;*/ #define XFS_IBT_MAGIC 0x49414254/* 'IABT' */ #define XFS_IBT_CRC_MAGIC 0x49414233/* 'IAB3' */ +#define XFS_FIBT_MAGIC 0x46494254/* 'FIBT' */ +#define XFS_FIBT_CRC_MAGIC 0x46494233/* 'FIB3' */ typedef __uint64_t xfs_inofree_t ;#define XFS_INODES_PER_CHUNK (NBBY * sizeof(xfs_inofree_t))
@@ -73,7 +75,17 @@ typedef __be32 xfs_inobt_ptr_t;* block numbers in the AG. */ #define XFS_IBT_BLOCK (mp) ((xfs_agblock_t)(XFS_CNT_BLOCK(mp) + 1)) -#define XFS_PREALLOC_BLOCKS (mp) ((xfs_agblock_t)(XFS_IBT_BLOCK(mp) + 1)) +#define XFS_FIBT_BLOCK (mp) ((xfs_agblock_t)(XFS_IBT_BLOCK(mp) + 1)) + +/* +* The first data block of an AG depends on whether the filesystem was formatted +* with the finobt feature. If so, account for the finobt reserved root btree +* block. +*/ +#define XFS_PREALLOC_BLOCKS (mp) \ + (xfs_sb_version_hasfinobt(&((mp)->m_sb)) ? \ + XFS_FIBT_BLOCK(mp) + 1 : \ + XFS_IBT_BLOCK(mp) + 1)/* * Btree block header size depends on a superblock flag.
include/xfs_types.h +1 -1
@@ -134,7 +134,7 @@ typedef enum {typedef enum { XFS_BTNUM_BNOi, XFS_BTNUM_CNTi, XFS_BTNUM_BMAPi, XFS_BTNUM_INOi, -XFS_BTNUM_MAX + XFS_BTNUM_FINOi,XFS_BTNUM_MAX }xfs_btnum_t ;struct xfs_name {
libxfs/xfs_btree.c +4 -2
@@ -27,9 +27,10 @@ kmem_zone_t *xfs_btree_cur_zone;* Btree magic numbers. */ static const __uint32_t xfs_magics[2 ][XFS_BTNUM_MAX ] = { - {XFS_ABTB_MAGIC ,XFS_ABTC_MAGIC ,XFS_BMAP_MAGIC ,XFS_IBT_MAGIC }, + {XFS_ABTB_MAGIC ,XFS_ABTC_MAGIC ,XFS_BMAP_MAGIC ,XFS_IBT_MAGIC , +XFS_FIBT_MAGIC }, {XFS_ABTB_CRC_MAGIC ,XFS_ABTC_CRC_MAGIC , -XFS_BMAP_CRC_MAGIC ,XFS_IBT_CRC_MAGIC } +XFS_BMAP_CRC_MAGIC ,XFS_IBT_CRC_MAGIC ,XFS_FIBT_CRC_MAGIC } };#define xfs_btree_magic (cur) \ xfs_magics[!!((cur)->bc_flags & XFS_BTREE_CRC_BLOCKS)][cur->bc_btnum]
@@ -1045,6 +1046,7 @@ xfs_btree_set_refs(xfs_buf_set_ref (bp,XFS_ALLOC_BTREE_REF );break ;case XFS_BTNUM_INO : +case XFS_BTNUM_FINO :xfs_buf_set_ref (bp,XFS_INO_BTREE_REF );break ;case XFS_BTNUM_BMAP :
libxfs/xfs_ialloc.c +32 -5
@@ -1482,6 +1482,8 @@ xfs_ialloc_log_agi( offsetof(xfs_agi_t , agi_newino), offsetof(xfs_agi_t , agi_dirino), offsetof(xfs_agi_t , agi_unlinked), + offsetof(xfs_agi_t , agi_free_root), + offsetof(xfs_agi_t , agi_free_level), sizeof(xfs_agi_t) };#ifdef DEBUG
@@ -1491,14 +1493,39 @@ xfs_ialloc_log_agi(ASSERT (agi->agi_magicnum ==cpu_to_be32 (XFS_AGI_MAGIC ));#endif /* -* Compute byte offsets for the first and last fields. +* The growth of the agi buffer over time now requires that we interpret +* the buffer as two logical regions delineated at the end of the unlinked +* list. This is due to the size of the hash table and its location in the +* middle of the agi. +* +* For example, a request to log a field before agi_unlinked and a field +* after agi_unlinked could cause us to log the entire hash table and use +* an excessive amount of log space. To avoid this behavior, log the +* region up through agi_unlinked in one call and the region after +* agi_unlinked through the end of the structure in another. */ -xfs_btree_offsets (fields, offsets,XFS_AGI_NUM_BITS , &first, &last); +xfs_trans_buf_set_type (tp, bp,XFS_BLFT_AGI_BUF ); +/* -* Log the allocation group inode header buffer. +* Compute byte offsets for the first and last fields in the first +* region and log agi buffer. This only logs up through agi_unlinked. */ -xfs_trans_buf_set_type (tp, bp,XFS_BLFT_AGI_BUF ); -xfs_trans_log_buf (tp, bp, first, last); +if (fields &XFS_AGI_ALL_BITS_R1 ) { +xfs_btree_offsets (fields, offsets,XFS_AGI_NUM_BITS_R1 , + &first, &last); +xfs_trans_log_buf (tp, bp, first, last); + } + +/* +* Mask off the bits in the first region and calculate the first and last +* field offsets for any bits in the second region. +*/ + fields &= ~XFS_AGI_ALL_BITS_R1 ; +if (fields) { +xfs_btree_offsets (fields, offsets,XFS_AGI_NUM_BITS_R2 , + &first, &last); +xfs_trans_log_buf (tp, bp, first, last); + } }#ifdef DEBUG
libxfs/xfs_ialloc_btree.c +58 -2
99 lines not on this page · raw message
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 4/12 xfsprogs: update inode allocation/free transaction reservations for finobt
In reply to Brian FosterCreate the xfs_calc_finobt_res() helper to calculate the finobt log reservation for inode allocation and free. Update XFS_IALLOC_SPACE_RES() to reserve blocks for the additional finobt insertion on inode allocation. Create XFS_IFREE_SPACE_RES() to reserve blocks for the potential finobt record insertion on inode free (i.e., if an inode chunk was previously fully allocated).
--- include/xfs_trans_space.h | 7 ++++++- libxfs/xfs_trans_resv.c | 47 +++++++++++++++++++++++++++++++++++++++++++---- 2 files changed, 49 insertions(+), 5 deletions(-)
include/xfs_trans_space.h +6 -1
@@ -47,7 +47,9 @@#define XFS_DIRREMOVE_SPACE_RES (mp) \ XFS_DAREMOVE_SPACE_RES(mp, XFS_DATA_FORK)#define XFS_IALLOC_SPACE_RES (mp) \ - (XFS_IALLOC_BLOCKS(mp) + (mp)->m_in_maxlevels - 1) + (XFS_IALLOC_BLOCKS(mp) + \ + (xfs_sb_version_hasfinobt(&mp->m_sb) ? 2 : 1 * \ + ((mp)->m_in_maxlevels - 1)))/* * Space reservation values for various transactions.
@@ -82,5 +84,8 @@ (XFS_DIRREMOVE_SPACE_RES(mp) + XFS_DIRENTER_SPACE_RES(mp,nl))#define XFS_SYMLINK_SPACE_RES (mp,nl,b) \ (XFS_IALLOC_SPACE_RES(mp) + XFS_DIRENTER_SPACE_RES(mp,nl) + (b)) +#define XFS_IFREE_SPACE_RES (mp) \ + (xfs_sb_version_hasfinobt(&mp->m_sb) ? (mp)->m_in_maxlevels : 0) +#endif /* __XFS_TRANS_SPACE_H__ */
libxfs/xfs_trans_resv.c +43 -4
101 lines not on this page · raw message
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 5/12 xfsprogs: insert newly allocated inode chunks into the finobt
In reply to Brian FosterA newly allocated inode chunk, by definition, has at least one free inode, so a record is always inserted into the finobt.
Create the xfs_inobt_insert() helper from existing code to insert a record in an inobt based on the provided BTNUM. Update xfs_ialloc_ag_alloc() to invoke the helper for the existing XFS_BTNUM_INO tree and XFS_BTNUM_FINO tree, if enabled.
--- libxfs/xfs_ialloc.c | 93 ++++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 70 insertions(+), 23 deletions(-)
libxfs/xfs_ialloc.c +70 -23
@@ -88,6 +88,66 @@ xfs_inobt_get_rec( }/* +* Insert a single inobt record. Cursor must already point to desired location. +*/ +STATIC int +xfs_inobt_insert_rec ( +struct xfs_btree_cur *cur, +__int32_t freecount, +xfs_inofree_t free, +int *stat) +{ + cur->bc_rec.i.ir_freecount = freecount; + cur->bc_rec.i.ir_free = free; +return xfs_btree_insert (cur, stat); +} + +/* +* Insert records describing a newly allocated inode chunk into the inobt. +*/ +STATIC int +xfs_inobt_insert ( +struct xfs_mount *mp, +struct xfs_trans *tp, +struct xfs_buf *agbp, +xfs_agino_t newino, +xfs_agino_t newlen, +xfs_btnum_t btnum) +{ +struct xfs_btree_cur *cur; +struct xfs_agi *agi =XFS_BUF_TO_AGI (agbp); +xfs_agnumber_t agno =be32_to_cpu (agi->agi_seqno); +xfs_agino_t thisino; +int i; +int error; + + cur =xfs_inobt_init_cursor (mp, tp, agbp, agno, btnum); + +for (thisino = newino; + thisino < newino + newlen; + thisino +=XFS_INODES_PER_CHUNK ) { + error =xfs_inobt_lookup (cur, thisino,XFS_LOOKUP_EQ , &i); +if (error) { +xfs_btree_del_cursor (cur,XFS_BTREE_ERROR ); +return error; + } +ASSERT (i ==0 ); + + error =xfs_inobt_insert_rec (cur,XFS_INODES_PER_CHUNK , +XFS_INOBT_ALL_FREE , &i); +if (error) { +xfs_btree_del_cursor (cur,XFS_BTREE_ERROR ); +return error; + } +ASSERT (i ==1 ); + } + +xfs_btree_del_cursor (cur,XFS_BTREE_NOERROR ); + +return 0 ; +} + +/* * Verify that the number of free inodes in the AGI is correct. */ #ifdef DEBUG
@@ -286,13 +346,10 @@ xfs_ialloc_ag_alloc( {xfs_agi_t *agi;/* allocation group header */ xfs_alloc_arg_t args;/* allocation argument structure */ -xfs_btree_cur_t *cur;/* inode btree cursor */ xfs_agnumber_t agno;int error; -int i;xfs_agino_t newino;/* new first inode's number */ xfs_agino_t newlen;/* new number of inodes */ -xfs_agino_t thisino;/* current inode number, for loop */ int isaligned =0 ;/* inode allocation at stripe unit */ /* boundary */ struct xfs_perag *pag;
@@ -430,29 +487,19 @@ xfs_ialloc_ag_alloc( agi->agi_newino =cpu_to_be32 (newino);/* -* Insert records describing the new inode chunk into the btree. +* Insert records describing the new inode chunk into the btrees. */ - cur =xfs_inobt_init_cursor (args.mp, tp, agbp, agno,XFS_BTNUM_INO ); -for (thisino = newino; - thisino < newino + newlen; - thisino +=XFS_INODES_PER_CHUNK ) { - cur->bc_rec.i.ir_startino = thisino; - cur->bc_rec.i.ir_freecount =XFS_INODES_PER_CHUNK ; - cur->bc_rec.i.ir_free =XFS_INOBT_ALL_FREE ; - error =xfs_btree_lookup (cur,XFS_LOOKUP_EQ , &i); -if (error) { -xfs_btree_del_cursor (cur,XFS_BTREE_ERROR ); -return error; - } -ASSERT (i ==0 ); - error =xfs_btree_insert (cur, &i); -if (error) { -xfs_btree_del_cursor (cur,XFS_BTREE_ERROR ); + error =xfs_inobt_insert (args.mp, tp, agbp, newino, newlen, +XFS_BTNUM_INO ); +if (error) +return error; + +if (xfs_sb_version_hasfinobt (&args.mp->m_sb)) { + error =xfs_inobt_insert (args.mp, tp, agbp, newino, newlen, +XFS_BTNUM_FINO ); +if (error)return error; - } -ASSERT (i ==1 ); } -xfs_btree_del_cursor (cur,XFS_BTREE_NOERROR );/* * Log allocation group header fields */
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 6/12 xfsprogs: use and update the finobt on inode allocation
In reply to Brian FosterReplace xfs_dialloc_ag() with an implementation that looks for a record in the finobt. The finobt only tracks records with at least one free inode. This eliminates the need for the intra-ag scan in the original algorithm. Once the inode is allocated, update the finobt appropriately (possibly removing the record) as well as the inobt.
Move the original xfs_dialloc_ag() algorithm to xfs_dialloc_ag_slow() and fall back as such if finobt support is not enabled.
--- libxfs/xfs_ialloc.c | 211 +++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 210 insertions(+), 1 deletion(-)
libxfs/xfs_ialloc.c +210 -1
@@ -699,7 +699,7 @@ xfs_ialloc_get_rec(* available. */ STATIC int -xfs_dialloc_ag( +xfs_dialloc_ag_slow( struct xfs_trans *tp, struct xfs_buf *agbp, xfs_ino_t parent,
@@ -957,6 +957,215 @@ error0:return error; } +STATIC int +xfs_dialloc_ag ( +struct xfs_trans *tp, +struct xfs_buf *agbp, +xfs_ino_t parent, +xfs_ino_t *inop) +{ +struct xfs_mount *mp = tp->t_mountp; +struct xfs_agi *agi =XFS_BUF_TO_AGI (agbp); +xfs_agnumber_t agno =be32_to_cpu (agi->agi_seqno); +xfs_agnumber_t pagno =XFS_INO_TO_AGNO (mp, parent); +xfs_agino_t pagino =XFS_INO_TO_AGINO (mp, parent); +struct xfs_perag *pag; +struct xfs_btree_cur *cur; +struct xfs_btree_cur *tcur; +struct xfs_inobt_rec_incore rec; +struct xfs_inobt_rec_incore trec; +xfs_ino_t ino; +int error; +int offset; +int i, j; + +if (!xfs_sb_version_hasfinobt (&mp->m_sb)) +return xfs_dialloc_ag_slow (tp, agbp, parent, inop); + + pag =xfs_perag_get (mp, agno); + +/* +* If pagino is 0 (this is the root inode allocation) use newino. +* This must work because we've just allocated some. +*/ +if (!pagino) + pagino =be32_to_cpu (agi->agi_newino); + + cur =xfs_inobt_init_cursor (mp, tp, agbp, agno,XFS_BTNUM_FINO ); + + error =xfs_check_agi_freecount (cur, agi); +if (error) + goto error_cur; + +if (agno == pagno) { +/* +* We're in the same AG as the parent inode so allocate the +* closest inode to the parent. +*/ + error =xfs_inobt_lookup (cur, pagino,XFS_LOOKUP_LE , &i); +if (error) + goto error_cur; +if (i ==1 ) { + error =xfs_inobt_get_rec (cur, &rec, &i); +if (error) + goto error_cur; +XFS_WANT_CORRUPTED_GOTO (i ==1 , error_cur); + +/* +* See if we've landed in the parent inode record. The +* finobt only tracks chunks with at least one free +* inode, so record existence is enough. +*/ +if (pagino >= rec.ir_startino && + pagino < (rec.ir_startino +XFS_INODES_PER_CHUNK )) + goto alloc_inode; + } + + error =xfs_btree_dup_cursor (cur, &tcur); +if (error) + goto error_cur; + + error =xfs_inobt_lookup (tcur, pagino,XFS_LOOKUP_GE , &j); +if (error) + goto error_tcur; +if (j ==1 ) { + error =xfs_inobt_get_rec (tcur, &trec, &j); +if (error) + goto error_tcur; +XFS_WANT_CORRUPTED_GOTO (j ==1 , error_tcur); + } + +if (i ==1 && j ==1 ) { +if ((pagino - rec.ir_startino +XFS_INODES_PER_CHUNK -1 ) > + (trec.ir_startino - pagino)) { + rec = trec; +xfs_btree_del_cursor (cur,XFS_BTREE_NOERROR ); + cur = tcur; + }else { +xfs_btree_del_cursor (tcur,XFS_BTREE_NOERROR ); + } + }else if (j ==1 ) { + rec = trec; +xfs_btree_del_cursor (cur,XFS_BTREE_NOERROR ); + cur = tcur; + }else { +xfs_btree_del_cursor (tcur,XFS_BTREE_NOERROR ); + } + }else { +/* +* Different AG from the parent inode. Check the record for the +* most recently allocated inode. +*/ +if (agi->agi_newino !=cpu_to_be32 (NULLAGINO )) { + error =xfs_inobt_lookup (cur, agi->agi_newino, +XFS_LOOKUP_EQ , &i); +if (error) + goto error_cur; +if (i ==1 ) { + error =xfs_inobt_get_rec (cur, &rec, &i); +if (error) + goto error_cur; +XFS_WANT_CORRUPTED_GOTO (i ==1 , error_cur); + goto alloc_inode; + } + } + +/* +* Allocate the first inode available in the AG. +*/ + error =xfs_inobt_lookup (cur,0 ,XFS_LOOKUP_GE , &i); +if (error) + goto error_cur; +XFS_WANT_CORRUPTED_GOTO (i ==1 , error_cur); + + error =xfs_inobt_get_rec (cur, &rec, &i); +if (error) + goto error_cur; +XFS_WANT_CORRUPTED_GOTO (i ==1 , error_cur); + } + +alloc_inode: + offset =xfs_lowbit64 (rec.ir_free); +ASSERT (offset >=0 ); +ASSERT (offset <XFS_INODES_PER_CHUNK ); +ASSERT ((XFS_AGINO_TO_OFFSET (mp, rec.ir_startino) % +XFS_INODES_PER_CHUNK ) ==0 ); + ino =XFS_AGINO_TO_INO (mp, agno, rec.ir_startino + offset); + +/* +* Modify or remove the finobt record. +*/ + rec.ir_free &= ~XFS_INOBT_MASK (offset); + rec.ir_freecount--; +if (rec.ir_freecount) + error =xfs_inobt_update (cur, &rec); +else + error =xfs_btree_delete (cur, &i); +if (error) + goto error_cur; + +/* +* Lookup and modify the equivalent record in the inobt. +*/ + tcur =xfs_inobt_init_cursor (mp, tp, agbp, agno,XFS_BTNUM_INO ); + + error =xfs_check_agi_freecount (tcur, agi); +if (error) + goto error_tcur; + + error =xfs_inobt_lookup (tcur, rec.ir_startino,XFS_LOOKUP_EQ , &i); +if (error) + goto error_tcur; +XFS_WANT_CORRUPTED_GOTO (i ==1 , error_tcur); + + error =xfs_inobt_get_rec (tcur, &trec, &i); +if (error) + goto error_tcur; +XFS_WANT_CORRUPTED_GOTO (i ==1 , error_tcur); +ASSERT ((XFS_AGINO_TO_OFFSET (mp, trec.ir_startino) % +XFS_INODES_PER_CHUNK ) ==0 ); + + trec.ir_free &= ~XFS_INOBT_MASK (offset); + trec.ir_freecount--; + +XFS_WANT_CORRUPTED_GOTO ((rec.ir_free == trec.ir_free) && + (rec.ir_freecount == trec.ir_freecount), + error_tcur); + + error =xfs_inobt_update (tcur, &trec); +if (error) + goto error_tcur; + +/* +* Update the perag and superblock. +*/ +be32_add_cpu (&agi->agi_freecount,-1 ); +xfs_ialloc_log_agi (tp, agbp,XFS_AGI_FREECOUNT ); + pag->pagi_freecount--; + +xfs_trans_mod_sb (tp,XFS_TRANS_SB_IFREE ,-1 ); + + error =xfs_check_agi_freecount (tcur, agi); +if (error) + goto error_tcur; + error =xfs_check_agi_freecount (cur, agi); +if (error) + goto error_tcur; + +xfs_btree_del_cursor (tcur,XFS_BTREE_NOERROR ); +xfs_btree_del_cursor (cur,XFS_BTREE_NOERROR ); +xfs_perag_put (pag); + *inop = ino; +return 0 ; + +error_tcur: +xfs_btree_del_cursor (tcur,XFS_BTREE_ERROR ); +error_cur: +xfs_btree_del_cursor (cur,XFS_BTREE_ERROR ); +xfs_perag_put (pag); +return error; +} +/* * Allocate an inode on disk. *
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 7/12 xfsprogs: refactor xfs_difree() inobt bits into xfs_difree_inobt() helper
In reply to Brian FosterRefactor xfs_difree() in preparation for the finobt. xfs_difree() performs the validity checks against the ag and reads the agi header. The work of physically updating the inode allocation btree is pushed down into the new xfs_difree_inobt() helper.
--- libxfs/xfs_ialloc.c | 160 +++++++++++++++++++++++++++++++--------------------- 1 file changed, 96 insertions(+), 64 deletions(-)
libxfs/xfs_ialloc.c +96 -64
@@ -1325,74 +1325,31 @@ out_error:return XFS_ERROR (error); } -/* -* Free disk inode. Carefully avoids touching the incore inode, all -* manipulations incore are the caller's responsibility. -* The on-disk inode is not changed by this operation, only the -* btree (free inode mask) is changed. -*/ -int -xfs_difree ( -xfs_trans_t *tp,/* transaction pointer */ -xfs_ino_t inode,/* inode to be freed */ -xfs_bmap_free_t *flist,/* extents to free */ -int *delete,/* set if inode cluster was deleted */ -xfs_ino_t *first_ino)/* first inode in deleted cluster */ +STATIC int +xfs_difree_inobt ( +struct xfs_mount *mp, +struct xfs_trans *tp, +struct xfs_buf *agbp, +xfs_agino_t agino, +struct xfs_bmap_free *flist, +int *delete, +xfs_ino_t *first_ino, +struct xfs_inobt_rec_incore *orec) { -/* REFERENCED */ -xfs_agblock_t agbno;/* block number containing inode */ -xfs_buf_t *agbp;/* buffer containing allocation group header */ -xfs_agino_t agino;/* inode number relative to allocation group */ -xfs_agnumber_t agno;/* allocation group number */ -xfs_agi_t *agi;/* allocation group header */ -xfs_btree_cur_t *cur;/* inode btree cursor */ -int error;/* error return value */ -int i;/* result code */ -int ilen;/* inodes in an inode cluster */ -xfs_mount_t *mp;/* mount structure for filesystem */ -int off;/* offset of inode in inode chunk */ -xfs_inobt_rec_incore_t rec;/* btree record */ -struct xfs_perag *pag; - - mp = tp->t_mountp; +struct xfs_agi *agi =XFS_BUF_TO_AGI (agbp); +xfs_agnumber_t agno =be32_to_cpu (agi->agi_seqno); +xfs_agblock_t agbno =XFS_AGINO_TO_AGBNO (mp, agino); +struct xfs_perag *pag; +struct xfs_btree_cur *cur; +struct xfs_inobt_rec_incore rec; +int ilen; +int error; +int i; +int off; -/* -* Break up inode number into its components. -*/ - agno =XFS_INO_TO_AGNO (mp, inode); -if (agno >= mp->m_sb.sb_agcount) { -xfs_warn (mp,"%s: agno >= mp->m_sb.sb_agcount (%d >= %d)." , - __func__, agno, mp->m_sb.sb_agcount); -ASSERT (0 ); -return XFS_ERROR (EINVAL ); - } - agino =XFS_INO_TO_AGINO (mp, inode); -if (inode !=XFS_AGINO_TO_INO (mp, agno, agino)) { -xfs_warn (mp,"%s: inode != XFS_AGINO_TO_INO() (%llu != %llu)." , - __func__, (unsigned long long )inode, - (unsigned long long )XFS_AGINO_TO_INO (mp, agno, agino)); -ASSERT (0 ); -return XFS_ERROR (EINVAL ); - } - agbno =XFS_AGINO_TO_AGBNO (mp, agino); -if (agbno >= mp->m_sb.sb_agblocks) { -xfs_warn (mp,"%s: agbno >= mp->m_sb.sb_agblocks (%d >= %d)." , - __func__, agbno, mp->m_sb.sb_agblocks); -ASSERT (0 ); -return XFS_ERROR (EINVAL ); - } -/* -* Get the allocation group header. -*/ - error =xfs_ialloc_read_agi (mp, tp, agno, &agbp); -if (error) { -xfs_warn (mp,"%s: xfs_ialloc_read_agi() returned error %d." , - __func__, error); -return error; - } - agi =XFS_BUF_TO_AGI (agbp);ASSERT (agi->agi_magicnum ==cpu_to_be32 (XFS_AGI_MAGIC ));ASSERT (agbno <be32_to_cpu (agi->agi_length)); +/* * Initialize the cursor. */
@@ -1488,6 +1445,7 @@ xfs_difree(if (error) goto error0; + *orec = rec;xfs_btree_del_cursor (cur,XFS_BTREE_NOERROR );return 0 ;
@@ -1496,6 +1454,80 @@ error0:return error; } +/* +* Free disk inode. Carefully avoids touching the incore inode, all +* manipulations incore are the caller's responsibility. +* The on-disk inode is not changed by this operation, only the +* btree (free inode mask) is changed. +*/ +int +xfs_difree ( +xfs_trans_t *tp,/* transaction pointer */ +xfs_ino_t inode,/* inode to be freed */ +xfs_bmap_free_t *flist,/* extents to free */ +int *delete,/* set if inode cluster was deleted */ +xfs_ino_t *first_ino)/* first inode in deleted cluster */ +{ +/* REFERENCED */ +xfs_agblock_t agbno;/* block number containing inode */ +xfs_buf_t *agbp;/* buffer containing allocation group header */ +xfs_agino_t agino;/* inode number relative to allocation group */ +xfs_agnumber_t agno;/* allocation group number */ +int error;/* error return value */ +xfs_mount_t *mp;/* mount structure for filesystem */ +xfs_inobt_rec_incore_t rec;/* btree record */ + + mp = tp->t_mountp; + +/* +* Break up inode number into its components. +*/ + agno =XFS_INO_TO_AGNO (mp, inode); +if (agno >= mp->m_sb.sb_agcount) { +xfs_warn (mp,"%s: agno >= mp->m_sb.sb_agcount (%d >= %d)." , + __func__, agno, mp->m_sb.sb_agcount); +ASSERT (0 ); +return XFS_ERROR (EINVAL ); + } + agino =XFS_INO_TO_AGINO (mp, inode); +if (inode !=XFS_AGINO_TO_INO (mp, agno, agino)) { +xfs_warn (mp,"%s: inode != XFS_AGINO_TO_INO() (%llu != %llu)." , + __func__, (unsigned long long )inode, + (unsigned long long )XFS_AGINO_TO_INO (mp, agno, agino)); +ASSERT (0 ); +return XFS_ERROR (EINVAL ); + } + agbno =XFS_AGINO_TO_AGBNO (mp, agino); +if (agbno >= mp->m_sb.sb_agblocks) { +xfs_warn (mp,"%s: agbno >= mp->m_sb.sb_agblocks (%d >= %d)." , + __func__, agbno, mp->m_sb.sb_agblocks); +ASSERT (0 ); +return XFS_ERROR (EINVAL ); + } +/* +* Get the allocation group header. +*/ + error =xfs_ialloc_read_agi (mp, tp, agno, &agbp); +if (error) { +xfs_warn (mp,"%s: xfs_ialloc_read_agi() returned error %d." , + __func__, error); +return error; + } + +/* +* Fix up the inode allocation btree. +*/ + error =xfs_difree_inobt (mp, tp, agbp, agino, flist, delete, first_ino, + &rec); +if (error) + goto error0; + +return 0 ; + +error0: +return error; +} + STATIC int xfs_imap_lookup( struct xfs_mount *mp,
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 8/12 xfsprogs: update the finobt on inode free
In reply to Brian FosterAn inode free operation can have several effects on the finobt. If all inodes have been freed and the chunk deallocated, we remove the finobt record. If the inode chunk was previously full, we must insert a new record based on the existing inobt record. Otherwise, we modify the record in place.
Create the xfs_ifree_finobt() function to identify the potential scenarios and update the finobt appropriately.
--- libxfs/xfs_ialloc.c | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 109 insertions(+)
libxfs/xfs_ialloc.c +109 -0
@@ -1455,6 +1455,106 @@ error0: }/* +* Free an inode in the free inode btree. +*/ +STATIC int +xfs_difree_finobt ( +struct xfs_mount *mp, +struct xfs_trans *tp, +struct xfs_buf *agbp, +xfs_agino_t agino, +struct xfs_inobt_rec_incore *ibtrec)/* inobt record */ +{ +struct xfs_agi *agi =XFS_BUF_TO_AGI (agbp); +xfs_agnumber_t agno =be32_to_cpu (agi->agi_seqno); +struct xfs_btree_cur *cur; +struct xfs_inobt_rec_incore rec; +int offset = agino - ibtrec->ir_startino; +int error; +int i; + + cur =xfs_inobt_init_cursor (mp, tp, agbp, agno,XFS_BTNUM_FINO ); + + error =xfs_inobt_lookup (cur, ibtrec->ir_startino,XFS_LOOKUP_EQ , &i); +if (error) + goto error; +if (i ==0 ) { +/* +* If the record does not exist in the finobt, we must have just +* freed an inode in a previously fully allocated chunk. If not, +* something is out of sync. +*/ +XFS_WANT_CORRUPTED_GOTO (ibtrec->ir_freecount ==1 , error); + + error =xfs_inobt_insert_rec (cur, ibtrec->ir_freecount, + ibtrec->ir_free, &i); +if (error) + goto error; +ASSERT (i ==1 ); + + goto out; + } + +/* +* Read and update the existing record. +*/ + error =xfs_inobt_get_rec (cur, &rec, &i); +if (error) + goto error; +XFS_WANT_CORRUPTED_GOTO (i ==1 , error); + + rec.ir_free |=XFS_INOBT_MASK (offset); + rec.ir_freecount++; + +XFS_WANT_CORRUPTED_GOTO ((rec.ir_free == ibtrec->ir_free) && + (rec.ir_freecount == ibtrec->ir_freecount), + error); + +/* +* The content of inobt records should always match between the inobt +* and finobt. The lifecycle of records in the finobt is different from +* the inobt in that the finobt only tracks records with at least one +* free inode. This is to optimize lookup for inode allocation purposes. +* The following checks determine whether to update the existing record or +* remove it entirely. +*/ + +if (rec.ir_freecount ==XFS_IALLOC_INODES (mp) && + !(mp->m_flags &XFS_MOUNT_IKEEP )) { +/* +* If all inodes are free and we're in !ikeep mode, the entire +* inode chunk has been deallocated. Remove the record from the +* finobt. +*/ + error =xfs_btree_delete (cur, &i); +if (error) + goto error; +ASSERT (i ==1 ); + }else { +/* +* The existing finobt record was modified and has a combination +* of allocated and free inodes or is completely free and ikeep +* is enabled. Update the record. +*/ + error =xfs_inobt_update (cur, &rec); +if (error) + goto error; + } + +out: + error =xfs_check_agi_freecount (cur, agi); +if (error) + goto error; + +xfs_btree_del_cursor (cur,XFS_BTREE_NOERROR ); +return 0 ; + +error: +xfs_btree_del_cursor (cur,XFS_BTREE_ERROR ); +return error; +} + +/* * Free disk inode. Carefully avoids touching the incore inode, all * manipulations incore are the caller's responsibility. * The on-disk inode is not changed by this operation, only the
@@ -1522,6 +1622,15 @@ xfs_difree(if (error) goto error0; +/* +* Fix up the free inode btree. +*/ +if (xfs_sb_version_hasfinobt (&mp->m_sb)) { + error =xfs_difree_finobt (mp, tp, agbp, agino, &rec); +if (error) + goto error0; + } +return 0 ; error0:
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 9/12 xfsprogs: enable the finobt feature on v5 superblocks
In reply to Brian FosterAdd the finobt feature bit to the list of known features. As of this point, the kernel code knows how to mount and manage both finobt and non-finobt formatted filesystems.
--- include/xfs_sb.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/xfs_sb.h +2 -1
@@ -584,7 +584,8 @@ xfs_sb_has_compat_feature( }#define XFS_SB_FEAT_RO_COMPAT_FINOBT (1 << 0)/* free inode btree */ -#define XFS_SB_FEAT_RO_COMPAT_ALL 0 +#define XFS_SB_FEAT_RO_COMPAT_ALL \ + (XFS_SB_FEAT_RO_COMPAT_FINOBT)#define XFS_SB_FEAT_RO_COMPAT_UNKNOWN ~XFS_SB_FEAT_RO_COMPAT_ALLstatic inline bool xfs_sb_has_ro_compat_feature(
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 10/12 xfsprogs/mkfs: finobt mkfs support
In reply to Brian FosterAdd the 'finobt' metadata option to mkfs to format an fs with free inode btree support. If enabled, initialize the associated AGI header fields and btree root block.
Also, do the initialization of the superblock version and feature bits (including the new finobt flag) a bit earlier. These fields must now be initialized prior to the use of XFS_PREALLOC_BLOCKS(), as the latter returns a value that depends on whether a finobt root btree block is reserved.
--- mkfs/xfs_mkfs.c | 97 +++++++++++++++++++++++++++++++++++++++++---------------- 1 file changed, 71 insertions(+), 26 deletions(-)
mkfs/xfs_mkfs.c +71 -26
@@ -181,6 +181,8 @@ char *sopts[] = { char *mopts[] = {#define M_CRC 0 "crc", +#define M_FINOBT 1 +"finobt" ,NULL };
@@ -958,6 +960,7 @@ main(struct fs_topology ft;int lazy_sb_counters;int crcs_enabled; +int finobt; progname =basename (argv[0 ]);setlocale (LC_ALL ,"" );
@@ -990,6 +993,7 @@ main( worst_freelist =0 ; lazy_sb_counters =1 ; crcs_enabled =0 ; + finobt =0 ;memset (&fsx,0 ,sizeof (fsx));memset (&xi,0 ,sizeof (xi));
@@ -1476,6 +1480,14 @@ main(illegal (value,"m crc" ); crcs_enabled = c;break ; +case M_FINOBT : +if (!value || *value =='\0' ) +reqval ('m' , mopts,M_CRC ); + c =atoi (value); +if (c <0 || c >1 ) +illegal (value,"m finobt" ); + finobt = c; +break ;default :unknown ('m' , value); }
@@ -2384,6 +2396,37 @@ _("size %s specified for log subvolume is too large, maximum is %lld blocks\n"), mp->m_blkbb_log = sbp->sb_blocklog -BBSHIFT ; mp->m_sectbb_log = sbp->sb_sectlog -BBSHIFT ; +/* +* sb_versionnum and finobt flags must be set before we use +* XFS_PREALLOC_BLOCKS(). +*/ + sbp->sb_features2 =XFS_SB_VERSION2_MKFS (crcs_enabled, lazy_sb_counters, + attrversion ==2 , !projid16bit,0 ); + + sbp->sb_versionnum =XFS_SB_VERSION_MKFS (crcs_enabled, iaflag, + dsunit !=0 , + logversion ==2 , attrversion ==1 , + (sectorsize !=BBSIZE || + lsectorsize !=BBSIZE ), + nci, sbp->sb_features2 !=0 ); +/* +* dirent filetype field always enabled on v5 superblocks +*/ +if (crcs_enabled) { + sbp->sb_features_incompat =XFS_SB_FEAT_INCOMPAT_FTYPE ; + } + +/* +* Due to a structure alignment issue, sb_features2 ended up in one +* of two locations, the second "incorrect" location represented by +* the sb_bad_features2 field. To avoid older kernels mounting +* filesystems they shouldn't, set both field to the same value. +*/ + sbp->sb_bad_features2 = sbp->sb_features2; + +if (finobt) + sbp->sb_features_ro_compat =XFS_SB_FEAT_RO_COMPAT_FINOBT ; +if (loginternal) {/* * Readjust the log size to fit within an AG if it was sized
@@ -2438,7 +2481,7 @@ _("size %s specified for log subvolume is too large, maximum is %lld blocks\n"), printf(_( "meta-data=%-22s isize=%-6d agcount=%lld, agsize=%lld blks\n" " =%-22s sectsz=%-5u attr=%u, projid32bit=%u\n" - " =%-22s crc=%u\n" + " =%-22s crc=%-8u finobt=%u\n" "data =%-22s bsize=%-6u blocks=%llu, imaxpct=%u\n" " =%-22s sunit=%-6u swidth=%u blks\n" "naming =version %-14u bsize=%-6u ascii-ci=%d\n"
@@ -2447,7 +2490,7 @@ _("size %s specified for log subvolume is too large, maximum is %lld blocks\n"), "realtime =%-22s extsz=%-6d blocks=%lld, rtextents=%lld\n"), dfile, isize, (long long )agcount, (long long )agsize,"" , sectorsize, attrversion, !projid16bit, -"" , crcs_enabled, +"" , crcs_enabled, finobt,"" , blocksize, (long long )dblocks, imaxpct,"" , dsunit, dswidth, dirversion, dirblocksize, nci,
@@ -2512,28 +2555,6 @@ _("size %s specified for log subvolume is too large, maximum is %lld blocks\n"), sbp->sb_logsectlog =0 ; sbp->sb_logsectsize =0 ; } - sbp->sb_features2 =XFS_SB_VERSION2_MKFS (crcs_enabled, lazy_sb_counters, - attrversion ==2 , !projid16bit,0 ); - sbp->sb_versionnum =XFS_SB_VERSION_MKFS (crcs_enabled, iaflag, - dsunit !=0 , - logversion ==2 , attrversion ==1 , - (sectorsize !=BBSIZE || - lsectorsize !=BBSIZE ), - nci, sbp->sb_features2 !=0 ); -/* -* dirent filetype field always enabled on v5 superblocks -*/ -if (crcs_enabled) { - sbp->sb_features_incompat =XFS_SB_FEAT_INCOMPAT_FTYPE ; - } - -/* -* Due to a structure alignment issue, sb_features2 ended up in one -* of two locations, the second "incorrect" location represented by -* the sb_bad_features2 field. To avoid older kernels mounting -* filesystems they shouldn't, set both field to the same value. -*/ - sbp->sb_bad_features2 = sbp->sb_features2;if (force_overwrite)zero_old_xfs_structures (&xi, sbp);
@@ -2690,6 +2711,10 @@ _("size %s specified for log subvolume is too large, maximum is %lld blocks\n"), agi->agi_count =0 ; agi->agi_root =cpu_to_be32 (XFS_IBT_BLOCK (mp)); agi->agi_level =cpu_to_be32 (1 ); +if (finobt) { + agi->agi_free_root =cpu_to_be32 (XFS_FIBT_BLOCK (mp)); + agi->agi_free_level =cpu_to_be32 (1 ); + } agi->agi_freecount =0 ; agi->agi_newino =cpu_to_be32 (NULLAGINO ); agi->agi_dirino =cpu_to_be32 (NULLAGINO );
@@ -2815,6 +2840,26 @@ _("size %s specified for log subvolume is too large, maximum is %lld blocks\n"),xfs_btree_init_block (mp, buf,XFS_IBT_MAGIC ,0 ,0 , agno,0 );libxfs_writebuf (buf,LIBXFS_EXIT_ON_FAILURE ); + +/* +* Free INO btree root block +*/ +if (!finobt) +continue ; + + buf =libxfs_getbuf (mp->m_ddev_targp, +XFS_AGB_TO_DADDR (mp, agno,XFS_FIBT_BLOCK (mp)), + bsize); + buf->b_ops = &xfs_inobt_buf_ops; + block =XFS_BUF_TO_BLOCK (buf); +memset (block,0 , blocksize); +if (xfs_sb_version_hascrc (&mp->m_sb)) +xfs_btree_init_block (mp, buf,XFS_FIBT_CRC_MAGIC ,0 ,0 , + agno,XFS_BTREE_CRC_BLOCKS ); +else +xfs_btree_init_block (mp, buf,XFS_FIBT_MAGIC ,0 ,0 , + agno,0 ); +libxfs_writebuf (buf,LIBXFS_EXIT_ON_FAILURE ); }/*
@@ -3053,10 +3098,10 @@ usage( void ) { fprintf(stderr, _("Usage: %s\n\ /* blocksize */ [-b log=n|size=num]\n\ -/* metadata */ [-m crc=[0|1]\n\ +/* metadata */ [-m crc=0|1,finobt=0|1]\n\ /* data subvol */ [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\ (sunit=value,swidth=value|su=num,sw=num),\n\ - sectlog=n|sectsize=num\n\ + sectlog=n|sectsize=num]\n\ /* force overwrite */ [-f]\n\ /* inode size */ [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\ projid32bit=0|1]\n\
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 11/12 xfsprogs/db: finobt support
In reply to Brian FosterAdd the AGI finobt fields and fibt layouts.
--- db/agi.c | 2 ++ db/btblock.c | 12 ++++++++++++ 2 files changed, 14 insertions(+)
db/agi.c +2 -0
@@ -57,6 +57,8 @@ const field_t agi_flds[] = { { "uuid", FLDT_UUID, OI(OFF(uuid)), C1, 0, TYP_NONE }, { "lsn", FLDT_UINT64X, OI(OFF(lsn)), C1, 0, TYP_NONE }, { "crc", FLDT_UINT32X, OI(OFF(crc)), C1, 0, TYP_NONE }, + { "free_root", FLDT_AGBLOCK, OI(OFF(free_root)), C1, 0, TYP_INOBT }, + { "free_level", FLDT_UINT32D, OI(OFF(free_level)), C1, 0, TYP_NONE }, { NULL } };
db/btblock.c +12 -0
@@ -60,6 +60,12 @@ struct xfs_db_btree {sizeof (xfs_inobt_rec_t),sizeof (__be32), }, + { XFS_FIBT_MAGIC, +XFS_BTREE_SBLOCK_LEN , +sizeof (xfs_inobt_key_t), +sizeof (xfs_inobt_rec_t), +sizeof (__be32), + }, { XFS_BMAP_CRC_MAGIC,XFS_BTREE_LBLOCK_CRC_LEN , sizeof(xfs_bmbt_key_t),
@@ -84,6 +90,12 @@ struct xfs_db_btree { sizeof(xfs_inobt_rec_t), sizeof(__be32), }, + {XFS_FIBT_CRC_MAGIC , +XFS_BTREE_SBLOCK_CRC_LEN , +sizeof (xfs_inobt_key_t), +sizeof (xfs_inobt_rec_t), +sizeof (__be32), + }, { 0, }, };
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 12/12 xfsprogs/repair: account for finobt in ag 0 geometry pre-calculation
In reply to Brian FosterAccount for the finobt in calc_mkfs().
--- repair/xfs_repair.c | 2 ++ 1 file changed, 2 insertions(+)
repair/xfs_repair.c +2 -0
@@ -405,6 +405,8 @@ calc_mkfs(xfs_mount_t *mp) bcntbt_root = bnobt_root +1 ; inobt_root = bnobt_root +2 ; fino_bno = inobt_root +XFS_MIN_FREELIST_RAW (1 ,1 , mp) +1 ; +if (xfs_sb_version_hasfinobt (&mp->m_sb)) + fino_bno++;/* * If the log is allocated in the first allocation group we need to
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs