Skip to contentSkip to conversation

nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback_up' function

PATCH Superseded Geyslan G. Bem 1 participant 2 messages Oct 14, 2013

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback_up' function

Use 'PTR_ERR_OR_ZERO()' rather than 'IS_ERR(...) ? PTR_ERR(...) : 0'.

---
 fs/nfs/callback.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/nfs/callback.c +1 -2
index 67cd732..1c9e867 100644
@@ -164,8 +164,7 @@ nfs41_callback_up(struct svc_serv *serv)
 		svc_xprt_put(serv->sv_bc_xprt);
 		serv->sv_bc_xprt = NULL;
 	}
-	dprintk("--> %s return %ld\n", __func__,
-		IS_ERR(rqstp) ? PTR_ERR(rqstp) : 0);
+	dprintk("--> %s return %ld\n", __func__, PTR_ERR_OR_ZERO(rqstp));
 	return rqstp;
 }
 
Signature · 1 line
1.8.4
#1 lore raw

PATCH 1/1 nfs: Use PTR_ERR_OR_ZERO in 'nfs/nfs4super.c'

Use 'PTR_ERR_OR_ZERO()' rather than 'IS_ERR(...) ? PTR_ERR(...) : 0'.

---
 fs/nfs/nfs4super.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
fs/nfs/nfs4super.c +4 -4
index e26acdd..ef71077 100644
@@ -262,8 +262,8 @@ struct dentry *nfs4_try_mount(int flags, const char *dev_name,
 	res = nfs_follow_remote_path(root_mnt, export_path);
 
 	dfprintk(MOUNT, "<-- nfs4_try_mount() = %ld%s\n",
-			IS_ERR(res) ? PTR_ERR(res) : 0,
-			IS_ERR(res) ? " [error]" : "");
+		 PTR_ERR_OR_ZERO(res),
+		 IS_ERR(res) ? " [error]" : "");
 	return res;
 }
 
@@ -320,8 +320,8 @@ static struct dentry *nfs4_referral_mount(struct file_system_type *fs_type,
 
 	res = nfs_follow_remote_path(root_mnt, export_path);
 	dprintk("<-- nfs4_referral_mount() = %ld%s\n",
-			IS_ERR(res) ? PTR_ERR(res) : 0,
-			IS_ERR(res) ? " [error]" : "");
+		PTR_ERR_OR_ZERO(res),
+		IS_ERR(res) ? " [error]" : "");
 	return res;
 }
 
Signature · 1 line
1.8.4