Skip to contentSkip to conversation

s390: Remove unused variable in copy_from_realmem()

PATCH In review Geert Uytterhoeven 2 participants 2 messages Oct 15, 2013 s390

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390: Remove unused variable in copy_from_realmem()

arch/s390/kernel/crash_dump.c: In function 'copy_from_realmem':
arch/s390/kernel/crash_dump.c:48:6: warning: unused variable 'rc' [-Wunused-variable]

Introduced by commit 4d3b0664a0d0c0dc7501cfbd067f74226aeca510 ("s390: Allow vmalloc target buffers for copy_from_oldmem()").

---
 arch/s390/kernel/crash_dump.c |    1 -
 1 file changed, 1 deletion(-)
arch/s390/kernel/crash_dump.c +0 -1
index 7dd21720e5b0..3db6af0601a5 100644
@@ -45,7 +45,6 @@ static inline void *load_real_addr(void *addr)
 static int copy_from_realmem(void *dest, void *src, size_t count)
 {
 	unsigned long size;
-	int rc;
 
 	if (!count)
 		return 0;
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 16 lines · On Tue, 15 Oct 2013 08:50:11 +0200 Geert Uytterhoeven <[email protected]>…

arch/s390/kernel/crash_dump.c: In function 'copy_from_realmem':
arch/s390/kernel/crash_dump.c:48:6: warning: unused variable 'rc' [-Wunused-variable]

Introduced by commit 4d3b0664a0d0c0dc7501cfbd067f74226aeca510 ("s390: Allow vmalloc target buffers for copy_from_oldmem()").

---
 arch/s390/kernel/crash_dump.c |    1 -
 1 file changed, 1 deletion(-)
arch/s390/kernel/crash_dump.c +0 -0
index 7dd21720e5b0..3db6af0601a5 100644

arch/s390/kernel/crash_dump.c static inline void *load_real_addr(void *addr) · line 50

Quoted 7 lines
arch/s390/kernel/crash_dump.c +0 -1
@@ -45,7 +45,6 @@ static inline void *load_real_addr(void *addr)
 static int copy_from_realmem(void *dest, void *src, size_t count)
 {
 	unsigned long size;
-	int rc;
 
 	if (!count)
 		return 0;

Thanks for the hint but there is already a equivalent patch from Heiko on the features branch on git-s390. I plan to get it pulled in the merge window for 3.13 as I feel that the warning is not important enough to fix it now.

Signature · 4 lines
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.