serial: xuartlite: Staticize local functions
PATCH v2 1/2 serial: xuartlite: Staticize local functions
Staticize local functions in xuartlite driver.
---
v2: Also staticize userial##port##_* functions
drivers/serial/serial_xuartlite.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
drivers/serial/serial_xuartlite.c +10 -10
@@ -39,7 +39,7 @@ static struct uartlite *userial_ports[4] = {#endif }; -void uartlite_serial_putc (const char c,const int port) +static void uartlite_serial_putc (const char c,const int port) {struct uartlite *regs = userial_ports[port];
@@ -51,13 +51,13 @@ void uartlite_serial_putc(const char c, const int port)out_be32 (®s->tx_fifo, c &0xff ); } -void uartlite_serial_puts (const char *s,const int port) +static void uartlite_serial_puts (const char *s,const int port) {while (*s)uartlite_serial_putc (*s++, port); } -int uartlite_serial_getc (const int port) +static int uartlite_serial_getc (const int port) {struct uartlite *regs = userial_ports[port];
@@ -66,7 +66,7 @@ int uartlite_serial_getc(const int port)return in_be32 (®s->rx_fifo) &0xff ; } -int uartlite_serial_tstc (const int port) +static int uartlite_serial_tstc (const int port) {struct uartlite *regs = userial_ports[port];
@@ -82,16 +82,16 @@ static int uartlite_serial_init(const int port)/* Multi serial device functions */ #define DECLARE_ESERIAL_FUNCTIONS (port) \ - int userial##port##_init(void) \ + static int userial##port##_init(void) \ { return uartlite_serial_init(port); } \ - void userial##port##_setbrg(void) {} \ - int userial##port##_getc(void) \ + static void userial##port##_setbrg(void) {} \ + static int userial##port##_getc(void) \ { return uartlite_serial_getc(port); } \ - int userial##port##_tstc(void) \ + static int userial##port##_tstc(void) \ { return uartlite_serial_tstc(port); } \ - void userial##port##_putc(const char c) \ + static void userial##port##_putc(const char c) \ { uartlite_serial_putc(c, port); } \ - void userial##port##_puts(const char *s) \ + static void userial##port##_puts(const char *s) \ { uartlite_serial_puts(s, port); }/* Serial device descriptor */
Signature · 1 line
1.8.1.2
PATCH v2 2/2 serial: s5p: Staticize local functions
Staticize local functions in s5p serial driver.
---
v2: Also staticize s5p_serial##port##_* functions
drivers/serial/serial_s5p.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/serial/serial_s5p.c +12 -12
@@ -65,7 +65,7 @@ static const int udivslot[] = { 0xffdf, }; -void serial_setbrg_dev (const int dev_index) +static void serial_setbrg_dev (const int dev_index) {struct s5p_uart *const uart =s5p_get_base_uart (dev_index);u32 uclk =get_uart_clk (dev_index);
@@ -96,7 +96,7 @@ void serial_setbrg_dev(const int dev_index)* Initialise the serial port with the given baudrate. The settings * are always 8 data bits, no parity, 1 stop bit, no start bits. */ -int serial_init_dev (const int dev_index) +static int serial_init_dev (const int dev_index) {struct s5p_uart *const uart =s5p_get_base_uart (dev_index);
@@ -138,7 +138,7 @@ static int serial_err_check(const int dev_index, int op)* otherwise. When the function is succesfull, the character read is * written into its argument c. */ -int serial_getc_dev (const int dev_index) +static int serial_getc_dev (const int dev_index) {struct s5p_uart *const uart =s5p_get_base_uart (dev_index);
@@ -158,7 +158,7 @@ int serial_getc_dev(const int dev_index)/* * Output a single byte to the serial port. */ -void serial_putc_dev (const char c,const int dev_index) +static void serial_putc_dev (const char c,const int dev_index) {struct s5p_uart *const uart =s5p_get_base_uart (dev_index);
@@ -181,7 +181,7 @@ void serial_putc_dev(const char c, const int dev_index)/* * Test whether a character is in the RX buffer */ -int serial_tstc_dev (const int dev_index) +static int serial_tstc_dev (const int dev_index) {struct s5p_uart *const uart =s5p_get_base_uart (dev_index);
@@ -191,7 +191,7 @@ int serial_tstc_dev(const int dev_index)return (int )(readl (&uart->utrstat) &0x1 ); } -void serial_puts_dev (const char *s,const int dev_index) +static void serial_puts_dev (const char *s,const int dev_index) {while (*s)serial_putc_dev (*s++, dev_index);
@@ -199,12 +199,12 @@ void serial_puts_dev(const char *s, const int dev_index)/* Multi serial device functions */ #define DECLARE_S5P_SERIAL_FUNCTIONS (port) \ -int s5p_serial##port##_init(void) { return serial_init_dev(port); } \ -void s5p_serial##port##_setbrg(void) { serial_setbrg_dev(port); } \ -int s5p_serial##port##_getc(void) { return serial_getc_dev(port); } \ -int s5p_serial##port##_tstc(void) { return serial_tstc_dev(port); } \ -void s5p_serial##port##_putc(const char c) { serial_putc_dev(c, port); } \ -void s5p_serial##port##_puts(const char *s) { serial_puts_dev(s, port); } +static int s5p_serial##port##_init(void) { return serial_init_dev(port); } \ +static void s5p_serial##port##_setbrg(void) { serial_setbrg_dev(port); } \ +static int s5p_serial##port##_getc(void) { return serial_getc_dev(port); } \ +static int s5p_serial##port##_tstc(void) { return serial_tstc_dev(port); } \ +static void s5p_serial##port##_putc(const char c) { serial_putc_dev(c, port); } \ +static void s5p_serial##port##_puts(const char *s) { serial_puts_dev(s, port); }#define INIT_S5P_SERIAL_STRUCTURE (port, __name) { \ .name = __name, \
Signature · 1 line
1.8.1.2
PATCH v2 2/2 serial: s5p: Staticize local functions
Quoted 8 lines · Axel Lin
Staticize local functions in s5p serial driver.
Signed-off-by Axel Lin <[email protected]>---
v2: Also staticize s5p_serial##port##_* functionsdrivers/serial/serial_s5p.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
Thanks,
Minkyu Kang.
PATCH v2 1/2 serial: xuartlite: Staticize local functions
In reply to Axel LinQuoted 3 lines · Axel Lin
Staticize local functions in xuartlite driver.
Signed-off-by Axel Lin <[email protected]>
Thanks,
Stefan
PATCH v2 1/2 serial: xuartlite: Staticize local functions
Quoted 6 lines · Stefan Roese
Quoted 3 lines · Axel Lin
Staticize local functions in xuartlite driver.
Signed-off-by Axel Lin <[email protected]>Acked-by Stefan Roese <[email protected]>
Thanks,
Michal
Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 263 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131016/c72823ac/attachment.pgp>
PATCH v2 1/2 serial: xuartlite: Staticize local functions
In reply to Axel LinQuoted 5 lines · Axel Lin
Staticize local functions in xuartlite driver.
Signed-off-by Axel Lin <[email protected]>Acked-by Stefan Roese <[email protected]>Tested-by Michal Simek <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131108/220c600b/attachment.pgp>
PATCH v2 2/2 serial: s5p: Staticize local functions
In reply to Axel LinQuoted 4 lines · Axel Lin
Staticize local functions in s5p serial driver.
Signed-off-by Axel Lin <[email protected]>Acked-by Minkyu Kang <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131108/3900a7f6/attachment.pgp>